diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #28880 [HttpFoundation] Publicify new consts (ro0NL)

Browse Source 
This PR was merged into the 4.2-dev branch.

Discussion
----------

[HttpFoundation] Publicify new consts

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Continuation of #28807

I think it's reasonable to enforce visibility for new consts, ideally solved by PHP-CS-Fixer. This makes it explicit for the consts to be consumed as part of public API.

Commits
-------

ce95d0d33d [HttpFoundation] Publicify new consts
This commit is contained in:
Fabien Potencier 2018-10-15 17:42:43 +02:00
commit d813148e91
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/HttpFoundation/HeaderUtils.php
View File

@ -18,8 +18,8 @@ namespace Symfony\Component\HttpFoundation;
*/
class HeaderUtils
{
const DISPOSITION_ATTACHMENT = 'attachment';
const DISPOSITION_INLINE = 'inline';
public const DISPOSITION_ATTACHMENT = 'attachment';
public const DISPOSITION_INLINE = 'inline';
/**
* This class should not be instantiated.