diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch bschussek/issue3179 (PR #5069)

Browse Source 
Commits
-------

9f4178b [Validator] Fixed: StaticMethodLoader does not try to invoke methods of interfaces anymore

Discussion
----------

[Validator] Fixed: StaticMethodLoader does not try to invoke methods of interfaces anymore

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3179
Todo: -
This commit is contained in:
Fabien Potencier 2012-07-26 17:49:39 +02:00
commit d92daec6e1
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Validator/Mapping/Loader/StaticMethodLoader.php
View File

@ -28,9 +28,10 @@ class StaticMethodLoader implements LoaderInterface
*/
public function loadClassMetadata(ClassMetadata $metadata)
{
/** @var \ReflectionClass $reflClass */
$reflClass = $metadata->getReflectionClass();
if ($reflClass->hasMethod($this->methodName)) {
if (!$reflClass->isInterface() && $reflClass->hasMethod($this->methodName)) {
$reflMethod = $reflClass->getMethod($this->methodName);
if (!$reflMethod->isStatic()) {

15
tests/Symfony/Tests/Component/Validator/Mapping/Loader/StaticMethodLoaderTest.php
View File

@ -57,6 +57,21 @@ class StaticMethodLoaderTest extends \PHPUnit_Framework_TestCase
$loader->loadClassMetadata($metadata);
$this->assertSame(1, count($metadata->getConstraints()));
}
public function testLoadClassMetadataIgnoresInterfaces()
{
$loader = new StaticMethodLoader('loadMetadata');
$metadata = new ClassMetadata(__NAMESPACE__.'\StaticLoaderInterface');
$loader->loadClassMetadata($metadata);
$this->assertSame(0, count($metadata->getConstraints()));
}
}
interface StaticLoaderInterface
{
public static function loadMetadata(ClassMetadata $metadata);
}
class StaticLoaderEntity