bug #31757 [DomCrawler] Fix type error with null Form::$currentUri (chalasr)
This PR was merged into the 4.2 branch.
Discussion
----------
[DomCrawler] Fix type error with null Form::$currentUri
| Q | A
| ------------- | ---
| Branch? | 4.2
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #31644
| License | MIT
| Doc PR | n/a
Commits
-------
e48d5d07e3
[DomCrawler] Fix type error with null Form::$currentUri
This commit is contained in:
commit
da01afacfc
@ -44,7 +44,7 @@ class Form extends Link implements \ArrayAccess
|
||||
*
|
||||
* @throws \LogicException if the node is not a button inside a form tag
|
||||
*/
|
||||
public function __construct(\DOMElement $node, string $currentUri, string $method = null, string $baseHref = null)
|
||||
public function __construct(\DOMElement $node, string $currentUri = null, string $method = null, string $baseHref = null)
|
||||
{
|
||||
parent::__construct($node, $currentUri, $method);
|
||||
$this->baseHref = $baseHref;
|
||||
|
@ -1091,6 +1091,7 @@ HTML;
|
||||
['/basepath', '/registration', 'http://domain.com/registration', 'http://domain.com/registration', '<base> tag does work with a path and form action'],
|
||||
['/basepath', '', 'http://domain.com/registration', 'http://domain.com/registration', '<base> tag does work with a path and empty form action'],
|
||||
['http://base.com/', '/registration', 'http://base.com/registration', 'http://domain.com/registration', '<base> tag does work with a URL and form action'],
|
||||
['http://base.com/', 'http://base.com/registration', 'http://base.com/registration', null, '<base> tag does work with a URL and form action'],
|
||||
['http://base.com', '', 'http://domain.com/path/form', 'http://domain.com/path/form', '<base> tag does work with a URL and an empty form action'],
|
||||
['http://base.com/path', '/registration', 'http://base.com/registration', 'http://domain.com/path/form', '<base> tag does work with a URL and form action'],
|
||||
];
|
||||
|
Reference in New Issue
Block a user