merged branch bschussek/issue2059 (PR #5945)
This PR was merged into the 2.0 branch.
Commits
-------
8fb334f
[Form] Excluded some tests in NumberToLocalizedStringTransformerTest which fail on ICU 4.4, but work on ICU 4.8
Discussion
----------
[Form] Excluded some tests in NumberToLocalizedStringTransformerTest which fail on ICU 4.4, but work on ICU 4.8
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
This commit is contained in:
commit
da33e7afd3
@ -98,6 +98,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
|
|
||||||
public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
|
public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
\Locale::setDefault('fr');
|
\Locale::setDefault('fr');
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
@ -115,6 +119,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
*/
|
*/
|
||||||
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
|
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
$transformer->reverseTransform('1.234.5');
|
$transformer->reverseTransform('1.234.5');
|
||||||
@ -125,6 +133,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
*/
|
*/
|
||||||
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot_noGroupSep()
|
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot_noGroupSep()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
$transformer->reverseTransform('1234.5');
|
$transformer->reverseTransform('1234.5');
|
||||||
@ -141,6 +153,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
|
|
||||||
public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
|
public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
\Locale::setDefault('ak');
|
\Locale::setDefault('ak');
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
@ -158,6 +174,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
*/
|
*/
|
||||||
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
|
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
\Locale::setDefault('en');
|
\Locale::setDefault('en');
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
@ -169,6 +189,10 @@ class NumberToLocalizedStringTransformerTest extends LocalizedTestCase
|
|||||||
*/
|
*/
|
||||||
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma_noGroupSep()
|
public function testDecimalSeparatorMayNotBeCommaIfGroupingSeparatorIsComma_noGroupSep()
|
||||||
{
|
{
|
||||||
|
if ($this->isLowerThanIcuVersion('4.5')) {
|
||||||
|
$this->markTestSkipped('Please upgrade ICU version to 4.5+');
|
||||||
|
}
|
||||||
|
|
||||||
\Locale::setDefault('en');
|
\Locale::setDefault('en');
|
||||||
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
$transformer = new NumberToLocalizedStringTransformer(null, true);
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user