diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #36354 Revert to container.dumper.inline_factories=false by default (nicolas-grekas)

Browse Source 
This PR was merged into the 5.1-dev branch.

Discussion
----------

Revert to container.dumper.inline_factories=false by default

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As spotted by @Tobion in https://github.com/symfony/symfony/pull/36193#pullrequestreview-387892170

Commits
-------

2b6f1e9a93 Revert to container.dumper.inline_factories=false by default
This commit is contained in:
Fabien Potencier 2020-04-06 11:54:21 +02:00
commit dadb5d8198
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php
View File

@ -142,10 +142,6 @@ trait MicroKernelTrait
}
$container->setAlias(static::class, 'kernel')->setPublic(true);
if (!$container->hasParameter('container.dumper.inline_factories')) {
$container->setParameter('container.dumper.inline_factories', false);
}
});
}

2
src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
View File

@ -157,7 +157,7 @@ class PhpDumper extends Dumper
$this->asFiles = $options['as_files'];
$this->hotPathTag = $options['hot_path_tag'];
$this->preloadTags = $options['preload_tags'];
$this->inlineFactories = $this->asFiles && $options['inline_factories_parameter'] && (!$this->container->hasParameter($options['inline_factories_parameter']) || $this->container->getParameter($options['inline_factories_parameter']));
$this->inlineFactories = $this->asFiles && $options['inline_factories_parameter'] && $this->container->hasParameter($options['inline_factories_parameter']) && $this->container->getParameter($options['inline_factories_parameter']);
$this->inlineRequires = $options['inline_class_loader_parameter'] && ($this->container->hasParameter($options['inline_class_loader_parameter']) ? $this->container->getParameter($options['inline_class_loader_parameter']) : (\PHP_VERSION_ID < 70400 || $options['debug']));
$this->serviceLocatorTag = $options['service_locator_tag'];