From ddea90e97d47e6e69f0d9998b56191e5699f484d Mon Sep 17 00:00:00 2001 From: Robin Chalas Date: Fri, 6 Jul 2018 11:08:29 +0200 Subject: [PATCH] minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired) This PR was merged into the 4.2-dev branch. Discussion ---------- [Console] changed warning verbosity; fixes typo | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes* | Fixed tickets | n/a | License | MIT | Doc PR | n/a * Tests pass, but I do not have an installation of MacOS to run tests on. Tests should be unaffected (the test is simply [skipped on MacOS](https://github.com/symfony/console/blob/master/Tests/Command/CommandTest.php#L345)). When a Console Command fails to change the process title on MacOS, a warning is issued to output. This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing. This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage. I've also fixed a typo in the message ("get" vs. "set"). Commits ------- 86c771a changed warning verbosity; fixes typo --- src/Symfony/Component/Console/Command/Command.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php index c8db0cff07..b1f31ce794 100644 --- a/src/Symfony/Component/Console/Command/Command.php +++ b/src/Symfony/Component/Console/Command/Command.php @@ -210,7 +210,10 @@ class Command if (function_exists('cli_set_process_title')) { if (!@cli_set_process_title($this->processTitle)) { if ('Darwin' === PHP_OS) { - $output->writeln('Running "cli_get_process_title" as an unprivileged user is not supported on MacOS.'); + $output->writeln( + 'Running "cli_set_process_title" as an unprivileged user is not supported on MacOS.', + OutputInterface::VERBOSITY_VERY_VERBOSE + ); } else { cli_set_process_title($this->processTitle); }