diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #26548 [DomCrawler] Change bad wording in ChoiceFormField::untick (dunglas) 

This PR was merged into the 2.7 branch.

Discussion
----------

[DomCrawler] Change bad wording in ChoiceFormField::untick

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

s/tick/untick/

Commits
-------

a4ec6d3 [DomCrawler] Change bad wording in ChoiceFormField::untick
This commit is contained in:
Nicolas Grekas 2018-03-16 10:14:45 +01:00
parent ffd088a38f a4ec6d3c9c
commit df6024d560
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php
View File

@ -97,14 +97,14 @@ class ChoiceFormField extends FormField
}
/**
* Ticks a checkbox.
* Unticks a checkbox.
*
* @throws \LogicException When the type provided is not correct
*/
public function untick()
{
if ('checkbox' !== $this->type) {
throw new \LogicException(sprintf('You cannot tick "%s" as it is not a checkbox (%s).', $this->name, $this->type));
throw new \LogicException(sprintf('You cannot untick "%s" as it is not a checkbox (%s).', $this->name, $this->type));
}
$this->setValue(false);