feature #28745 [WebServerBundle] Deprecate relying on --env in server:start and server:run (chalasr)
This PR was merged into the 4.2-dev branch.
Discussion
----------
[WebServerBundle] Deprecate relying on --env in server:start and server:run
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
31b5615b51
[WebServerBundle] Deprecate relying on --env in server:start and server:run
This commit is contained in:
commit
e0cb4525b0
@ -231,3 +231,9 @@ Validator
|
|||||||
* Using the `Bic`, `Country`, `Currency`, `Language` and `Locale` constraints without `symfony/intl` is deprecated
|
* Using the `Bic`, `Country`, `Currency`, `Language` and `Locale` constraints without `symfony/intl` is deprecated
|
||||||
* Using the `Email` constraint without `egulias/email-validator` is deprecated
|
* Using the `Email` constraint without `egulias/email-validator` is deprecated
|
||||||
* Using the `Expression` constraint without `symfony/expression-language` is deprecated
|
* Using the `Expression` constraint without `symfony/expression-language` is deprecated
|
||||||
|
|
||||||
|
WebServerBundle
|
||||||
|
---------------
|
||||||
|
|
||||||
|
* Omitting the `$environment` argument of the `ServerRunCommand` and
|
||||||
|
`ServerStartCommand` constructors is deprecated.
|
||||||
|
@ -222,3 +222,9 @@ Workflow
|
|||||||
* `add` method has been removed use `addWorkflow` method in `Workflow\Registry` instead.
|
* `add` method has been removed use `addWorkflow` method in `Workflow\Registry` instead.
|
||||||
* `SupportStrategyInterface` has been removed, use `WorkflowSupportStrategyInterface` instead.
|
* `SupportStrategyInterface` has been removed, use `WorkflowSupportStrategyInterface` instead.
|
||||||
* `ClassInstanceSupportStrategy` has been removed, use `InstanceOfSupportStrategy` instead.
|
* `ClassInstanceSupportStrategy` has been removed, use `InstanceOfSupportStrategy` instead.
|
||||||
|
|
||||||
|
WebServerBundle
|
||||||
|
---------------
|
||||||
|
|
||||||
|
* Omitting the `$environment` argument of the `ServerRunCommand` and
|
||||||
|
`ServerStartCommand` constructors now throws a `\TypeError.
|
||||||
|
@ -1,6 +1,12 @@
|
|||||||
CHANGELOG
|
CHANGELOG
|
||||||
=========
|
=========
|
||||||
|
|
||||||
|
4.2.0
|
||||||
|
-----
|
||||||
|
|
||||||
|
* Deprecated omitting the `$environment` argument of the `ServerRunCommand` and
|
||||||
|
`ServerStartCommand` constructors
|
||||||
|
|
||||||
3.4.0
|
3.4.0
|
||||||
-----
|
-----
|
||||||
|
|
||||||
|
@ -36,6 +36,10 @@ class ServerRunCommand extends Command
|
|||||||
|
|
||||||
public function __construct(string $documentRoot = null, string $environment = null)
|
public function __construct(string $documentRoot = null, string $environment = null)
|
||||||
{
|
{
|
||||||
|
if (!$environment) {
|
||||||
|
@trigger_error(sprintf('Omitting the $environment argument of the "%s" constructor is deprecated since Symfony 4.2.', __CLASS__), E_USER_DEPRECATED);
|
||||||
|
}
|
||||||
|
|
||||||
$this->documentRoot = $documentRoot;
|
$this->documentRoot = $documentRoot;
|
||||||
$this->environment = $environment;
|
$this->environment = $environment;
|
||||||
|
|
||||||
@ -99,6 +103,7 @@ EOF
|
|||||||
$documentRoot = $this->documentRoot;
|
$documentRoot = $this->documentRoot;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// @deprecated since Symfony 4.2
|
||||||
if (!$env = $this->environment) {
|
if (!$env = $this->environment) {
|
||||||
if ($input->hasOption('env') && !$env = $input->getOption('env')) {
|
if ($input->hasOption('env') && !$env = $input->getOption('env')) {
|
||||||
$io->error('The environment must be either passed as second argument of the constructor or through the "--env" input option.');
|
$io->error('The environment must be either passed as second argument of the constructor or through the "--env" input option.');
|
||||||
|
@ -36,6 +36,10 @@ class ServerStartCommand extends Command
|
|||||||
|
|
||||||
public function __construct(string $documentRoot = null, string $environment = null)
|
public function __construct(string $documentRoot = null, string $environment = null)
|
||||||
{
|
{
|
||||||
|
if (!$environment) {
|
||||||
|
@trigger_error(sprintf('Omitting the $environment argument of the "%s" constructor is deprecated since Symfony 4.2.', __CLASS__), E_USER_DEPRECATED);
|
||||||
|
}
|
||||||
|
|
||||||
$this->documentRoot = $documentRoot;
|
$this->documentRoot = $documentRoot;
|
||||||
$this->environment = $environment;
|
$this->environment = $environment;
|
||||||
|
|
||||||
@ -112,6 +116,7 @@ EOF
|
|||||||
$documentRoot = $this->documentRoot;
|
$documentRoot = $this->documentRoot;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// @deprecated since Symfony 4.2
|
||||||
if (!$env = $this->environment) {
|
if (!$env = $this->environment) {
|
||||||
if ($input->hasOption('env') && !$env = $input->getOption('env')) {
|
if ($input->hasOption('env') && !$env = $input->getOption('env')) {
|
||||||
$io->error('The environment must be either passed as second argument of the constructor or through the "--env" input option.');
|
$io->error('The environment must be either passed as second argument of the constructor or through the "--env" input option.');
|
||||||
|
Reference in New Issue
Block a user