diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merged branch stof/fix_interface (PR #4306)

Browse Source 
Commits
-------

11e0d23 [HttpKernel] Fixed the BundleInterface

Discussion
----------

[HttpKernel] Fixed the BundleInterface

The kernel expects bundles to implement ContainerAwareInterface (a fatal
error occurs if the method is not implemented). This is done in the base
class but not enforced in the interface.

I spotted it when trying to mock the BundleInterface and pass the mock to the kernel. I created the branch based on master because it is changing the interface but I'm wondering if it should go in 2.0 instead as a bugfix. Someone implementing strictly the interface currently would not be able to use the kernel.

---------------------------------------------------------------------------

by travisbot at 2012-05-17T10:41:19Z

This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1354421) (merged 11e0d232 into 5314836d).
This commit is contained in:
Fabien Potencier 2012-05-17 20:40:39 +02:00
commit e4eead39dd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php
View File

@ -11,7 +11,9 @@
namespace Symfony\Component\HttpKernel\Bundle;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
/**
* BundleInterface.
@ -20,7 +22,7 @@ use Symfony\Component\DependencyInjection\ContainerBuilder;
*
* @api
*/
interface BundleInterface
interface BundleInterface extends ContainerAwareInterface
{
/**
* Boots the Bundle.