diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Form] Improve rounding precision

Browse Source
This commit is contained in:
foaly-nr1 2017-02-26 13:27:06 +00:00 committed by Fabien Potencier
parent a786b5aaaf
commit e50804cef4
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
View File

@ -266,7 +266,8 @@ class NumberToLocalizedStringTransformer implements DataTransformerInterface
if (null !== $this->precision && null !== $this->roundingMode) {
// shift number to maintain the correct scale during rounding
$roundingCoef = pow(10, $this->precision);
$number *= $roundingCoef;
// string representation to avoid rounding errors, similar to bcmul()
$number = (string) ($number * $roundingCoef);
switch ($this->roundingMode) {
case self::ROUND_CEILING:

2
src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
View File

@ -307,6 +307,8 @@ class NumberToLocalizedStringTransformerTest extends TestCase
array(1, '123,44', 123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
array(1, '-123,45', -123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
array(1, '-123,44', -123.4, NumberToLocalizedStringTransformer::ROUND_DOWN),
array(2, '37.37', 37.37, NumberToLocalizedStringTransformer::ROUND_DOWN),
array(2, '2.01', 2.01, NumberToLocalizedStringTransformer::ROUND_DOWN),
// round halves (.5) to the next even number
array(0, '1234,6', 1235, NumberToLocalizedStringTransformer::ROUND_HALF_EVEN),
array(0, '1234,5', 1234, NumberToLocalizedStringTransformer::ROUND_HALF_EVEN),