diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #24908 [WebServerBundle] Prevent console.terminate from being fired when server:start finishes (kbond)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[WebServerBundle] Prevent console.terminate from being fired when server:start finishes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24885
| License       | MIT
| Doc PR        | n/a

When the cache is cleared between `server:start` and `server:stop` the container used in `server:start` is no longer valid. Firing the `console.terminate` event throws an exception. This PR clears the event dispatcher so `console.terminate` is not fired.

Commits
-------

699339eb0c [WebServerBundle] prevent console.terminate from being fired after stopping server
This commit is contained in:
Fabien Potencier 2017-11-10 10:32:45 -08:00
commit e68919af79
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php
View File

@ -19,6 +19,7 @@ use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Output\ConsoleOutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\EventDispatcher\EventDispatcher;
/**
* Runs a local web server in a background process.
@ -132,6 +133,10 @@ EOF
$io->error('Running this server in production environment is NOT recommended!');
}
// replace event dispatcher with an empty one to prevent console.terminate from firing
// as container could have changed between start and stop
$this->getApplication()->setDispatcher(new EventDispatcher());
try {
$server = new WebServer();
if ($server->isRunning($input->getOption('pidfile'))) {