From e726cdd91722a6311519ca72f9f292ea332fac0a Mon Sep 17 00:00:00 2001 From: Kris Wallsmith Date: Tue, 26 Apr 2011 07:22:22 -0700 Subject: [PATCH] changed some skipped tests to incomplete --- .../Doctrine/Form/Type/EntityTypeTest.php | 2 +- .../Form/Extension/Core/Type/DateTypeTest.php | 34 +++++++++---------- .../Form/Extension/Core/Type/TimeTypeTest.php | 34 +++++++++---------- .../Tests/Component/HttpKernel/KernelTest.php | 2 +- .../Tests/Component/Locale/TestCase.php | 4 +-- 5 files changed, 37 insertions(+), 39 deletions(-) diff --git a/tests/Symfony/Tests/Bridge/Doctrine/Form/Type/EntityTypeTest.php b/tests/Symfony/Tests/Bridge/Doctrine/Form/Type/EntityTypeTest.php index c591c13b61..8f8cc60313 100644 --- a/tests/Symfony/Tests/Bridge/Doctrine/Form/Type/EntityTypeTest.php +++ b/tests/Symfony/Tests/Bridge/Doctrine/Form/Type/EntityTypeTest.php @@ -421,7 +421,7 @@ class EntityTypeTest extends TypeTestCase public function testOverrideChoices() { - $this->markTestSkipped('Fix me'); + $this->markTestIncomplete('Fix me'); $entity1 = new SingleIdentEntity(1, 'Foo'); $entity2 = new SingleIdentEntity(2, 'Bar'); diff --git a/tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTypeTest.php b/tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTypeTest.php index cde4738de6..3e910e93b6 100644 --- a/tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTypeTest.php +++ b/tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTypeTest.php @@ -173,7 +173,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsYearWithinRangeReturnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -189,7 +189,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsYearWithinRangeReturnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -205,7 +205,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsYearWithinRangeReturnsTrueIfEmptyChoice() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -225,7 +225,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsYearWithinRangeReturnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -241,7 +241,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsMonthWithinRangeReturnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -257,7 +257,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsMonthWithinRangeReturnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -273,7 +273,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsMonthWithinRangeReturnsTrueIfEmptyChoice() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -293,7 +293,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsMonthWithinRangeReturnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -309,7 +309,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsDayWithinRangeReturnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -325,7 +325,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsDayWithinRangeReturnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -341,7 +341,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsDayWithinRangeReturnsTrueIfEmptyChoice() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -361,9 +361,9 @@ class DateTypeTest extends LocalizedTestCase public function testIsDayWithinRangeReturnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -379,7 +379,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsPartiallyFilledReturnsFalseIfInput() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -394,7 +394,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsPartiallyFilledReturnsFalseIfChoiceAndCompletelyEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -413,7 +413,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsPartiallyFilledReturnsFalseIfChoiceAndCompletelyFilled() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', @@ -432,7 +432,7 @@ class DateTypeTest extends LocalizedTestCase public function testIsPartiallyFilledReturnsTrueIfChoiceAndDayEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('date', null, array( 'data_timezone' => 'UTC', diff --git a/tests/Symfony/Tests/Component/Form/Extension/Core/Type/TimeTypeTest.php b/tests/Symfony/Tests/Component/Form/Extension/Core/Type/TimeTypeTest.php index 5146492b95..0870d693cc 100644 --- a/tests/Symfony/Tests/Component/Form/Extension/Core/Type/TimeTypeTest.php +++ b/tests/Symfony/Tests/Component/Form/Extension/Core/Type/TimeTypeTest.php @@ -144,7 +144,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsHourWithinRange_returnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'hours' => array(6, 7), @@ -157,7 +157,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsHourWithinRange_returnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'hours' => array(6, 7), @@ -170,7 +170,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsHourWithinRange_returnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'hours' => array(6, 7), @@ -183,7 +183,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsMinuteWithinRange_returnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'minutes' => array(6, 7), @@ -196,7 +196,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsMinuteWithinRange_returnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'minutes' => array(6, 7), @@ -209,7 +209,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsMinuteWithinRange_returnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'minutes' => array(6, 7), @@ -222,7 +222,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsSecondWithinRange_returnsTrueIfWithin() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'seconds' => array(6, 7), @@ -236,7 +236,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsSecondWithinRange_returnsTrueIfEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'seconds' => array(6, 7), @@ -250,7 +250,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsSecondWithinRange_returnsTrueIfNotWithSeconds() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'seconds' => array(6, 7), @@ -263,7 +263,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsSecondWithinRange_returnsFalseIfNotContained() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'seconds' => array(6, 7), @@ -277,7 +277,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsFalseIfCompletelyEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -293,7 +293,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsFalseIfCompletelyEmpty_withSeconds() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -311,7 +311,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsFalseIfCompletelyFilled() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -327,7 +327,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsFalseIfCompletelyFilled_withSeconds() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -345,7 +345,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsTrueIfChoiceAndHourEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -363,7 +363,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsTrueIfChoiceAndMinuteEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', @@ -381,7 +381,7 @@ class TimeTypeTest extends LocalizedTestCase public function testIsPartiallyFilled_returnsTrueIfChoiceAndSecondsEmpty() { - $this->markTestSkipped('Needs to be reimplemented using validators'); + $this->markTestIncomplete('Needs to be reimplemented using validators'); $form = $this->factory->create('time', null, array( 'widget' => 'choice', diff --git a/tests/Symfony/Tests/Component/HttpKernel/KernelTest.php b/tests/Symfony/Tests/Component/HttpKernel/KernelTest.php index aa5c1aba60..7de5362cd0 100644 --- a/tests/Symfony/Tests/Component/HttpKernel/KernelTest.php +++ b/tests/Symfony/Tests/Component/HttpKernel/KernelTest.php @@ -210,7 +210,7 @@ class KernelTest extends \PHPUnit_Framework_TestCase public function testStripComments() { if (!function_exists('token_get_all')) { - $this->markTestSkipped(); + $this->markTestSkipped('The function token_get_all() is not available.'); return; } $source = <<isLowerThanIcuVersion('4.0')) { - $this->markTestSkipped( - 'Please upgrade ICU version to 4+' - ); + $this->markTestSkipped('Please upgrade ICU version to 4+'); } }