diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #22662 Tweaked the tabs of the logger profiler panel (javiereguiluz)

Browse Source 
This PR was merged into the 3.3-dev branch.

Discussion
----------

Tweaked the tabs of the logger profiler panel

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Another tweak that was on my TODO list for the profiler. With the addition of the "Container compilation" tab, the current tab menu looks too wide:

![logs_before](https://cloud.githubusercontent.com/assets/73419/25783180/07ed745e-3358-11e7-97b2-246f08d7da32.png)

I propose to rename some tabs to make it narrower:

![logs_after](https://cloud.githubusercontent.com/assets/73419/25783188/14b89b00-3358-11e7-8d87-ff2161945711.png)

---

Besides, I propose to add some help notes about the type of logs included in each tab. Examples:

![logs_after_message_1](https://cloud.githubusercontent.com/assets/73419/25783191/26d50e04-3358-11e7-983c-2e50f891247e.png)

![logs_after_message_2](https://cloud.githubusercontent.com/assets/73419/25783192/289af780-3358-11e7-8bec-d6572a5ae761.png)

Commits
-------

c21782dcae Tweaked the tabs of the logger profiler panel
This commit is contained in:
Fabien Potencier 2017-05-07 18:29:08 -07:00
commit e7da63a51f
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/logger.html.twig
View File

@ -68,6 +68,7 @@
<div class="sf-tabs">
<div class="tab">
<h3 class="tab-title">Info. &amp; Errors <span class="badge status-{{ collector.counterrors ? 'error' : collector.countwarnings ? 'warning' }}">{{ collector.counterrors ?: info_and_error_logs|length }}</span></h3>
<p class="text-muted">Informational and error log messages generated during the execution of the application.</p>
<div class="tab-content">
{% if info_and_error_logs is empty %}
@ -84,6 +85,7 @@
{# 'deprecation_logs|length' is not used because deprecations are
now grouped and the group count doesn't match the message count #}
<h3 class="tab-title">Deprecations <span class="badge status-{{ collector.countdeprecations ? 'warning' }}">{{ collector.countdeprecations|default(0) }}</span></h3>
<p class="text-muted">Log messages generated by using features marked as deprecated.</p>
<div class="tab-content">
{% if deprecation_logs is empty %}
@ -98,6 +100,7 @@
<div class="tab">
<h3 class="tab-title">Debug <span class="badge">{{ debug_logs|length }}</span></h3>
<p class="text-muted">Unimportant log messages generated during the execution of the application.</p>
<div class="tab-content">
{% if debug_logs is empty %}
@ -111,7 +114,8 @@
</div>
<div class="tab">
<h3 class="tab-title">Silenced PHP Notices<span class="badge">{{ collector.countscreams|default(0) }}</span></h3>
<h3 class="tab-title">PHP Notices <span class="badge">{{ collector.countscreams|default(0) }}</span></h3>
<p class="text-muted">Log messages generated by PHP notices silenced with the @ operator.</p>
<div class="tab-content">
{% if silenced_logs is empty %}
@ -129,7 +133,8 @@
{% set compilerLogTotal = compilerLogTotal + logs|length %}
{% endfor %}
<div class="tab">
<h3 class="tab-title">Container Compilation<span class="badge">{{ compilerLogTotal }}</span></h3>
<h3 class="tab-title">Container <span class="badge">{{ compilerLogTotal }}</span></h3>
<p class="text-muted">Log messages generated during the compilation of the service container.</p>
<div class="tab-content">
{% if collector.compilerLogs is empty %}