From eb728c5e4c6756555c72948948c547ffdf9a30be Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 13 Mar 2015 18:49:40 +0100 Subject: [PATCH] [2.7] add @group legacy --- .travis.yml | 2 +- .../Tests/Extension/AssetExtensionTest.php | 3 +++ .../Descriptor/AbstractDescriptorTest.php | 5 ++++- .../LegacyFragmentRendererPassTest.php | 3 +++ .../LegacyTemplatingAssetHelperPassTest.php | 3 +++ .../DependencyInjection/ConfigurationTest.php | 1 + .../FrameworkExtensionTest.php | 12 ++++++++++++ ...ainerAwareHIncludeFragmentRendererTest.php | 3 +++ .../Tests/Templating/Helper/AssetsHelper.php | 6 ++++++ .../SecurityDataCollectorTest.php | 3 +++ .../DependencyInjection/TwigExtensionTest.php | 2 ++ .../ClassNotFoundFatalErrorHandlerTest.php | 1 - .../CheckDefinitionValidityPassTest.php | 1 + .../Tests/ContainerBuilderTest.php | 6 ++++++ .../Tests/DefinitionDecoratorTest.php | 1 + .../Tests/DefinitionTest.php | 1 + .../Tests/Dumper/GraphvizDumperTest.php | 3 +++ .../Tests/Dumper/PhpDumperTest.php | 3 +++ .../Tests/Dumper/XmlDumperTest.php | 3 +++ .../Tests/Dumper/YamlDumperTest.php | 3 +++ .../Tests/Loader/XmlFileLoaderTest.php | 3 +++ .../Tests/Loader/YamlFileLoaderTest.php | 3 +++ .../Tests/AbstractEventDispatcherTest.php | 6 ++++++ .../Component/Form/Tests/CompoundFormTest.php | 6 ++++++ .../Extension/Core/Type/FormTypeTest.php | 3 +++ .../Component/Form/Tests/SimpleFormTest.php | 3 +++ .../Tests/Session/Flash/FlashBagTest.php | 1 + .../FragmentRendererPassTest.php | 3 +++ .../Process/Tests/AbstractProcessTest.php | 1 + .../Tests/Generator/UrlGeneratorTest.php | 3 +++ .../Tests/Loader/XmlFileLoaderTest.php | 3 +++ .../Tests/Loader/YamlFileLoaderTest.php | 3 +++ .../Component/Routing/Tests/RouteTest.php | 6 ++++++ .../Core/Tests/LegacySecurityContextTest.php | 3 +++ .../Normalizer/GetSetMethodNormalizerTest.php | 9 +++++++++ .../Tests/Normalizer/ObjectNormalizerTest.php | 3 +++ .../Normalizer/PropertyNormalizerTest.php | 9 +++++++++ .../Tests/Helper/LegacyAssetsHelperTest.php | 3 +++ .../Helper/LegacyCoreAssetsHelperTest.php | 3 +++ .../Constraints/CallbackValidatorTest.php | 19 +++++++++++++++++++ .../Tests/Constraints/GroupSequenceTest.php | 13 +++++++++++++ .../Validator/Tests/LegacyValidatorTest.php | 3 +++ .../Tests/Mapping/MemberMetadataTest.php | 9 +++++++++ src/Symfony/Component/Yaml/Tests/YamlTest.php | 3 +++ 44 files changed, 183 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index ee358fc0e5..aa338bbb40 100644 --- a/.travis.yml +++ b/.travis.yml @@ -46,5 +46,5 @@ install: script: - if [ "$deps" = "no" ]; then echo "$components" | parallel --gnu --keep-order 'echo -e "\\nRunning {} tests"; phpunit --exclude-group tty,benchmark,intl-data {} || (echo -e "\\e[41mKO\\e[0m {}" && $(exit 1));'; fi; - if [ "$deps" = "no" ]; then echo -e "\\nRunning tests requiring tty"; phpunit --group tty || (echo -e "\\e[41mKO\\e[0m tty group" && $(exit 1)); fi; - - if [ "$deps" = "high" ]; then echo "$components" | parallel --gnu --keep-order -j25% 'echo -e "\\nRunning {} tests"; cd {}; composer --prefer-source update; phpunit --exclude-group tty,benchmark,intl-data || (echo -e "\\e[41mKO\\e[0m {}" && $(exit 1));'; fi; + - if [ "$deps" = "high" ]; then echo "$components" | parallel --gnu --keep-order -j25% 'echo -e "\\nRunning {} tests"; cd {}; composer --prefer-source update; phpunit --exclude-group tty,benchmark,intl-data,legacy || (echo -e "\\e[41mKO\\e[0m {}" && $(exit 1));'; fi; - if [ "$deps" = "low" ]; then echo "$components" | parallel --gnu --keep-order -j25% 'echo -e "\\nRunning {} tests"; cd {}; composer --prefer-source --prefer-lowest --prefer-stable update; phpunit --exclude-group tty,benchmark,intl-data || (echo -e "\\e[41mKO\\e[0m {}" && $(exit 1));'; fi; diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AssetExtensionTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/AssetExtensionTest.php index 4c67f4fd19..51432473d1 100644 --- a/src/Symfony/Bridge/Twig/Tests/Extension/AssetExtensionTest.php +++ b/src/Symfony/Bridge/Twig/Tests/Extension/AssetExtensionTest.php @@ -18,6 +18,9 @@ use Symfony\Component\Asset\VersionStrategy\StaticVersionStrategy; class AssetExtensionTest extends \PHPUnit_Framework_TestCase { + /** + * @group legacy + */ public function testLegacyGetAssetUrl() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTest.php index 6142ef946d..c21268c4ab 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTest.php @@ -66,7 +66,10 @@ abstract class AbstractDescriptorTest extends \PHPUnit_Framework_TestCase return $this->getContainerBuilderDescriptionTestData(ObjectsProvider::getContainerBuilders()); } - /** @dataProvider provideLegacySynchronizedServiceDefinitionTestData */ + /** + * @dataProvider provideLegacySynchronizedServiceDefinitionTestData + * @group legacy + */ public function testLegacyDescribeSynchronizedServiceDefinition(Definition $definition, $expectedDescription) { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyFragmentRendererPassTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyFragmentRendererPassTest.php index 096f2cd76f..a801b91f43 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyFragmentRendererPassTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyFragmentRendererPassTest.php @@ -15,6 +15,9 @@ use Symfony\Component\DependencyInjection\Reference; use Symfony\Component\HttpFoundation\Request; use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\FragmentRendererPass; +/** + * @group legacy + */ class LegacyFragmentRendererPassTest extends \PHPUnit_Framework_TestCase { protected function setUp() diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.php index 2b239f177b..f183c849ca 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.php @@ -16,6 +16,9 @@ use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\Definition; use Symfony\Component\DependencyInjection\Reference; +/** + * @group legacy + */ class LegacyTemplatingAssetHelperPassTest extends \PHPUnit_Framework_TestCase { protected function setUp() diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php index 1cef379eeb..97f07a8dcb 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php @@ -89,6 +89,7 @@ class ConfigurationTest extends \PHPUnit_Framework_TestCase /** * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException * @expectedExceptionMessage You cannot use assets settings under "framework.templating" and "assets" configurations in the same project. + * @group legacy */ public function testLegacyInvalidValueAssets() { diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php index d771ce7e3b..0939f2f5d5 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php @@ -203,6 +203,9 @@ abstract class FrameworkExtensionTest extends TestCase $this->assertEquals('global_hinclude_template', $container->getParameter('fragment.renderer.hinclude.global_template'), '->registerTemplatingConfiguration() registers the global hinclude.js template'); } + /** + * @group legacy + */ public function testLegacyTemplatingAssets() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -290,6 +293,9 @@ abstract class FrameworkExtensionTest extends TestCase $this->assertEquals(array(Validation::API_VERSION_2_5_BC), $calls[6][1]); } + /** + * @group legacy + */ public function testLegacyFullyConfiguredValidationService() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -452,6 +458,9 @@ abstract class FrameworkExtensionTest extends TestCase $this->assertFalse($container->getParameter('form.type_extension.csrf.enabled')); } + /** + * @group legacy + */ public function testLegacyFormCsrfFieldNameCanBeSetUnderCsrfSettings() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -462,6 +471,9 @@ abstract class FrameworkExtensionTest extends TestCase $this->assertEquals('_custom', $container->getParameter('form.type_extension.csrf.field_name')); } + /** + * @group legacy + */ public function testLegacyFormCsrfFieldNameUnderFormSettingsTakesPrecedence() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Fragment/LegacyContainerAwareHIncludeFragmentRendererTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Fragment/LegacyContainerAwareHIncludeFragmentRendererTest.php index 3ccdab8385..e6fa0c4cee 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/Fragment/LegacyContainerAwareHIncludeFragmentRendererTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Fragment/LegacyContainerAwareHIncludeFragmentRendererTest.php @@ -15,6 +15,9 @@ use Symfony\Bundle\FrameworkBundle\Tests\TestCase; use Symfony\Bundle\FrameworkBundle\Fragment\ContainerAwareHIncludeFragmentRenderer; use Symfony\Component\HttpFoundation\Request; +/** + * @group legacy + */ class LegacyContainerAwareHIncludeFragmentRendererTest extends TestCase { public function testRender() diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/AssetsHelper.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/AssetsHelper.php index 7ef641d756..c0a2e9c2b8 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/AssetsHelper.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Templating/Helper/AssetsHelper.php @@ -18,6 +18,9 @@ use Symfony\Component\Asset\VersionStrategy\StaticVersionStrategy; class AssetsHelperTest extends \PHPUnit_Framework_TestCase { + /** + * @group legacy + */ public function testLegacyGetUrl() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -29,6 +32,9 @@ class AssetsHelperTest extends \PHPUnit_Framework_TestCase $this->assertEquals('me.png?version=42', $helper->getUrl('me.png', null, '42')); } + /** + * @group legacy + */ public function testLegacyGetVersion() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php index bc16f11fbb..a588230455 100644 --- a/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php +++ b/src/Symfony/Bundle/SecurityBundle/Tests/DataCollector/SecurityDataCollectorTest.php @@ -40,6 +40,9 @@ class SecurityDataCollectorTest extends \PHPUnit_Framework_TestCase $this->assertEmpty($collector->getUser()); } + /** + * @group legacy + */ public function testLegacyCollectWhenAuthenticationTokenIsNull() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php b/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php index 8f4fa73924..7b0b89e926 100644 --- a/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php +++ b/src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/TwigExtensionTest.php @@ -25,6 +25,7 @@ class TwigExtensionTest extends TestCase { /** * @dataProvider getFormats + * @group legacy */ public function testLegacyFormResourcesConfigurationKey($format) { @@ -44,6 +45,7 @@ class TwigExtensionTest extends TestCase /** * @dataProvider getFormats + * @group legacy */ public function testLegacyMergeFormResourcesConfigurationKeyWithFormThemesConfigurationKey($format) { diff --git a/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php b/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php index f6c1112d29..0c7631fc97 100644 --- a/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php +++ b/src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php @@ -35,7 +35,6 @@ class ClassNotFoundFatalErrorHandlerTest extends \PHPUnit_Framework_TestCase } /** - * @group legacy * @dataProvider provideLegacyClassNotFoundData * @group legacy */ diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckDefinitionValidityPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckDefinitionValidityPassTest.php index de899a6dd5..09ae3c413a 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckDefinitionValidityPassTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckDefinitionValidityPassTest.php @@ -52,6 +52,7 @@ class CheckDefinitionValidityPassTest extends \PHPUnit_Framework_TestCase /** * @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException + * @group legacy */ public function testLegacyProcessDetectsBothFactorySyntaxesUsed() { diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php index ad6d3bdfc5..1cde805753 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php @@ -684,6 +684,9 @@ class ContainerBuilderTest extends \PHPUnit_Framework_TestCase $this->assertEquals($a, $container->get('a')); } + /** + * @group legacy + */ public function testLegacySetOnSynchronizedService() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -703,6 +706,9 @@ class ContainerBuilderTest extends \PHPUnit_Framework_TestCase $this->assertSame($baz, $container->get('bar')->getBaz()); } + /** + * @group legacy + */ public function testLegacySynchronizedServiceWithScopes() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/DefinitionDecoratorTest.php b/src/Symfony/Component/DependencyInjection/Tests/DefinitionDecoratorTest.php index 0a5e98a3c2..f9006540a5 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/DefinitionDecoratorTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/DefinitionDecoratorTest.php @@ -51,6 +51,7 @@ class DefinitionDecoratorTest extends \PHPUnit_Framework_TestCase /** * @dataProvider provideLegacyPropertyTests + * @group legacy */ public function testLegacySetProperty($property, $changeKey) { diff --git a/src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php b/src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php index 8588dd7e75..b6539f3b74 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/DefinitionTest.php @@ -166,6 +166,7 @@ class DefinitionTest extends \PHPUnit_Framework_TestCase /** * @covers Symfony\Component\DependencyInjection\Definition::setSynchronized * @covers Symfony\Component\DependencyInjection\Definition::isSynchronized + * @group legacy */ public function testLegacySetIsSynchronized() { diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/GraphvizDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/GraphvizDumperTest.php index 7c13ac6ca1..ba5e12cd50 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Dumper/GraphvizDumperTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Dumper/GraphvizDumperTest.php @@ -23,6 +23,9 @@ class GraphvizDumperTest extends \PHPUnit_Framework_TestCase self::$fixturesPath = __DIR__.'/../Fixtures/'; } + /** + * @group legacy + */ public function testLegacyDump() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php index 84f210bfb7..c1877965d5 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php @@ -124,6 +124,9 @@ class PhpDumperTest extends \PHPUnit_Framework_TestCase } } + /** + * @group legacy + */ public function testLegacySynchronizedServices() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/XmlDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/XmlDumperTest.php index 55e56635ff..b5098be1be 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Dumper/XmlDumperTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Dumper/XmlDumperTest.php @@ -47,6 +47,9 @@ class XmlDumperTest extends \PHPUnit_Framework_TestCase $this->assertXmlStringEqualsXmlFile(self::$fixturesPath.'/xml/services8.xml', $dumper->dump(), '->dump() dumps parameters'); } + /** + * @group legacy + */ public function testLegacyAddService() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php b/src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php index 1ec51fa758..c22c7eb40e 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Dumper/YamlDumperTest.php @@ -40,6 +40,9 @@ class YamlDumperTest extends \PHPUnit_Framework_TestCase $this->assertStringEqualsFile(self::$fixturesPath.'/yaml/services8.yml', $dumper->dump(), '->dump() dumps parameters'); } + /** + * @group legacy + */ public function testLegacyAddService() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php index 45b8d5442f..8e69f4112a 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Loader/XmlFileLoaderTest.php @@ -191,6 +191,9 @@ class XmlFileLoaderTest extends \PHPUnit_Framework_TestCase $this->assertEquals('BazClass', $inner->getClass(), '->load() uses the same configuration as for the anonymous ones'); } + /** + * @group legacy + */ public function testLegacyLoadServices() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php index d40886884b..4d40e7c9c3 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Loader/YamlFileLoaderTest.php @@ -120,6 +120,9 @@ class YamlFileLoaderTest extends \PHPUnit_Framework_TestCase $loader->load('services4_bad_import.yml'); } + /** + * @group legacy + */ public function testLegacyLoadServices() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/EventDispatcher/Tests/AbstractEventDispatcherTest.php b/src/Symfony/Component/EventDispatcher/Tests/AbstractEventDispatcherTest.php index d3278046fe..5ff5be84d1 100644 --- a/src/Symfony/Component/EventDispatcher/Tests/AbstractEventDispatcherTest.php +++ b/src/Symfony/Component/EventDispatcher/Tests/AbstractEventDispatcherTest.php @@ -121,6 +121,9 @@ abstract class AbstractEventDispatcherTest extends \PHPUnit_Framework_TestCase $this->assertSame($event, $return); } + /** + * @group legacy + */ public function testLegacyDispatch() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -247,6 +250,9 @@ abstract class AbstractEventDispatcherTest extends \PHPUnit_Framework_TestCase $this->assertFalse($this->dispatcher->hasListeners(self::preFoo)); } + /** + * @group legacy + */ public function testLegacyEventReceivesTheDispatcherInstance() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Form/Tests/CompoundFormTest.php b/src/Symfony/Component/Form/Tests/CompoundFormTest.php index aa7663d7bf..6daeb6044f 100644 --- a/src/Symfony/Component/Form/Tests/CompoundFormTest.php +++ b/src/Symfony/Component/Form/Tests/CompoundFormTest.php @@ -807,6 +807,9 @@ class CompoundFormTest extends AbstractFormTest $this->assertEquals(array('extra' => 'data'), $form->getExtraData()); } + /** + * @group legacy + */ public function testLegacyGetErrorsAsStringDeep() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -828,6 +831,9 @@ class CompoundFormTest extends AbstractFormTest ); } + /** + * @group legacy + */ public function testLegacyGetErrorsAsStringDeepWithIndentation() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php index c578ab20b5..4091b6c2d8 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Core/Type/FormTypeTest.php @@ -637,6 +637,9 @@ class FormTypeTest extends BaseTypeTest $this->assertSame('0', $view->vars['label']); } + /** + * @group legacy + */ public function testLegacyCanGetErrorsWhenButtonInForm() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Form/Tests/SimpleFormTest.php b/src/Symfony/Component/Form/Tests/SimpleFormTest.php index 016f58c524..0f8bc845fa 100644 --- a/src/Symfony/Component/Form/Tests/SimpleFormTest.php +++ b/src/Symfony/Component/Form/Tests/SimpleFormTest.php @@ -733,6 +733,9 @@ class SimpleFormTest extends AbstractFormTest $this->assertSame($view, $form->createView($parentView)); } + /** + * @group legacy + */ public function testLegacyGetErrorsAsString() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Flash/FlashBagTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Flash/FlashBagTest.php index 7814565c25..9b79fecda4 100644 --- a/src/Symfony/Component/HttpFoundation/Tests/Session/Flash/FlashBagTest.php +++ b/src/Symfony/Component/HttpFoundation/Tests/Session/Flash/FlashBagTest.php @@ -134,6 +134,7 @@ class FlashBagTest extends \PHPUnit_Framework_TestCase /** * @covers Symfony\Component\HttpFoundation\Session\Flash\FlashBag::getIterator + * @group legacy */ public function testLegacyGetIterator() { diff --git a/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/FragmentRendererPassTest.php b/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/FragmentRendererPassTest.php index f87bbc2c1c..a46a07cf1d 100644 --- a/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/FragmentRendererPassTest.php +++ b/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/FragmentRendererPassTest.php @@ -18,6 +18,9 @@ use Symfony\Component\HttpKernel\Fragment\FragmentRendererInterface; class FragmentRendererPassTest extends \PHPUnit_Framework_TestCase { + /** + * @group legacy + */ public function testLegacyFragmentRedererWithoutAlias() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php index db4d943690..8aa3765245 100644 --- a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php +++ b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php @@ -234,6 +234,7 @@ abstract class AbstractProcessTest extends \PHPUnit_Framework_TestCase /** * @dataProvider provideLegacyInputValues + * @group legacy */ public function testLegacyValidInput($expected, $value) { diff --git a/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php b/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php index abb9570623..0005e3a534 100644 --- a/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php +++ b/src/Symfony/Component/Routing/Tests/Generator/UrlGeneratorTest.php @@ -456,6 +456,9 @@ class UrlGeneratorTest extends \PHPUnit_Framework_TestCase $this->assertSame('//EN.FooBar.com/app.php/', $generator->generate('test', array('locale' => 'EN'), UrlGeneratorInterface::NETWORK_PATH)); } + /** + * @group legacy + */ public function testLegacyGenerateNetworkPath() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php index 1b552d6d66..37bbc0cd69 100644 --- a/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php +++ b/src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php @@ -45,6 +45,9 @@ class XmlFileLoaderTest extends \PHPUnit_Framework_TestCase $this->assertEquals('context.getMethod() == "GET"', $route->getCondition()); } + /** + * @group legacy + */ public function testLegacyRouteDefinitionLoading() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php index c3365e7ee5..ad4dac06c3 100644 --- a/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php +++ b/src/Symfony/Component/Routing/Tests/Loader/YamlFileLoaderTest.php @@ -79,6 +79,9 @@ class YamlFileLoaderTest extends \PHPUnit_Framework_TestCase $this->assertEquals('context.getMethod() == "GET"', $route->getCondition()); } + /** + * @group legacy + */ public function testLegacyRouteDefinitionLoading() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Routing/Tests/RouteTest.php b/src/Symfony/Component/Routing/Tests/RouteTest.php index ddd6f96757..11c0cd8dcf 100644 --- a/src/Symfony/Component/Routing/Tests/RouteTest.php +++ b/src/Symfony/Component/Routing/Tests/RouteTest.php @@ -164,6 +164,9 @@ class RouteTest extends \PHPUnit_Framework_TestCase $this->assertTrue($route->hasScheme('httpS')); } + /** + * @group legacy + */ public function testLegacySchemeRequirement() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -191,6 +194,9 @@ class RouteTest extends \PHPUnit_Framework_TestCase $this->assertEquals(array('GET', 'POST'), $route->getMethods(), '->setMethods() accepts an array of methods and uppercases them'); } + /** + * @group legacy + */ public function testLegacyMethodRequirement() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Security/Core/Tests/LegacySecurityContextTest.php b/src/Symfony/Component/Security/Core/Tests/LegacySecurityContextTest.php index 83abac1afc..f1f7861e98 100644 --- a/src/Symfony/Component/Security/Core/Tests/LegacySecurityContextTest.php +++ b/src/Symfony/Component/Security/Core/Tests/LegacySecurityContextTest.php @@ -15,6 +15,9 @@ use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage; use Symfony\Component\Security\Core\Authorization\AuthorizationChecker; use Symfony\Component\Security\Core\SecurityContext; +/** + * @group legacy + */ class LegacySecurityContextTest extends \PHPUnit_Framework_TestCase { private $tokenStorage; diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php index 82854fa0a7..83e8be37fe 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php @@ -99,6 +99,9 @@ class GetSetMethodNormalizerTest extends \PHPUnit_Framework_TestCase $this->assertEquals('bar', $obj->getBar()); } + /** + * @group legacy + */ public function testLegacyDenormalizeOnCamelCaseFormat() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -117,6 +120,9 @@ class GetSetMethodNormalizerTest extends \PHPUnit_Framework_TestCase $this->assertEquals(new GetSetDummy(), $this->normalizer->denormalize(null, __NAMESPACE__.'\GetSetDummy')); } + /** + * @group legacy + */ public function testLegacyCamelizedAttributesNormalize() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -140,6 +146,9 @@ class GetSetMethodNormalizerTest extends \PHPUnit_Framework_TestCase )); } + /** + * @group legacy + */ public function testLegacyCamelizedAttributesDenormalize() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php index e90209f357..3efa05dfc5 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php @@ -96,6 +96,9 @@ class ObjectNormalizerTest extends \PHPUnit_Framework_TestCase $this->assertEquals('bar', $obj->bar); } + /** + * @group legacy + */ public function testLegacyDenormalizeOnCamelCaseFormat() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php index 95e469f147..2c906eefe7 100644 --- a/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php +++ b/src/Symfony/Component/Serializer/Tests/Normalizer/PropertyNormalizerTest.php @@ -62,6 +62,9 @@ class PropertyNormalizerTest extends \PHPUnit_Framework_TestCase $this->assertEquals('bar', $obj->getBar()); } + /** + * @group legacy + */ public function testLegacyDenormalizeOnCamelCaseFormat() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -74,6 +77,9 @@ class PropertyNormalizerTest extends \PHPUnit_Framework_TestCase $this->assertEquals('value', $obj->getCamelCase()); } + /** + * @group legacy + */ public function testLegacyCamelizedAttributesNormalize() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -97,6 +103,9 @@ class PropertyNormalizerTest extends \PHPUnit_Framework_TestCase )); } + /** + * @group legacy + */ public function testLegacyCamelizedAttributesDenormalize() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Templating/Tests/Helper/LegacyAssetsHelperTest.php b/src/Symfony/Component/Templating/Tests/Helper/LegacyAssetsHelperTest.php index a4ca8bc8ca..c723b91e6f 100644 --- a/src/Symfony/Component/Templating/Tests/Helper/LegacyAssetsHelperTest.php +++ b/src/Symfony/Component/Templating/Tests/Helper/LegacyAssetsHelperTest.php @@ -13,6 +13,9 @@ namespace Symfony\Component\Templating\Tests\Helper; use Symfony\Component\Templating\Helper\AssetsHelper; +/** + * @group legacy + */ class LegacyAssetsHelperTest extends \PHPUnit_Framework_TestCase { protected function setUp() diff --git a/src/Symfony/Component/Templating/Tests/Helper/LegacyCoreAssetsHelperTest.php b/src/Symfony/Component/Templating/Tests/Helper/LegacyCoreAssetsHelperTest.php index 65695ee6eb..1e5846804b 100644 --- a/src/Symfony/Component/Templating/Tests/Helper/LegacyCoreAssetsHelperTest.php +++ b/src/Symfony/Component/Templating/Tests/Helper/LegacyCoreAssetsHelperTest.php @@ -13,6 +13,9 @@ namespace Symfony\Component\Templating\Tests\Helper; use Symfony\Component\Templating\Helper\CoreAssetsHelper; +/** + * @group legacy + */ class LegacyCoreAssetsHelperTest extends \PHPUnit_Framework_TestCase { protected $package; diff --git a/src/Symfony/Component/Validator/Tests/Constraints/CallbackValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/CallbackValidatorTest.php index 42ee43bc3d..b53f6c6995 100644 --- a/src/Symfony/Component/Validator/Tests/Constraints/CallbackValidatorTest.php +++ b/src/Symfony/Component/Validator/Tests/Constraints/CallbackValidatorTest.php @@ -186,6 +186,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacySingleMethodBc() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -201,6 +204,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacySingleMethodBcExplicitName() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -216,6 +222,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacyMultipleMethodsBc() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -233,6 +242,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacyMultipleMethodsBcExplicitName() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -252,6 +264,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacySingleStaticMethodBc() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -269,6 +284,9 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest } // BC with Symfony < 2.4 + /** + * @group legacy + */ public function testLegacySingleStaticMethodBcExplicitName() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -307,6 +325,7 @@ class CallbackValidatorTest extends AbstractConstraintValidatorTest /** * @expectedException \Symfony\Component\Validator\Exception\ConstraintDefinitionException + * @group legacy */ public function testLegacyExpectEitherCallbackOrMethods() { diff --git a/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceTest.php b/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceTest.php index 93d3134236..30f0245372 100644 --- a/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceTest.php +++ b/src/Symfony/Component/Validator/Tests/Constraints/GroupSequenceTest.php @@ -32,6 +32,9 @@ class GroupSequenceTest extends \PHPUnit_Framework_TestCase $this->assertSame(array('Group 1', 'Group 2'), $sequence->groups); } + /** + * @group legacy + */ public function testLegacyIterate() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -41,6 +44,9 @@ class GroupSequenceTest extends \PHPUnit_Framework_TestCase $this->assertSame(array('Group 1', 'Group 2'), iterator_to_array($sequence)); } + /** + * @group legacy + */ public function testLegacyCount() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -50,6 +56,9 @@ class GroupSequenceTest extends \PHPUnit_Framework_TestCase $this->assertCount(2, $sequence); } + /** + * @group legacy + */ public function testLegacyArrayAccess() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -72,6 +81,7 @@ class GroupSequenceTest extends \PHPUnit_Framework_TestCase /** * @expectedException \Symfony\Component\Validator\Exception\OutOfBoundsException + * @group legacy */ public function testLegacyGetExpectsExistingKey() { @@ -82,6 +92,9 @@ class GroupSequenceTest extends \PHPUnit_Framework_TestCase $sequence[2]; } + /** + * @group legacy + */ public function testLegacyUnsetIgnoresNonExistingKeys() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); diff --git a/src/Symfony/Component/Validator/Tests/LegacyValidatorTest.php b/src/Symfony/Component/Validator/Tests/LegacyValidatorTest.php index d9b09da232..a38f1abb9b 100644 --- a/src/Symfony/Component/Validator/Tests/LegacyValidatorTest.php +++ b/src/Symfony/Component/Validator/Tests/LegacyValidatorTest.php @@ -19,6 +19,9 @@ use Symfony\Component\Validator\Tests\Fixtures\Entity; use Symfony\Component\Validator\Tests\Validator\AbstractLegacyApiTest; use Symfony\Component\Validator\Validator as LegacyValidator; +/** + * @group legacy + */ class LegacyValidatorTest extends AbstractLegacyApiTest { protected function createValidator(MetadataFactoryInterface $metadataFactory, array $objectInitializers = array()) diff --git a/src/Symfony/Component/Validator/Tests/Mapping/MemberMetadataTest.php b/src/Symfony/Component/Validator/Tests/Mapping/MemberMetadataTest.php index c69cfbc9aa..a4473bc68a 100644 --- a/src/Symfony/Component/Validator/Tests/Mapping/MemberMetadataTest.php +++ b/src/Symfony/Component/Validator/Tests/Mapping/MemberMetadataTest.php @@ -35,6 +35,9 @@ class MemberMetadataTest extends \PHPUnit_Framework_TestCase $this->metadata = null; } + /** + * @group legacy + */ public function testLegacyAddValidSetsMemberToCascaded() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -46,6 +49,9 @@ class MemberMetadataTest extends \PHPUnit_Framework_TestCase $this->assertTrue($this->metadata->isCascaded()); } + /** + * @group legacy + */ public function testLegacyAddOtherConstraintDoesNotSetMemberToCascaded() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED); @@ -83,6 +89,9 @@ class MemberMetadataTest extends \PHPUnit_Framework_TestCase $this->assertEquals($this->metadata, $metadata); } + /** + * @group legacy + */ public function testLegacySerializeCollectionCascadedDeeply() { $this->metadata->addConstraint(new Valid(array('traverse' => true))); diff --git a/src/Symfony/Component/Yaml/Tests/YamlTest.php b/src/Symfony/Component/Yaml/Tests/YamlTest.php index a701e48c79..a7261562d5 100644 --- a/src/Symfony/Component/Yaml/Tests/YamlTest.php +++ b/src/Symfony/Component/Yaml/Tests/YamlTest.php @@ -23,6 +23,9 @@ class YamlTest extends \PHPUnit_Framework_TestCase $this->assertEquals($data, $parsed); } + /** + * @group legacy + */ public function testLegacyParseFromFile() { $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);