diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #34036 [Lock] Set ReturnType of LockFactory to LockInterface (alexander-schranz)

Browse Source 
This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Set ReturnType of LockFactory to LockInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #...
| License       | MIT
| Doc PR        |

LockFactory I think should return a LockInterface and not the Lock class.

/cc @chalasr

Commits
-------

ff1fa57ef2 Set ReturnType of LockFactory to LockInterface
This commit is contained in:
Nicolas Grekas 2019-10-22 08:44:12 +02:00
commit ebca10e252
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Lock/LockFactory.php
View File

@ -26,7 +26,7 @@ class LockFactory extends Factory
* @param float|null $ttl Maximum expected lock duration in seconds
* @param bool $autoRelease Whether to automatically release the lock or not when the lock instance is destroyed
*/
public function createLock($resource, $ttl = 300.0, $autoRelease = true): Lock
public function createLock($resource, $ttl = 300.0, $autoRelease = true): LockInterface
{
return parent::createLock($resource, $ttl, $autoRelease);
}