diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33193 [Translation] Bump dependencies and apply upstream parameter types (derrabus)

Browse Source 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Translation] Bump dependencies and apply upstream parameter types

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32179
| License       | MIT
| Doc PR        | N/A

This PR bumps some dependencies of the Translation component in order to apply parameter type declarations.

Commits
-------

0fa56a811d [Translation] Bump dependencies and apply upstream parameter types.
This commit is contained in:
Nicolas Grekas 2019-08-16 07:54:12 +02:00
commit ec0b0ad3c1
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Translation/DataCollectorTranslator.php
View File

@ -82,7 +82,7 @@ class DataCollectorTranslator implements TranslatorInterface, TranslatorBagInter
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
public function warmUp($cacheDir) public function warmUp(string $cacheDir)
{ {
if ($this->translator instanceof WarmableInterface) { if ($this->translator instanceof WarmableInterface) {
$this->translator->warmUp($cacheDir); $this->translator->warmUp($cacheDir);

2
src/Symfony/Component/Translation/DependencyInjection/TranslatorPathsPass.php
View File

@ -79,7 +79,7 @@ class TranslatorPathsPass extends AbstractRecursivePass
} }
} }
protected function processValue($value, $isRoot = false) protected function processValue($value, bool $isRoot = false)
{ {
if ($value instanceof Reference) { if ($value instanceof Reference) {
if ((string) $value === $this->translatorServiceId) { if ((string) $value === $this->translatorServiceId) {

7
src/Symfony/Component/Translation/composer.json
View File

@ -23,8 +23,8 @@
"require-dev": { "require-dev": {
"symfony/config": "^4.4|^5.0", "symfony/config": "^4.4|^5.0",
"symfony/console": "^4.4|^5.0", "symfony/console": "^4.4|^5.0",
"symfony/dependency-injection": "^4.4|^5.0", "symfony/dependency-injection": "^5.0",
"symfony/http-kernel": "^4.4|^5.0", "symfony/http-kernel": "^5.0",
"symfony/intl": "^4.4|^5.0", "symfony/intl": "^4.4|^5.0",
"symfony/service-contracts": "^1.1.2", "symfony/service-contracts": "^1.1.2",
"symfony/var-dumper": "^4.4|^5.0", "symfony/var-dumper": "^4.4|^5.0",
@ -34,7 +34,8 @@
}, },
"conflict": { "conflict": {
"symfony/config": "<4.4", "symfony/config": "<4.4",
"symfony/dependency-injection": "<4.4", "symfony/dependency-injection": "<5.0",
"symfony/http-kernel": "<5.0",
"symfony/twig-bundle": "<5.0", "symfony/twig-bundle": "<5.0",
"symfony/yaml": "<4.4" "symfony/yaml": "<4.4"
}, },