diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #23028 add some \ on PHP_VERSION_ID for 2.8 (vincentaubert)

Browse Source 
This PR was merged into the 2.8 branch.

Discussion
----------

add some \ on PHP_VERSION_ID for 2.8

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22650
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Commits
-------

7f4824c add some \ on PHP_VERSION_ID for 2.8
This commit is contained in:
Nicolas Grekas 2017-06-02 11:17:34 +02:00
commit ec6b88257b
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Console/Tests/Command/CommandTest.php
View File

@ -386,7 +386,7 @@ class CommandTest extends TestCase
$tester = new CommandTester($command);
$tester->execute(array());
if (PHP_VERSION_ID < 70000) {
if (\PHP_VERSION_ID < 70000) {
// Cannot bind static closures in PHP 5
$this->assertEquals('interact called'.PHP_EOL.'not bound'.PHP_EOL, $tester->getDisplay());
} else {

2
src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
View File

@ -698,7 +698,7 @@ class ContainerTest extends TestCase
{
$class = new \ReflectionClass('Symfony\Component\DependencyInjection\Container');
$clone = $class->getMethod('__clone');
if (PHP_VERSION_ID >= 50400) {
if (\PHP_VERSION_ID >= 50400) {
$this->assertFalse($class->isCloneable());
}
$this->assertTrue($clone->isPrivate());

2
src/Symfony/Component/DomCrawler/Crawler.php
View File

@ -1191,7 +1191,7 @@ class Crawler extends \SplObjectStorage
private function triggerDeprecation($methodName, $useTrace = false)
{
if ($useTrace || defined('HHVM_VERSION')) {
if (PHP_VERSION_ID >= 50400) {
if (\PHP_VERSION_ID >= 50400) {
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 3);
} else {
$trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);