diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #38073 [VarDumper] Fix caster for invalid SplFileInfo objects on php 8 (derrabus)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Fix caster for invalid SplFileInfo objects on php 8

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #36872
| License       | MIT
| Doc PR        | N/A

The behavior of uninitialized `SplFileInfo` classes has changed in php 8: https://3v4l.org/s4c4O

* `getPathname()` won't return `false` anymore.
* The error raised by most accessors is now recoverable. On php 7, it's fatal.

This PR adjusts the caster for those objects to the new behavior.

Commits
-------

ab45e2aaae [VarDumper] Fix caster for invalid SplFileInfo objects on php 8.
This commit is contained in:
Fabien Potencier 2020-09-06 08:25:39 +02:00
commit ee8fc9cb41
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Symfony/Component/VarDumper/Caster/SplCaster.php
View File

@ -92,10 +92,24 @@ class SplCaster
unset($a["\0SplFileInfo\0fileName"]);
unset($a["\0SplFileInfo\0pathName"]);
if (false === $c->getPathname()) {
$a[$prefix.'⚠'] = 'The parent constructor was not called: the object is in an invalid state';
if (\PHP_VERSION_ID < 80000) {
if (false === $c->getPathname()) {
$a[$prefix.'⚠'] = 'The parent constructor was not called: the object is in an invalid state';
return $a;
return $a;
}
} else {
try {
$c->isReadable();
} catch (\RuntimeException $e) {
if ('Object not initialized' !== $e->getMessage()) {
throw $e;
}
$a[$prefix.'⚠'] = 'The parent constructor was not called: the object is in an invalid state';
return $a;
}
}
foreach ($map as $key => $accessor) {