diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #17248 [Form] fixed DateTimeType tests using "date_widget"="choice". (Adrien LUCAS) 

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17248).

Discussion
----------

[Form] fixed DateTimeType tests using "date_widget"="choice".

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

As said in the [documentation](http://symfony.com/doc/current/reference/forms/types/datetime.html#years), the default years available in the ``DateType`` go from five year before to five year after the current year. So now that it's 2016 all around, the tests which use the ``"date_widget"="choice"`` without defining a ``"years"`` option and tries to submit a date in 2010 are failing because 2010 is not in the default choice list.

This PR fixes the issue by setting the ``"years"`` option to ``"2010"`` for each test that need it. It also remove unnecessary (and confusing) dummy data from some tests which were suffering the same issue but silently.

Edit : The PHP 5.6 build on travis seems to fetch and run some old version of the tests. So it still fail on this build but not on the others anymore.

Commits
-------

be20e89 Fix Form's DateTimeType tests.
This commit is contained in:
Tobias Schultze 2016-01-04 15:27:02 +01:00
parent e738227d63 be20e892c2
commit eeaa4dcd0c
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php
View File

@ -29,6 +29,7 @@ class DateTimeTypeTest extends TestCase
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
));
@ -57,6 +58,7 @@ class DateTimeTypeTest extends TestCase
'view_timezone' => 'UTC',
'input' => 'string',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
));
@ -82,6 +84,7 @@ class DateTimeTypeTest extends TestCase
'view_timezone' => 'UTC',
'input' => 'timestamp',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
));
@ -108,12 +111,13 @@ class DateTimeTypeTest extends TestCase
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
'with_minutes' => false,
));
$form->setData(new \DateTime('2010-06-02 03:04:05 UTC'));
$form->setData(new \DateTime());
$input = array(
'date' => array(
@ -137,12 +141,13 @@ class DateTimeTypeTest extends TestCase
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'datetime',
'with_seconds' => true,
));
$form->setData(new \DateTime('2010-06-02 03:04:05 UTC'));
$form->setData(new \DateTime());
$input = array(
'date' => array(
@ -168,6 +173,7 @@ class DateTimeTypeTest extends TestCase
'model_timezone' => 'America/New_York',
'view_timezone' => 'Pacific/Tahiti',
'date_widget' => 'choice',
'years' => array(2010),
'time_widget' => 'choice',
'input' => 'string',
'with_seconds' => true,

1
src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
View File

@ -180,6 +180,7 @@ class DateTypeTest extends TestCase
'model_timezone' => 'UTC',
'view_timezone' => 'UTC',
'widget' => 'choice',
'years' => array(2010),
));
$text = array(