From 09371ad6f11a21d77d799e5aff1a347b957fdbb4 Mon Sep 17 00:00:00 2001 From: Fabien Bourigault Date: Fri, 30 Nov 2018 13:06:13 +0100 Subject: [PATCH] undeprecate the single-colon notation for controllers --- src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php | 2 +- .../FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php b/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php index 0b77b553ff..bf62c7cbd4 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php +++ b/src/Symfony/Bundle/FrameworkBundle/Routing/DelegatingLoader.php @@ -95,7 +95,7 @@ class DelegatingLoader extends BaseDelegatingLoader if (1 === substr_count($controller, ':')) { $nonDeprecatedNotation = str_replace(':', '::', $controller); - @trigger_error(sprintf('Referencing controllers with a single colon is deprecated since Symfony 4.1, use "%s" instead.', $nonDeprecatedNotation), E_USER_DEPRECATED); + // TODO deprecate this in 5.1 } $route->setDefault('_controller', $controller); diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php index a0ad94b33e..70944fcac8 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php +++ b/src/Symfony/Bundle/FrameworkBundle/Tests/Routing/DelegatingLoaderTest.php @@ -25,7 +25,6 @@ class DelegatingLoaderTest extends TestCase /** * @group legacy * @expectedDeprecation Referencing controllers with foo:bar:baz is deprecated since Symfony 4.1, use "some_parsed::controller" instead. - * @expectedDeprecation Referencing controllers with a single colon is deprecated since Symfony 4.1, use "foo::baz" instead. */ public function testLoad() {