diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #38797 Fix transient tests on branch 3.4 (jderusse)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix transient tests on branch 3.4

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Fix transient tests on branch 3.4.

I'll keep this PR open few days to watch travis/GHA for transient tests

Commits
-------

987efdd620 Fix transient tests
This commit is contained in:
Nicolas Grekas 2020-10-27 10:55:27 +01:00
commit f04745a208
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/HttpKernel/Tests/HttpCache/ResponseCacheStrategyTest.php
View File

@ -216,7 +216,7 @@ class ResponseCacheStrategyTest extends TestCase
$cacheStrategy->add($embeddedResponse);
$cacheStrategy->update($masterResponse);
$this->assertSame('60', $masterResponse->headers->getCacheControlDirective('s-maxage'));
$this->assertEqualsWithDelta(60, (int) $masterResponse->headers->getCacheControlDirective('s-maxage'), 1);
}
public function testResponseIsExpirableButNotValidateableWhenMasterResponseCombinesExpirationAndValidation()