From f1a7b075a6098e891b91511e4584ad43e274a7c0 Mon Sep 17 00:00:00 2001
From: Nicolas Grekas <nicolas.grekas@gmail.com>
Date: Thu, 7 Dec 2017 18:06:18 +0100
Subject: [PATCH] [DI] Fix circular-aliases message

---
 .../Component/DependencyInjection/ContainerBuilder.php    | 8 ++++++--
 .../DependencyInjection/Tests/ContainerBuilderTest.php    | 5 +++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
index f58adfc7d0..e67d924f23 100644
--- a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
+++ b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -998,10 +998,14 @@ class ContainerBuilder extends Container implements TaggedContainerInterface
             $id = (string) $this->aliasDefinitions[$id];
 
             if (isset($seen[$id])) {
-                throw new ServiceCircularReferenceException($id, array_keys($seen));
+                $seen = array_values($seen);
+                $seen = array_slice($seen, array_search($id, $seen));
+                $seen[] = $id;
+
+                throw new ServiceCircularReferenceException($id, $seen);
             }
 
-            $seen[$id] = true;
+            $seen[$id] = $id;
         }
 
         return $this->getDefinition($id);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
index fd24d80d1b..f4583b1338 100644
--- a/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
+++ b/src/Symfony/Component/DependencyInjection/Tests/ContainerBuilderTest.php
@@ -1046,18 +1046,19 @@ class ContainerBuilderTest extends TestCase
 
     /**
      * @expectedException \Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException
-     * @expectedExceptionMessage Circular reference detected for service "app.test_class", path: "app.test_class -> App\TestClass".
+     * @expectedExceptionMessage Circular reference detected for service "app.test_class", path: "app.test_class -> App\TestClass -> app.test_class".
      */
     public function testThrowsCircularExceptionForCircularAliases()
     {
         $builder = new ContainerBuilder();
 
         $builder->setAliases(array(
+            'foo' => new Alias('app.test_class'),
             'app.test_class' => new Alias('App\\TestClass'),
             'App\\TestClass' => new Alias('app.test_class'),
         ));
 
-        $builder->findDefinition('App\\TestClass');
+        $builder->findDefinition('foo');
     }
 
     public function testInitializePropertiesBeforeMethodCalls()