diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor #33530 Remove Google references when not needed (fabpot) 

This PR was merged into the 3.4 branch.

Discussion
----------

Remove Google references when not needed

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

No need to promote Google.

Commits
-------

9665d7633d Remove Google references when not needed
This commit is contained in:
Fabien Potencier 2019-09-10 13:21:38 +02:00
parent 6f332ce0e0 9665d7633d
commit f436cc80f1
6 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap3LayoutTest.php
View File

@ -2396,7 +2396,7 @@ abstract class AbstractBootstrap3LayoutTest extends AbstractLayoutTest
public function testUrlWithDefaultProtocol()
{
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => 'http']);
$this->assertWidgetMatchesXpath($form->createView(), ['attr' => ['class' => 'my&class']],
@ -2404,7 +2404,7 @@ abstract class AbstractBootstrap3LayoutTest extends AbstractLayoutTest
[@type="text"]
[@name="name"]
[@class="my&class form-control"]
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
[@inputmode="url"]
'
);
@ -2412,7 +2412,7 @@ abstract class AbstractBootstrap3LayoutTest extends AbstractLayoutTest
public function testUrlWithoutDefaultProtocol()
{
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => null]);
$this->assertWidgetMatchesXpath($form->createView(), ['attr' => ['class' => 'my&class']],
@ -2420,7 +2420,7 @@ abstract class AbstractBootstrap3LayoutTest extends AbstractLayoutTest
[@type="url"]
[@name="name"]
[@class="my&class form-control"]
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
'
);
}

4
src/Symfony/Component/BrowserKit/Tests/CookieTest.php
View File

@ -44,10 +44,10 @@ class CookieTest extends TestCase
return [
['foo=bar; path=/'],
['foo=bar; path=/foo'],
['foo=bar; domain=google.com; path=/'],
['foo=bar; domain=example.com; path=/'],
['foo=bar; domain=example.com; path=/; secure', 'https://example.com/'],
['foo=bar; path=/; httponly'],
['foo=bar; domain=google.com; path=/foo; secure; httponly', 'https://google.com/'],
['foo=bar; domain=example.com; path=/foo; secure; httponly', 'https://example.com/'],
['foo=bar=baz; path=/'],
['foo=bar%3Dbaz; path=/'],
];

8
src/Symfony/Component/Form/Tests/AbstractLayoutTest.php
View File

@ -2189,14 +2189,14 @@ abstract class AbstractLayoutTest extends FormIntegrationTestCase
public function testUrlWithDefaultProtocol()
{
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => 'http']);
$this->assertWidgetMatchesXpath($form->createView(), [],
'/input
[@type="text"]
[@name="name"]
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
[@inputmode="url"]
'
);
@ -2204,14 +2204,14 @@ abstract class AbstractLayoutTest extends FormIntegrationTestCase
public function testUrlWithoutDefaultProtocol()
{
$url = 'http://www.google.com?foo1=bar1&foo2=bar2';
$url = 'http://www.example.com?foo1=bar1&foo2=bar2';
$form = $this->factory->createNamed('name', 'Symfony\Component\Form\Extension\Core\Type\UrlType', $url, ['default_protocol' => null]);
$this->assertWidgetMatchesXpath($form->createView(), [],
'/input
[@type="url"]
[@name="name"]
[@value="http://www.google.com?foo1=bar1&foo2=bar2"]
[@value="http://www.example.com?foo1=bar1&foo2=bar2"]
'
);
}

4
src/Symfony/Component/HttpKernel/Tests/ClientTest.php
View File

@ -39,8 +39,8 @@ class ClientTest extends TestCase
$this->assertEquals('Request: /', $client->getResponse()->getContent(), '->doRequest() uses the request handler to make the request');
$this->assertEquals('www.example.com', $client->getRequest()->getHost(), '->doRequest() uses the request handler to make the request');
$client->request('GET', 'http://www.example.com/?parameter=http://google.com');
$this->assertEquals('http://www.example.com/?parameter='.urlencode('http://google.com'), $client->getRequest()->getUri(), '->doRequest() uses the request handler to make the request');
$client->request('GET', 'http://www.example.com/?parameter=http://example.com');
$this->assertEquals('http://www.example.com/?parameter='.urlencode('http://example.com'), $client->getRequest()->getUri(), '->doRequest() uses the request handler to make the request');
}
public function testGetScript()

30
src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
View File

@ -67,11 +67,11 @@ class UrlValidatorTest extends ConstraintValidatorTestCase
{
return [
['http://a.pl'],
['http://www.google.com'],
['http://www.google.com.'],
['http://www.google.museum'],
['https://google.com/'],
['https://google.com:80/'],
['http://www.example.com'],
['http://www.example.com.'],
['http://www.example.museum'],
['https://example.com/'],
['https://example.com:80/'],
['http://www.example.coop/'],
['http://www.test-example.com/'],
['http://www.symfony.com/'],
@ -148,15 +148,15 @@ class UrlValidatorTest extends ConstraintValidatorTestCase
public function getInvalidUrls()
{
return [
['google.com'],
['://google.com'],
['http ://google.com'],
['http:/google.com'],
['http://goog_le.com'],
['http://google.com::aa'],
['http://google.com:aa'],
['ftp://google.fr'],
['faked://google.fr'],
['example.com'],
['://example.com'],
['http ://example.com'],
['http:/example.com'],
['http://examp_le.com'],
['http://example.com::aa'],
['http://example.com:aa'],
['ftp://example.fr'],
['faked://example.fr'],
['http://127.0.0.1:aa/'],
['ftp://[::1]/'],
['http://[::1'],
@ -189,7 +189,7 @@ class UrlValidatorTest extends ConstraintValidatorTestCase
public function getValidCustomUrls()
{
return [
['ftp://google.com'],
['ftp://example.com'],
['file://127.0.0.1'],
['git://[::1]/'],
];

6
src/Symfony/Component/VarDumper/Tests/Caster/SplCasterTest.php
View File

@ -50,12 +50,12 @@ SplFileInfo {
%A}
EOTXT
],
['https://google.com/about', <<<'EOTXT'
['https://example.com/about', <<<'EOTXT'
SplFileInfo {
%Apath: "https://google.com"
%Apath: "https://example.com"
filename: "about"
basename: "about"
pathname: "https://google.com/about"
pathname: "https://example.com/about"
extension: ""
realPath: false
%A}