From 592fb134561a48f7896bc0e360a6023814e52621 Mon Sep 17 00:00:00 2001 From: Vincent Langlet Date: Thu, 25 Mar 2021 14:36:04 +0100 Subject: [PATCH] Remove internal annotation --- UPGRADE-5.3.md | 5 +++ src/Symfony/Component/Mime/Header/Headers.php | 6 ---- .../Mime/Tests/Header/HeadersTest.php | 35 +++++++++++++++++++ 3 files changed, 40 insertions(+), 6 deletions(-) diff --git a/UPGRADE-5.3.md b/UPGRADE-5.3.md index 32615caf15..e6d2df5b4d 100644 --- a/UPGRADE-5.3.md +++ b/UPGRADE-5.3.md @@ -60,6 +60,11 @@ Messenger * Deprecated the `prefetch_count` parameter in the AMQP bridge, it has no effect and will be removed in Symfony 6.0 * Deprecated the use of TLS option for Redis Bridge, use `rediss://127.0.0.1` instead of `redis://127.0.0.1?tls=1` +Mime +---- + + * Remove the internal annotation from the `getHeaderBody()` and `getHeaderParameter()` methods of the `Headers` class. + Notifier -------- diff --git a/src/Symfony/Component/Mime/Header/Headers.php b/src/Symfony/Component/Mime/Header/Headers.php index b8d8da64f0..09d87dc570 100644 --- a/src/Symfony/Component/Mime/Header/Headers.php +++ b/src/Symfony/Component/Mime/Header/Headers.php @@ -254,9 +254,6 @@ final class Headers return $arr; } - /** - * @internal - */ public function getHeaderBody($name) { return $this->has($name) ? $this->get($name)->getBody() : null; @@ -274,9 +271,6 @@ final class Headers } } - /** - * @internal - */ public function getHeaderParameter(string $name, string $parameter): ?string { if (!$this->has($name)) { diff --git a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php index f465fb9e85..37e3192fbe 100644 --- a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php +++ b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php @@ -279,4 +279,39 @@ class HeadersTest extends TestCase "Foo: =?utf-8?Q?aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa?=\r\n =?utf-8?Q?aaaa?=", ], $headers->toArray()); } + + public function testHeaderBody() + { + $headers = new Headers(); + $this->assertNull($headers->getHeaderBody('Content-Type')); + $headers->setHeaderBody('Text', 'Content-Type', 'type'); + $this->assertSame('type', $headers->getHeaderBody('Content-Type')); + } + + public function testHeaderParameter() + { + $headers = new Headers(); + $this->assertNull($headers->getHeaderParameter('Content-Disposition', 'name')); + + $headers->addParameterizedHeader('Content-Disposition', 'name'); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + $this->assertSame('foo', $headers->getHeaderParameter('Content-Disposition', 'name')); + } + + public function testHeaderParameterNotDefined() + { + $headers = new Headers(); + + $this->expectException(\LogicException::class); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + } + + public function testSetHeaderParameterNotParameterized() + { + $headers = new Headers(); + $headers->addTextHeader('Content-Disposition', 'name'); + + $this->expectException(\LogicException::class); + $headers->setHeaderParameter('Content-Disposition', 'name', 'foo'); + } }