From b4364aa0143903498d938dc58508b0e44be74c01 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Wed, 8 May 2019 22:08:18 +0200 Subject: [PATCH] refactored code --- .../Console/Helper/QuestionHelper.php | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php index 757fed4746..2d910f4356 100644 --- a/src/Symfony/Component/Console/Helper/QuestionHelper.php +++ b/src/Symfony/Component/Console/Helper/QuestionHelper.php @@ -367,19 +367,17 @@ class QuestionHelper extends Helper private function mostRecentlyEnteredValue($entered) { - $tempEntered = $entered; - // Determine the most recent value that the user entered - if (false !== strpos($entered, ',')) { - $choices = explode(',', $entered); - $lastChoice = trim($choices[\count($choices) - 1]); - - if (\strlen($lastChoice) > 0) { - $tempEntered = $lastChoice; - } + if (false === strpos($entered, ',')) { + return $entered; } - return $tempEntered; + $choices = explode(',', $entered); + if (\strlen($lastChoice = trim($choices[\count($choices) - 1])) > 0) { + return $lastChoice; + } + + return $entered; } /**