diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feature #28387 [HttpKernel][Profiler] Add arg value resolver category in performances panel (ogizanagi)

Browse Source 
This PR was merged into the 4.2-dev branch.

Discussion
----------

[HttpKernel][Profiler] Add arg value resolver category in performances panel

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | part of #27262   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Extracted from https://github.com/symfony/symfony/pull/27321

<img width="1071" alt="screenshot 2018-05-20 a 12 23 55" src="https://user-images.githubusercontent.com/2211145/40278071-98c04924-5c2a-11e8-9770-d78ac62d2c16.PNG">

Commits
-------

b24e0543e0 [HttpKernel][Profiler] Add arg value resolver category in performances panel
This commit is contained in:
Fabien Potencier 2018-09-08 09:28:50 +02:00
commit f6b4dc94d1
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
View File

@ -9,6 +9,7 @@
'event_listener': '#00B8F5',
'template': '#66CC00',
'doctrine': '#FF6633',
'controller.argument_value_resolver': '#8c5de6',
} %}
{% endif %}

4
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/TraceableValueResolver.php
View File

@ -38,7 +38,7 @@ final class TraceableValueResolver implements ArgumentValueResolverInterface
public function supports(Request $request, ArgumentMetadata $argument): bool
{
$method = \get_class($this->inner).'::'.__FUNCTION__;
$this->stopwatch->start($method);
$this->stopwatch->start($method, 'controller.argument_value_resolver');
$return = $this->inner->supports($request, $argument);
@ -53,7 +53,7 @@ final class TraceableValueResolver implements ArgumentValueResolverInterface
public function resolve(Request $request, ArgumentMetadata $argument): iterable
{
$method = \get_class($this->inner).'::'.__FUNCTION__;
$this->stopwatch->start($method);
$this->stopwatch->start($method, 'controller.argument_value_resolver');
yield from $this->inner->resolve($request, $argument);