diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #34136 [Notifier] Set missing defaults (fabpot)

Browse Source 
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Notifier] Set missing defaults

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | n/a <!-- required for new features -->

When overriding the default Notification class, most of the time, we don't need to call the parent constructor. Having good defaults allows to skip it.

Commits
-------

8767ff8e7b [Notifier] Set missing defaults
This commit is contained in:
Fabien Potencier 2019-10-26 22:34:04 +02:00
commit f82c3db6fa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Symfony/Component/Notifier/Notification/Notification.php
View File

@ -38,8 +38,8 @@ class Notification
public const IMPORTANCE_MEDIUM = 'medium'; public const IMPORTANCE_MEDIUM = 'medium';
public const IMPORTANCE_LOW = 'low'; public const IMPORTANCE_LOW = 'low';
private $channels; private $channels = [];
private $subject; private $subject = '';
private $content = ''; private $content = '';
private $emoji = ''; private $emoji = '';
private $exception; private $exception;