Remove TemplateManager::getTemplates()

This commit is contained in:
Dany Maillard 2017-07-06 11:15:46 +02:00
parent b9d93c8a2a
commit f8be69da5f
4 changed files with 6 additions and 42 deletions

View File

@ -619,6 +619,11 @@ VarDumper
VarDumperTestTrait::assertDumpMatchesFormat($dump, $data, $filter = 0, $message = '');
```
WebProfilerBundle
-----------------
* Removed the `getTemplates()` method of the `TemplateManager` class in favor of the ``getNames()`` method.
Workflow
--------

View File

@ -5,6 +5,7 @@ CHANGELOG
-----
* removed the `WebProfilerExtension::dumpValue()` method
* removed the `getTemplates()` method of the `TemplateManager` class in favor of the ``getNames()`` method
3.1.0
-----

View File

@ -60,26 +60,6 @@ class TemplateManager
return $templates[$panel];
}
/**
* Gets the templates for a given profile.
*
* @param Profile $profile
*
* @return Template[]
*
* @deprecated not used anymore internally
*/
public function getTemplates(Profile $profile)
{
$templates = $this->getNames($profile);
foreach ($templates as $name => $template) {
$templates[$name] = $this->twig->loadTemplate($template);
}
return $templates;
}
/**
* Gets template names of templates that are present in the viewed profile.
*

View File

@ -79,28 +79,6 @@ class TemplateManagerTest extends TestCase
$this->assertEquals('FooBundle:Collector:foo.html.twig', $this->templateManager->getName($profile, 'foo'));
}
/**
* template should be loaded for 'foo' because other collectors are
* missing in profile or in profiler.
*/
public function testGetTemplates()
{
$profile = $this->mockProfile();
$profile->expects($this->any())
->method('hasCollector')
->will($this->returnCallback(array($this, 'profilerHasCallback')));
$this->profiler->expects($this->any())
->method('has')
->withAnyParameters()
->will($this->returnCallback(array($this, 'profileHasCollectorCallback')));
$result = $this->templateManager->getTemplates($profile);
$this->assertArrayHasKey('foo', $result);
$this->assertArrayNotHasKey('bar', $result);
$this->assertArrayNotHasKey('baz', $result);
}
public function profilerHasCallback($panel)
{
switch ($panel) {