[DI] Enhance service locator error message

2017-10-17 00:50:56 +02:00 · 2017-10-17 00:50:56 +02:00 · fdb0ea9fdd
commit fdb0ea9fdd
parent d32ecff202
1 changed files with 3 additions and 0 deletions
--- a/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php
+++ b/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php
@ -78,6 +78,9 @@ final class ServiceLocatorTagPass extends AbstractRecursivePass
    public static function register(ContainerBuilder $container, array $refMap)
    {
        foreach ($refMap as $id => $ref) {
+            if (!$ref instanceof Reference) {
+                throw new InvalidArgumentException(sprintf('Invalid service locator definition: only services can be referenced, "%s" found for key "%s". Inject parameter values using constructors instead.', is_object($ref) ? get_class($ref) : gettype($ref), $id));
+            }
            $refMap[$id] = new ServiceClosureArgument($ref);
        }
        ksort($refMap);