From 5fcc0b4d8d2ba8832c5da3c878f7ba7d9b27e8be Mon Sep 17 00:00:00 2001 From: Nikolay Labinskiy Date: Fri, 12 Oct 2018 11:15:19 +0300 Subject: [PATCH] Fixes 28816 Translation commands should not talk about the old app/ directory since 3.4 --- .../FrameworkBundle/Command/TranslationDebugCommand.php | 6 +++--- .../FrameworkBundle/Command/TranslationUpdateCommand.php | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php index 82ec353d52..6759b9c1b0 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php +++ b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php @@ -76,7 +76,7 @@ class TranslationDebugCommand extends ContainerAwareCommand $this ->setDefinition(array( new InputArgument('locale', InputArgument::REQUIRED, 'The locale'), - new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages, defaults to app/Resources folder'), + new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages'), new InputOption('domain', null, InputOption::VALUE_OPTIONAL, 'The messages domain'), new InputOption('only-missing', null, InputOption::VALUE_NONE, 'Displays only missing messages'), new InputOption('only-unused', null, InputOption::VALUE_NONE, 'Displays only unused messages'), @@ -86,7 +86,7 @@ class TranslationDebugCommand extends ContainerAwareCommand ->setHelp(<<<'EOF' The %command.name% command helps finding unused or missing translation messages and comparing them with the fallback ones by inspecting the -templates and translation files of a given bundle or the app folder. +templates and translation files of a given bundle or the default translations directory. You can display information about bundle translations in a specific locale: @@ -104,7 +104,7 @@ You can only display unused messages: php %command.full_name% --only-unused en AcmeDemoBundle -You can display information about app translations in a specific locale: +You can display information about application translations in a specific locale: php %command.full_name% en diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php index c7dff1cc74..48ac433f41 100644 --- a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php +++ b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php @@ -80,7 +80,7 @@ class TranslationUpdateCommand extends ContainerAwareCommand $this ->setDefinition(array( new InputArgument('locale', InputArgument::REQUIRED, 'The locale'), - new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages, defaults to app/Resources folder'), + new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages'), new InputOption('prefix', null, InputOption::VALUE_OPTIONAL, 'Override the default prefix', '__'), new InputOption('no-prefix', null, InputOption::VALUE_NONE, '[DEPRECATED] If set, no prefix is added to the translations'), new InputOption('output-format', null, InputOption::VALUE_OPTIONAL, 'Override the default output format', 'yml'), @@ -93,7 +93,7 @@ class TranslationUpdateCommand extends ContainerAwareCommand ->setDescription('Updates the translation file') ->setHelp(<<<'EOF' The %command.name% command extracts translation strings from templates -of a given bundle or the app folder. It can display them or merge the new ones into the translation files. +of a given bundle or the default translations directory. It can display them or merge the new ones into the translation files. When new translation strings are found it can automatically add a prefix to the translation message. @@ -102,7 +102,7 @@ Example running against a Bundle (AcmeBundle) php %command.full_name% --dump-messages en AcmeBundle php %command.full_name% --force --prefix="new_" fr AcmeBundle -Example running against app messages (app/Resources folder) +Example running against default messages directory php %command.full_name% --dump-messages en php %command.full_name% --force --prefix="new_" fr EOF @@ -169,7 +169,7 @@ EOF if ($this->defaultViewsPath) { $viewsPaths[] = $this->defaultViewsPath; } - $currentName = 'app folder'; + $currentName = 'default directory'; // Override with provided Bundle info if (null !== $input->getArgument('bundle')) {