diogo
/
symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

base64_encoding inside PhpSerializer to avoid null characters

This commit is contained in:
Ryan Weaver 2019-04-01 08:36:54 -04:00
parent 9bcea2e9f4
commit fe7ad812c7
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Messenger/Tests/Transport/Serialization/PhpSerializerTest.php
View File

@ -58,7 +58,7 @@ class PhpSerializerTest extends TestCase
$serializer = new PhpSerializer();
$serializer->decode([
'body' => 'O:13:"ReceivedSt0mp":0:{}',
'body' => base64_encode('O:13:"ReceivedSt0mp":0:{}'),
]);
}
}

10
src/Symfony/Component/Messenger/Transport/Serialization/PhpSerializer.php
View File

@ -30,7 +30,13 @@ class PhpSerializer implements SerializerInterface
throw new MessageDecodingFailedException('Encoded envelope should have at least a "body".');
}
return $this->safelyUnserialize($encodedEnvelope['body']);
$serializeEnvelope = base64_decode($encodedEnvelope['body']);
if (false === $serializeEnvelope) {
throw new MessageDecodingFailedException('The "body" key could not be base64 decoded.');
}
return $this->safelyUnserialize($serializeEnvelope);
}
/**
@ -39,7 +45,7 @@ class PhpSerializer implements SerializerInterface
public function encode(Envelope $envelope): array
{
return [
'body' => serialize($envelope),
'body' => base64_encode(serialize($envelope)),
];
}