diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bug #34832 [3.4][Validator] Allow underscore character "_" in URL username and password (romainneutron)

Browse Source 
This PR was merged into the 3.4 branch.

Discussion
----------

[3.4][Validator] Allow underscore character "_" in URL username and password

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Hello!

It's been a long time since my last push on Symfony :)
Here's a bug fix. I think URL usernames and password may contain an underscore. Let me know!

Commits
-------

869518bc7e [Validator] Allow underscore character "_" in URL username and password
This commit is contained in:
Fabien Potencier 2019-12-05 17:05:19 +01:00
commit ffcb691698
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Symfony/Component/Validator/Constraints/UrlValidator.php
View File

@ -23,7 +23,7 @@ class UrlValidator extends ConstraintValidator
{ {
const PATTERN = '~^ const PATTERN = '~^
(%s):// # protocol (%s):// # protocol
(([\.\pL\pN-]+:)?([\.\pL\pN-]+)@)? # basic auth (([\_\.\pL\pN-]+:)?([\_\.\pL\pN-]+)@)? # basic auth
( (
([\pL\pN\pS\-\_\.])+(\.?([\pL\pN]|xn\-\-[\pL\pN-]+)+\.?) # a domain name ([\pL\pN\pS\-\_\.])+(\.?([\pL\pN]|xn\-\-[\pL\pN-]+)+\.?) # a domain name
| # or | # or

2
src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
View File

@ -117,9 +117,11 @@ class UrlValidatorTest extends ConstraintValidatorTestCase
['http://☎.com/'], ['http://☎.com/'],
['http://username:password@symfony.com'], ['http://username:password@symfony.com'],
['http://user.name:password@symfony.com'], ['http://user.name:password@symfony.com'],
['http://user_name:pass_word@symfony.com'],
['http://username:pass.word@symfony.com'], ['http://username:pass.word@symfony.com'],
['http://user.name:pass.word@symfony.com'], ['http://user.name:pass.word@symfony.com'],
['http://user-name@symfony.com'], ['http://user-name@symfony.com'],
['http://user_name@symfony.com'],
['http://symfony.com?'], ['http://symfony.com?'],
['http://symfony.com?query=1'], ['http://symfony.com?query=1'],
['http://symfony.com/?query=1'], ['http://symfony.com/?query=1'],