This PR was merged into the 5.3 branch.
Discussion
----------
[Security/Http] Fix cookie clearing on logout
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I think this was forgotten or a merge issue when the component was refactored :
- Original PR : https://github.com/symfony/symfony/pull/36252
- PR that added this file : https://github.com/symfony/symfony/pull/36243#discussion_r399646893
Commits
-------
d1aa32a2a1 [Security/Http] Fix cookie clearing on logout
This PR was submitted for the 6.1 branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[Mime] Relaxing in-reply-to header validation
| Q | A
| ------------- | ---
| Branch? | 6.1
| Bug fix? | no
| New feature? | ?
| Deprecations? | no
| Tickets | Fix#37361
| License | MIT
| Doc PR | not necessary
@nicolas-grekas
1. Is it OK to just use `UnstructuredHeader`?
2. Some tests at `IdentificationHeaderTest` are irrelevant now (but still pass) - should I remove them? And create some new test cases in `UnstructuredHeaderTest`? Or rely on every aspect being tested with other headers there, and don't add anything?
Commits
-------
04ddc126f3 [Mime] Relaxing in-reply-to header validation
This PR was squashed before being merged into the 5.4 branch.
Discussion
----------
[WebProfilerBundle] fix Email HTML preview
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix https://github.com/symfony/symfony/issues/44696 Fix https://github.com/symfony/symfony/issues/44703
| License | MIT
## First issue:
When swapping the order of `base64` & `charset=utf-8` it works well
Friendly ping @lyrixx as PR author
## Second issue:
Friendly ping @Art4 as issue author
As the `Mime\Email` is:
```php
/**
* @return resource|string|null
*/
public function getHtmlBody()
{
return $this->html;
}
```
Commits
-------
fe1aee8851 [WebProfilerBundle] fix Email HTML preview
This PR was merged into the 5.3 branch.
Discussion
----------
[FrameworkBundle] Fix test to actually use data provider
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | n/a
| License | MIT
| Doc PR | n/a
#44682 didn't actually use the data provider.
Commits
-------
6cafac4e19 fix test to actually use data provider
* 5.4:
Don't rely on session service in tests
[Mime] Fix encoding filenames in multipart/form-data
Properly warn about deprecation of IS_AUTHENTICATED_ANONYMOUSLY
[Lock] Create tables in transaction only if supported by driver
[Validator] Improve French translation
[HttpFoundation] Take php session.cookie settings into account
[Translations] Add missing translations for Galician (gl)
[ErrorHandler] fix on patching return types on Windows
[DependencyInjection] fix linting callable classes
alias `cache.app.taggable` to `cache.app` if using `cache.adapter.redis_tag_aware`
restore the overriden locale on tearDown - avoid interfering with any configured value
[Serializer] Improve UidNormalizer denormalize error message
[DependencyInjection] Cast tag value to string
This PR was merged into the 5.4 branch.
Discussion
----------
[HttpKernel] Don't rely on session service in tests
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Follow-up to #44518
| License | MIT
| Doc PR | N/A
The test introduced by #44518 makes use of the deprecated session service mechanism. Instead, I've attached the session to the request. This allows us to merge the test up to 6.0 and beyond without breaking it.
Commits
-------
e963594e71 Don't rely on session service in tests
* 5.3:
[Mime] Fix encoding filenames in multipart/form-data
[Validator] Improve French translation
[Translations] Add missing translations for Galician (gl)
[DependencyInjection] fix linting callable classes
alias `cache.app.taggable` to `cache.app` if using `cache.adapter.redis_tag_aware`
restore the overriden locale on tearDown - avoid interfering with any configured value
[DependencyInjection] Cast tag value to string
* 4.4:
[Mime] Fix encoding filenames in multipart/form-data
[Validator] Improve French translation
[Translations] Add missing translations for Galician (gl)
[DependencyInjection] fix linting callable classes
restore the overriden locale on tearDown - avoid interfering with any configured value
[DependencyInjection] Cast tag value to string
This PR was merged into the 6.0 branch.
Discussion
----------
[Finder] Restore Finder:getIterator return type PHPDoc
| Q | A
| ------------- | ---
| Branch? | 6.0
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#44697
| License | MIT
As discussed in the related ticket we want this annotation back. Targeting `6.0` as it is present in `5.4`, was remove during merging `5.4` up to `6.0`.
Commits
-------
a0fa9b1f27 Restore Finder:getIterator return type PHPDoc
This PR was merged into the 6.0 branch.
Discussion
----------
Fix Psr16Cache not being compatible with non-Symfony cache pools
| Q | A
| ------------- | ---
| Branch? | 6.0
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#44736
| License | MIT
| Doc PR | n/a
Resolves#44736 by making the Closure nullable so that checks for `null` don't fail when the property is not initialized.
Commits
-------
70be07efec Fix Psr16Cache not being compatible with non-Symfony cache pools
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] Fix encoding filenames in multipart/form-data
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41249
| License | MIT
| Doc PR | -
File uploads that use forms have stick to browsers' behavior. This is captured in the WHATWG in their living standard:
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#multipart-form-data
curl did the same a few weeks ago:
https://github.com/curl/curl/pull/7805
Commits
-------
a58c342fff [Mime] Fix encoding filenames in multipart/form-data
This PR was merged into the 5.4 branch.
Discussion
----------
Properly warn about deprecation of IS_AUTHENTICATED_ANONYMOUSLY
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Right now i assumed that i just need to replace `IS_AUTHENTICATED_ANONYMOUSLY` with `IS_AUTHENTICATED`, which is in fact `PUBLIC_ACCESS` not mentioned at all.
Commits
-------
98947dc5a0 Properly warn about deprecation of IS_AUTHENTICATED_ANONYMOUSLY
Right now i assumed that i just need to replace `IS_AUTHENTICATED_ANONYMOUSLY` with `IS_AUTHENTICATED, which is in fact `PUBLIC_ACCESS` not mentioned at all.
This PR was merged into the 5.4 branch.
Discussion
----------
[Serializer] Improve UidNormalizer denormalize error message
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | -
| Tickets | -
| License | MIT
| Doc PR | -
The two catch blocks can be merged. Also we should use ULID when the type is an ULID, and UID when we don't know.
Commits
-------
b97bc531ec [Serializer] Improve UidNormalizer denormalize error message
This PR was squashed before being merged into the 5.4 branch.
Discussion
----------
[Lock] Create tables in transaction only if supported by driver
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Fixed `DoctrineDbalStore` to allow the creation of a lock table within a transaction only if it is supported by the driver.
Commits
-------
9395de94c8 [Lock] Create tables in transaction only if supported by driver
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Improve French translation
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
See https://github.com/symfony/symfony/pull/44720#discussion_r772185884
Commits
-------
292fcfe8f2 [Validator] Improve French translation
This PR was squashed before being merged into the 5.4 branch.
Discussion
----------
[HttpFoundation] Take php session.cookie settings into account
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| Tickets | Fix [#44500](https://github.com/symfony/symfony/issues/44500)
| License | MIT
Fixes issue on SessionListener, not taken session.cookie_* settings into account anymore.
Commits
-------
23bd7a7766 [HttpFoundation] Take php session.cookie settings into account
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Translations] Add missing translations for Galician (gl)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#43718
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix.
This will help reviewers and should be a good start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
- Never break backward compatibility (see https://symfony.com/bc).
-->
Commits
-------
3f5a8bd414 [Translations] Add missing translations for Galician (gl)
This PR was merged into the 5.4 branch.
Discussion
----------
[ErrorHandler] fix on patching return types on Windows
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#44366
| License | MIT
| Doc PR | -
And syncing tentative return types from php-src
Commits
-------
58e156912e [ErrorHandler] fix on patching return types on Windows
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Cast tag attribute value to string
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? |no
| Deprecations? |no
| Tickets |
| License | MIT
| Doc PR |
```
DOMElement::setAttribute(): Passing null to parameter #2 ($value) of type string is deprecated
```
This happens when a tag value is `null` on PHP 8.1.
Commits
-------
8fe5fce3cf [DependencyInjection] Cast tag value to string
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Restore default locale in ConstraintValidatorTestCase
| Q | A
| ------------- | ---
| Branch? | 6.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Previously this code was not resetting the locale after changing it to `en` - which affected other tests which relied on this value being the configured value (however it was configured).
This mirrors the pattern used for the timezone, storing it to be reset on tearDown.
I've based this on 6.1. If it's valid, I'm unsure if it's classed a bug, or needs UPGRADE notes?
Commits
-------
77267c0598 restore the overriden locale on tearDown - avoid interfering with any configured value
This PR was merged into the 5.3 branch.
Discussion
----------
[FrameworkBundle] alias `cache.app.taggable` to `cache.app` if using `cache.adapter.redis_tag_aware`
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | n/a
| License | MIT
| Doc PR | n/a
When using `cache.adapter.redis_tag_aware` for your `cache.app`, `cache.app.taggable` is unnecessarily decorated with `TagAwareAdapter`. This sets `cache.app.taggable` as an alias to `cache.app` in this case.
Alternative to #44673.
Commits
-------
4b54aa0d93 alias `cache.app.taggable` to `cache.app` if using `cache.adapter.redis_tag_aware`
* 5.4:
[5.4] cs fixes
[5.3] cs fixes
[Cache] Fix saving items with no expiration through ProxyAdapter
CS fixes
[HttpClient] Fix tracing requests made after calling withOptions()
[Cache] disable lock on CLI
Revert "feature #41989 [Cache] make `LockRegistry` use semaphores when possible (nicolas-grekas)"
[HttpKernel] fix how configuring log-level and status-code by exception works
[VarDumper] add more "transient-on-macos" groups
This PR was merged into the 5.4 branch.
Discussion
----------
[HttpKernel] fix how configuring log-level and status-code by exception works
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#44433
| License | MIT
| Doc PR | -
This PR replaces #44456, and essentially fixes the way configuring log-level/status-code by exception works: instead of hacking them in the listener, the original exception should be wrapped in an `HttpExceptionInterface`, so that the rest of the code can seamlessly know about the configuration.
Commits
-------
6617be449e [HttpKernel] fix how configuring log-level and status-code by exception works
Rokas Mikalkėnas
Fabien Potencier
Alexander M. Turek
ThomasLandauer
Antoine Makdessi
Kevin Bond
Maxime Hélias
Nicolas Grekas
Colin O'Dell
Kuba Werłos
Jérôme Tamarelle
Artem Lopata
Martins Sipenko
Thomas Calvet
Simon Chrzanowski
Juan González Montes
Robin Chalas
Julien Falque