Commit Graph

49381 Commits

Author SHA1 Message Date
Fabien Potencier
bb8e66bc5f bug #36975 [PropertyInfo] Make PhpDocExtractor compatible with phpDocumentor v5 (DerManoMann)
This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyInfo] Make PhpDocExtractor compatible with phpDocumentor v5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36049
| License       | MIT
| Doc PR        | N/A

Version 5 of phpDocumentor introduced some changes to the `getTagsByName()` method that break the `PhpDocExtractor`.

More specific, it now returns an instance of `InvalidTag` instead of `null` when parsing an invalid tag.

Commits
-------

b1f8e5a80a Make PhpDocExtractor compatible with phpDocumentor v5
2020-06-15 07:20:14 +02:00
Fabien Potencier
8bb0897a6d bug #37279 [Form] Fixed prototype block prefixes hierarchy of the CollectionType (yceruto)
This PR was merged into the 5.1 branch.

Discussion
----------

[Form] Fixed prototype block prefixes hierarchy of the CollectionType

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37024
| License       | MIT
| Doc PR        |

Following https://github.com/symfony/symfony/pull/37276

Commits
-------

65efc36e94 fixed prototype block prefixes hierarchy of the CollectionType
2020-06-15 07:12:47 +02:00
DerManoMann
b1f8e5a80a Make PhpDocExtractor compatible with phpDocumentor v5
Version 5 of phpDocumentor introduced some changes to the
`getTagsByName()` method that break the `PhpDocExtractor`.
More specific, it now returns an instance of `InvalidTag` instead of
`null` when parsing an invalid tag.
2020-06-15 09:00:35 +12:00
Yonel Ceruto
65efc36e94 fixed prototype block prefixes hierarchy of the CollectionType 2020-06-14 11:52:41 -04:00
Fabien Potencier
ccd9c1fc84 bug #37276 [Form] Fixed block prefixes hierarchy of the CollectionType (yceruto)
This PR was merged into the 5.1 branch.

Discussion
----------

[Form] Fixed block prefixes hierarchy of the CollectionType

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37024
| License       | MIT
| Doc PR        | -

/cc @HeahDude

Commits
-------

a8f2c60368 fixed block prefixes hierarchy of the CollectionType
2020-06-14 17:28:54 +02:00
Gabriel Ostrolucký
8fe7be4212 Reset question validator attempts only for actual stdin 2020-06-14 17:02:32 +02:00
Yonel Ceruto
a8f2c60368 fixed block prefixes hierarchy of the CollectionType 2020-06-14 09:34:09 -04:00
Nicolas Grekas
b746dd900c [DI] tighten detection of local dirs to prevent false positives 2020-06-14 14:27:25 +02:00
Nicolas Grekas
fcc0e2c143 [FrameworkBundle] preserve dots in query-string when redirecting 2020-06-13 17:55:52 +02:00
Jérémy Derussé
992205a759
Fix precendence in 4.4 2020-06-13 17:35:21 +02:00
Fabien Potencier
a89cc6bf79 minor #37267 [SecurityBundle] Run functional tests for the authenticator system (wouterj)
This PR was merged into the 5.1 branch.

Discussion
----------

[SecurityBundle] Run functional tests for the authenticator system

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

<s>Includes https://github.com/symfony/symfony/pull/37261 until it's merged.</s>

This runs all relevant functional tests in the security bundle for both the traditional and the authenticator system. This will hopefully avoid breaking more code in further releases.

deps=high builds will be green once this has been merged up into master.

---

During the functional tests, some inconsistencies were fixed. Three tests revealed larger inconsistencies that couldn't be fixed easily. These are not run for the new system as of now, we need to investigate further how to proceed with them. I'll create a separate issue/discussion for these:

* `Symfony\Bundle\SecurityBundle\Tests\Functional\FirewallEntryPointTest::testItUsesTheConfiguredEntryPointWhenUsingUnknownCredentials`
* `Symfony\Bundle\SecurityBundle\Tests\Functional\CsrfFormLoginTest::testFormLoginWithInvalidCsrfToken`
* `Symfony\Bundle\SecurityBundle\Tests\Functional\SecurityRoutingIntegrationTest::testSecurityConfigurationForExpression`

Commits
-------

49639caeaf [Security] Run functional tests also for the authenticator system
2020-06-13 17:21:48 +02:00
Wouter de Jong
49639caeaf [Security] Run functional tests also for the authenticator system 2020-06-13 17:06:42 +02:00
Fabien Potencier
080eef05b7 bug #37261 Fix register csrf protection listener (Ne-Lexa)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

Fix register csrf protection listener

| Q             | A
| ------------- | ---
| Branch?       | 5.1.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | np
| Tickets       | #37254
| License       | MIT

Fix TypeError. Expected instance `CsrfTokenManagerInterface`, but `SessionTokenStorage` was given.

```
Uncaught Error: Argument 1 passed to Symfony\Component\Security\Http\EventListener\CsrfProtectionListener::__construct() must implement interface Symfony\Component\Security\Csrf\CsrfTokenManagerInterface, instance of Symfony\Component\Security\Csrf\TokenStorage\SessionTokenStorage given

Uncaught PHP Exception TypeError: "Argument 1 passed to Symfony\Component\Security\Http\EventListener\CsrfProtectionListener::__construct() must implement interface Symfony\Component\Security\Csrf\CsrfTokenManagerInterface, instance of Symfony\Component\Security\Csrf\TokenStorage\SessionTokenStorage given
```

Commits
-------

485361e847 Fix register csrf protection listener
2020-06-13 17:05:39 +02:00
wapplay
485361e847 Fix register csrf protection listener 2020-06-13 17:05:31 +02:00
Fabien Potencier
86c79ce316 bumped Symfony version to 5.1.2 2020-06-12 14:20:44 +02:00
Fabien Potencier
c093c648ae
Merge pull request #37248 from fabpot/release-5.1.1
released v5.1.1
2020-06-12 13:26:14 +02:00
Fabien Potencier
6aafc48ddf updated VERSION for 5.1.1 2020-06-12 13:25:56 +02:00
Fabien Potencier
5ad89d13b6 updated CHANGELOG for 5.1.1 2020-06-12 13:25:49 +02:00
Fabien Potencier
e5354f4f1b bumped Symfony version to 5.0.11 2020-06-12 13:25:22 +02:00
Fabien Potencier
fbe1ee941e
Merge pull request #37247 from fabpot/release-5.0.10
released v5.0.10
2020-06-12 13:20:35 +02:00
Fabien Potencier
3b4cc39f18 updated VERSION for 5.0.10 2020-06-12 13:20:19 +02:00
Fabien Potencier
d371adb23b updated CHANGELOG for 5.0.10 2020-06-12 13:20:12 +02:00
Fabien Potencier
055dd28bb8 bumped Symfony version to 4.4.11 2020-06-12 13:19:16 +02:00
Fabien Potencier
7eef70427b
Merge pull request #37246 from fabpot/release-4.4.10
released v4.4.10
2020-06-12 13:15:53 +02:00
Fabien Potencier
e71a9ff228 updated VERSION for 4.4.10 2020-06-12 13:15:37 +02:00
Fabien Potencier
6199cf12b1 updated CHANGELOG for 4.4.10 2020-06-12 13:15:31 +02:00
Fabien Potencier
b30f4c1537 bumped Symfony version to 3.4.43 2020-06-12 13:14:22 +02:00
Fabien Potencier
79b0cc53df
Merge pull request #37244 from fabpot/release-3.4.42
released v3.4.42
2020-06-12 12:57:23 +02:00
Fabien Potencier
4d48338b6c updated VERSION for 3.4.42 2020-06-12 12:57:07 +02:00
Fabien Potencier
4a02bde238 update CONTRIBUTORS for 3.4.42 2020-06-12 12:57:05 +02:00
Fabien Potencier
ab5ac9a02d updated CHANGELOG for 3.4.42 2020-06-12 12:56:53 +02:00
Nicolas Grekas
3afa4b2e72 Merge branch '5.0' into 5.1
* 5.0:
  cs
  fix merge
2020-06-12 10:39:51 +02:00
Nicolas Grekas
7b6ffda0b9 cs 2020-06-12 10:39:40 +02:00
Nicolas Grekas
d735b76302 fix merge 2020-06-12 10:38:59 +02:00
Nicolas Grekas
acc88829de Merge branch '5.0' into 5.1
* 5.0:
  fix merge
2020-06-12 10:26:18 +02:00
Nicolas Grekas
15747d3ebb Merge branch '4.4' into 5.0
* 4.4:
  fix merge
2020-06-12 10:26:05 +02:00
Nicolas Grekas
6304b6b11a fix merge 2020-06-12 10:25:05 +02:00
Nicolas Grekas
5b70cc8ac8 Merge branch '5.0' into 5.1
* 5.0:
  fix merge
2020-06-12 10:22:42 +02:00
Nicolas Grekas
8fa1cea06d fix merge 2020-06-12 10:22:28 +02:00
Nicolas Grekas
03bd1bf90a Merge branch '5.0' into 5.1
* 5.0:
  [DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables
  switch the context when validating nested forms
  remove unused param from validator service config
  Fix typo
  [HttpKernel] Fix regression where Store does not return response body correctly
  rework form validator tests
  Update AbstractController.php
2020-06-12 10:11:32 +02:00
Nicolas Grekas
6c4695f4ec Merge branch '4.4' into 5.0
* 4.4:
  [DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables
  switch the context when validating nested forms
  remove unused param from validator service config
  Fix typo
  [HttpKernel] Fix regression where Store does not return response body correctly
  rework form validator tests
  Update AbstractController.php
2020-06-12 10:11:14 +02:00
Nicolas Grekas
02df1c9b53 Merge branch '3.4' into 4.4
* 3.4:
  switch the context when validating nested forms
  Fix typo
  [HttpKernel] Fix regression where Store does not return response body correctly
  rework form validator tests
  Update AbstractController.php
2020-06-12 10:10:13 +02:00
Fabien Potencier
fd51aeb20b bug #37227 [DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up to https://github.com/symfony/symfony/pull/37193

Unresolved parameters pointing to environment variables can be added to definitions after ResolveParameterPlaceHoldersPass execution. It is the case in the initial reported bug (RegisterListenersPass is executed after ResolveParameterPlaceHoldersPass). In this case, the parameter value is an env placeholder, so we need to try to resolve it.

Commits
-------

dac3c8fae8 [DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables
2020-06-12 10:01:48 +02:00
Thomas Calvet
dac3c8fae8 [DependencyInjection][CheckTypeDeclarationsPass] Handle unresolved parameters pointing to environment variables 2020-06-12 09:37:04 +02:00
Fabien Potencier
1f83212541 bug #37103 [Form] switch the context when validating nested forms (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] switch the context when validating nested forms

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37072
| License       | MIT
| Doc PR        |

Commits
-------

38135de549 switch the context when validating nested forms
2020-06-12 09:33:15 +02:00
Christian Flothmann
38135de549 switch the context when validating nested forms 2020-06-12 09:11:17 +02:00
Fabien Potencier
f1989fe41c minor #37236 remove unused param from validator service config (Tobion)
This PR was merged into the 4.4 branch.

Discussion
----------

remove unused param from validator service config

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

d75ec21cdb remove unused param from validator service config
2020-06-12 08:06:18 +02:00
Tobias Schultze
d75ec21cdb remove unused param from validator service config 2020-06-12 02:09:24 +02:00
Tobias Schultze
bb80fbf931 Merge branch '5.0' into 5.1 2020-06-11 23:53:51 +02:00
Tobias Schultze
00bf63d9fd Merge branch '4.4' into 5.0 2020-06-11 23:53:02 +02:00