Fabien Potencier
048979993e
[HttpFoundation] added a check for the host header value
2012-12-07 10:14:56 +01:00
Keri Henare
6c59fbdb59
[HttpFoundation] Fixed #5611 - Request::splitHttpAcceptHeader incorrect result order.
...
* Makes items with equal q-values return in the original provided order.
* Fixes tests to reflect this behavior
2012-10-03 09:31:34 +13:00
sasezaki
7444cb9725
Support the new Microsoft URL Rewrite Module for IIS 7.0. @see http://framework.zend.com/issues/browse/ZF-4491 @see http://framework.zend.com/code/revision.php?repname=Zend+Framework&rev=24842
2012-09-28 21:25:17 +02:00
Fabien Potencier
03d22b74ec
fixed CS (mainly method signatures)
2012-07-09 14:43:50 +02:00
Fabien Potencier
ce9791246b
fixed phpdoc @param alignment
2012-05-15 18:56:32 +02:00
Hugo Hamon
6dddb6b850
[HttpFoundation] removed useless else clause in Request::getPort() method.
2012-04-21 13:27:44 +02:00
Kris Wallsmith
d67d419f3c
[HttpFoundation] added missing trustProxy condition
2012-01-13 11:05:57 -08:00
Tobias Schultze
17284937f6
made the assertions in the RequestTest more explicit and improved PHPDoc
2012-01-09 06:33:53 +01:00
Christophe Coevoet
9bc41d00d1
[HttpFoundation] Fixed #3053
2012-01-07 14:27:33 +01:00
Fabien Potencier
e3421a0b1d
[DoctrineBridge] fixed some CS
2011-12-13 10:22:12 +01:00
Fabien Potencier
286ce0ea40
merged branch pulzarraider/proxy_ip_fix (PR #2695 )
...
Commits
-------
11b6156
updated unittest
a931e21
get correct client IP from X-forwarded-for header
Discussion
----------
[HttpFoundation] Get correct client IP when using trusted proxy (Varnish)
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Note: This is reopened PR #2686 for 2.0 branch.
If using trusted proxy (Varnish, ...) the client IP must be identified from X-Forwarded-For header. The header has de-facto standard format:
X-Forwarded-For : client1, proxy1, proxy2,
where the value is a comma+space separated list of IP addresses, the left-most being the farthest downstream client, and each successive proxy that passed the request adding the IP address where it received the request from. See: http://en.wikipedia.org/wiki/X-Forwarded-For
Function getClientIp should return only one client IP, not a list of all nonimportant IPs as it's now. Similar example can be seen in Cake framework: http://api.cakephp.org/view_source/request-handler-component/#line-477
There are many ways how to chose the first IP from X-Forwarded-For header. Any other faster and more reliable way is welcome.
2011-11-23 11:22:06 +01:00
Andrej Hudec
a931e21284
get correct client IP from X-forwarded-for header
2011-11-22 22:01:07 +01:00
Fabien Potencier
60f8525ae5
merged branch lsmith77/forward_compat (PR #2526 )
...
Commits
-------
b6bf018
tweaked error handling for the forward compatibility
dd606b5
added note about the purpose of this class
c1426ba
added locale handling forward compatibility
10eed30
added MessageDataCollector forward compatibility
Discussion
----------
Forward compat
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2522
2011-11-22 19:39:27 +01:00
Lukas Kahwe Smith
b6bf0182e9
tweaked error handling for the forward compatibility
2011-11-01 09:40:05 +01:00
Lukas Kahwe Smith
c1426baee1
added locale handling forward compatibility
2011-10-31 16:15:30 +01:00
Lukas Kahwe Smith
d3f137b9c1
cosmetic tweak
2011-10-09 16:09:22 +02:00
Lukas Kahwe Smith
28778834c7
anything in front of ;q= is part of the mime type, anything after may be ignored
...
see http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.1
2011-10-09 12:58:45 +02:00
Fabien Potencier
a74ae9d325
[HttpFoundation] made X_REWRITE_URL only available on Windows platforms
2011-10-07 08:20:12 +02:00
stealth35
b12ce94c38
[HttpFoundation] fix #2142 PathInfo parsing/checking
...
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2142
2011-09-28 13:18:44 +02:00
Drak
d375b6d00e
Corrected docblock, quoted types were incorrect.
2011-09-27 13:34:25 +05:45
Fabien Potencier
17f115104d
merged branch chx/2.0 (PR #2141 )
...
Commits
-------
24b80ae
Removed a leftover use.
Discussion
----------
Removed a leftover use.
lsmith told me to put in this request instead.
2011-09-09 14:50:48 +02:00
Karoly Negyesi
24b80aedf3
Removed a leftover use.
2011-09-09 02:13:17 -07:00
Jordan Alliot
ae5230344c
[HttpFoundation] Fixed duplicate of request
...
closes #2133
2011-09-08 12:28:21 +01:00
Johannes Schmitt
b6ee1a67a7
fixes a bug when overriding method via the X-HTTP-METHOD-OVERRIDE header
2011-08-18 12:18:12 +02:00
Fabien Potencier
8700cd6154
fixed CS
2011-07-27 08:27:46 +02:00
Fabien Potencier
7dcbcbe69d
[HttpFoundation] tagged public @api
2011-07-20 10:06:02 +02:00
Martin Eckhardt
95011ce4b7
[HttpFoundation] Fixed creation of requests without a path.
...
Providing urls with no path led to php warning that the index 'path' is
not set. This patch initializes 'path' if no path is set.
2011-07-19 10:54:21 +02:00
Fabien Potencier
932cd10477
made HTTP headers coming from proxies non-trusted by default
2011-07-05 19:49:36 +02:00
Daniel Londero
7dd8dd7699
Fixed @Return comment for getAcceptableContentTypes() method.
2011-07-04 14:34:11 -07:00
Fabien Potencier
ea0f327122
merged branch Seldaek/req_time (PR #1432 )
...
Commits
-------
e80ce57
[HttpFoundation] Add REQUEST_TIME by default
Discussion
----------
[HttpFoundation] Add REQUEST_TIME by default
Without this the getting the REQUEST_TIME from the Request in tests is breaking.
2011-06-25 13:26:06 +02:00
Jordi Boggiano
e80ce57935
[HttpFoundation] Add REQUEST_TIME by default
2011-06-25 12:44:24 +02:00
Fabien Potencier
f57e1d3e10
fixed CS
2011-06-23 14:07:53 +02:00
Fabien Potencier
5b142d581b
fixed CS
2011-06-15 11:35:32 +02:00
Sasa Stamenkovic
cbd1dfd3bd
Minor doc fixes in Request.
2011-06-14 21:44:45 +02:00
Fabien Potencier
62e4342a86
fixed CS
2011-06-08 12:12:55 +02:00
Fabien Potencier
0af4743583
[HttpFoundation] fixed Request::getFormat() when the mime-type has some optional parameter ( closes #1235 )
2011-06-08 11:12:57 +02:00
Fabien Potencier
f16e206cd7
[HttpFoundation] added missing CONTENT_TYPE and CONTENT_LENGTH to the Request headers (these two headers are not prefixes with HTTP_ -- as per the CGI/1.1 spec, closes #1234 )
2011-06-08 11:04:41 +02:00
Fabien Potencier
9118fcee14
[HttpFoundation] fixed CS
2011-06-08 10:35:47 +02:00
Fabien Potencier
c561f4f0c0
[Routing] changed HTTP method to always be uppercased (to be consistent with HttpFoundation/Request)
2011-06-04 19:06:39 +02:00
Fabien Potencier
c19d6c07d2
[HttpFoundation] simplified code
2011-05-26 15:02:40 +02:00
Joshua Nye
3832a7a33d
Added missing space.
2011-05-25 17:22:32 -04:00
Joshua Nye
f019541716
Fixed broken logic in Request::getHttpHost(). It was ignoring HTTP_HOST completely.
2011-05-25 16:02:16 -04:00
Brikou CARRE
9908d51da8
removed docblock for isNoCache
2011-05-23 01:37:10 -07:00
Brikou CARRE
2648ff273e
fixed the description of isNoCache method
2011-05-23 09:35:41 +02:00
Brikou CARRE
12bf94c7ff
fixed description for isNoCache method
2011-05-23 08:44:08 +02:00
Brikou CARRE
e018e6ce44
added missing method's docblock
2011-05-22 09:13:03 +02:00
Miha Vrhovnik
2e286073a4
Removed ability to override method from GET request
2011-05-19 14:08:34 +02:00
Miha Vrhovnik
65ed6f7763
Added support for request method overriding via X-HTTP-Method-Override
...
This type of override is supported by MS MVC3 and is recommended by Google.
Also added ability to override request method via ?_method= when
request is made via GET.
2011-05-19 09:33:08 +02:00
Fabien Potencier
5a38886b1d
[HttpFoundation] fixed Request::getHttpHost()
2011-05-16 08:20:17 +02:00
Fabien Potencier
e81b88c576
[HttpFoundation] added HeaderBag::__toString()
2011-05-15 12:38:12 +02:00