This PR was merged into the 2.3 branch.
Discussion
----------
Add missing exclusions from phpunit.xml.dist
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
d4880c4 Add missing exclusions from phpunit.xml.dist
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16566).
Discussion
----------
[HttpFoundation] Fix undefined array $server
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
$server variable isn't defined in the test /src/Symfony/Component/HttpFoundation/Tests/RequestTest.php:RequestTest
Commits
-------
75aa6f6 Fix undefined array $server
This PR was squashed before being merged into the 2.8 branch (closes#16581).
Discussion
----------
Fix call to undefined function json_last_error_message
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
15f9cf2 Fix call to undefined function json_last_error_message
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle] Fix PropertyInfo extractor namespace in framework bundle
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The only failing test I had was because of the missing zendframework/zend-stdlib, adding it made tests pass.
Commits
-------
d04984a Fix PropertyInfo extractor namespace in framework bundle
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#16578).
Discussion
----------
[Console] Fix bug in windows detection
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16577
| License | MIT
| Doc PR | n/a
Commits
-------
c4068d9 Fix bug in windows detection
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16553).
Discussion
----------
[ProxyManager] Tmp fix composer reqs issue in ZF
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
See https://github.com/Ocramius/ProxyManager/issues/260#issuecomment-156962918
Commits
-------
0125145 [ProxyManager] Tmp fix composer reqs issue in ZF
This PR was merged into the 2.8 branch.
Discussion
----------
[WebProfilerBundle] correct typo in show stack trace link
| Q | A
| ------------- | ---
| Fixed tickets | n/a
| License | MIT
Simple typo fix for link for showing stack trace in the Logs page of the 2.8/3.0 profiler.
Commits
-------
9b08505 [WebProfilerBundle] correct typo in show stack trace link
This PR was squashed before being merged into the 2.3 branch (closes#16352).
Discussion
----------
Fix the server variables in the router_*.php files
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
The built-in web server automatically rewrites everything to the `app_dev.php` script, but it does not adjust the server variables accordingly.
Here is the output of `print_r($_SERVER)` on Apache with mod_rewrite enabled (relevant lines only):
```
Array
(
[REQUEST_URI] => /text-elements.html
[SCRIPT_NAME] => /app_dev.php
[PHP_SELF] => /app_dev.php
)
```
And here is the output of the exact same script on the built-in server:
```
Array
(
[REQUEST_URI] => /text-elements.html
[SCRIPT_NAME] => /text-elements.html
[PHP_SELF] => /text-elements.html
)
```
And here is the return value of Symfony's `Request::getScriptName()` method:
```php
// Apache: http://localhost/text-elements.html
echo $this->container->get('request_stack')->getCurrentRequest()->getScriptName(); // /app_dev.php
// Built-in web server: http://127.0.0.1:8000/text-elements.html
echo $this->container->get('request_stack')->getCurrentRequest()->getScriptName(); // /text-elements.html
```
This PR fixes the two server variables in the `router_dev.php` script.
Commits
-------
4923411 Fix the server variables in the router_*.php files
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Allow an empty path with a non empty fragment or a query
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16536
| License | MIT
| Doc PR | -
#16259 didn't fully fix the issue.
Commits
-------
2d0af8e [Validator] Allow an empty path with a non empty fragment or a query
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16528).
Discussion
----------
[Translation] Add support for Armenian pluralization.
According to http://www.unicode.org/cldr/charts/27/supplemental/language_plural_rules.html#hy
Armenian has 2 forms of pluralization for cardinal numbers.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
5f1980b The following change adds support for Armenian pluralization.
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes#16446).
Discussion
----------
OptionsResolver test coverage
Hi,
This PR adds 100% test code coverage to OptionsResolver component.
Best regards,
Michal
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
185950c OptionsResolver test coverage
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes#16523).
Discussion
----------
Reorder upgrade doc
Just group "The option "`a`" was renamed to "`b`"." together.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
2c65507 Reorder upgrade steps
This PR was merged into the 3.0-dev branch.
Discussion
----------
[3.0] Revert removal of framework.csrf_protection section
| Q | A
| ------------- | ---
| Bug fix? | [yes|no]
| New feature? | [yes|no]
| BC breaks? | [yes|no]
| Deprecations? | [yes|no]
| Tests pass? | yes
| Fixed tickets | #16508
| License | MIT
| Doc PR | -
This section was incorrectly removed from Symfony 3, only the `field_name` setting was removed. Disabling/enabling CSRF seperately from the froms is not deprecated and should not be removed.
/cc @symfony/deciders please merge quickly, it's holding up bundles with functional tests wanting to support to Symfony 3
Commits
-------
6f2782b Revert removal of framework.csrf_protection section
* 2.8:
Fixed tabs when there are several groups of tabs in the same page
Fix mode
Fixed failing test for HHVM
Removed unused logic in MockStream
Update coding standard for MockStream
[Filesystem] added tempnam() stream wrapper aware version of PHP's native tempnam() and fixed dumpFile to allow dumping to streams
Renamed key to secret
This PR was merged into the 2.8 branch.
Discussion
----------
Fixed tabs when there are several groups of tabs in the same page
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16506
| License | MIT
| Doc PR | -
Multiple tabs in the same page work again as expected:
![multiple_tabs](https://cloud.githubusercontent.com/assets/73419/11059933/310169c6-879d-11e5-91b2-b90af67b2a74.gif)
Commits
-------
c5daff0 Fixed tabs when there are several groups of tabs in the same page
This PR was merged into the 3.0-dev branch.
Discussion
----------
Remove some more legacy code
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
5aa4a3b Remove some more legacy code
This PR was squashed before being merged into the 2.3 branch (closes#16510).
Discussion
----------
[2.3][Process] fix Proccess run with pts enabled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12643
| License | MIT
| Doc PR |
Commits
-------
9cf90fb [2.3][Process] fix Proccess run with pts enabled