Commit Graph

24768 Commits

Author SHA1 Message Date
Nicolas Grekas
202cc7724e [DI] Fix AutowirePass fatal error with classes that have non-existing parents 2016-04-20 16:12:37 +02:00
Nicolas Grekas
6a0a6872bf bug #18593 [VarDumper] Fix dumping type hints for non-existing parent classes (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[VarDumper] Fix dumping type hints for non-existing parent classes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

812bf5c [VarDumper] Fix dumping type hints for non-existing parent classes
2016-04-20 14:13:47 +02:00
Martin Hasoň
1735b85c04 [DependencyInjection] Tests for AutowirePass with missing parent class 2016-04-20 14:07:35 +02:00
Nicolas Grekas
d1038c3421 bug #18596 [DI] Fix internal caching in AutowirePass (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[DI] Fix internal caching in AutowirePass

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

ping @dunglas

Commits
-------

ed2e236 [DI] Fix internal caching in AutowirePass
2016-04-20 13:30:10 +02:00
Nicolas Grekas
ed2e2360bc [DI] Fix internal caching in AutowirePass 2016-04-20 08:44:03 +02:00
Fabien Potencier
2f0b8f8f3f bug #18581 [Console] [TableHelper] make it work with SymfonyStyle. (aitboudad)
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] [TableHelper] make it work with SymfonyStyle.

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #18573
| License       | MIT
| Doc PR        | ~

Commits
-------

43cc93c [Console] [TableHelper] make it work with SymfonyStyle.
2016-04-20 08:32:07 +02:00
Shawn Iwinski
e249bc3cae [Security] Normalize "symfony/security-acl" dependency versions across all composer.json files 2016-04-19 14:38:18 -04:00
Nicolas Grekas
812bf5c45d [VarDumper] Fix dumping type hints for non-existing parent classes 2016-04-19 19:25:26 +02:00
Nicolas Grekas
44e3664ac9 minor #18585 [PropertyInfo] Remove useless return statement (dunglas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PropertyInfo] Remove useless return statement

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

9093bd5 [PropertyInfo] Remove useless return statement
2016-04-19 16:06:07 +02:00
Christophe Coevoet
40b4cb2c4a minor #18591 [Config] Fix XmlUtilsTest namespace (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[Config] Fix XmlUtilsTest namespace

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

58425eb [Config] Fix XmlUtilsTest namespace
2016-04-19 15:42:43 +02:00
jhonnyL
58425eb44c [Config] Fix XmlUtilsTest namespace 2016-04-19 13:29:13 +00:00
Abdellatif Ait boudad
43cc93c7e8 [Console] [TableHelper] make it work with SymfonyStyle. 2016-04-19 12:28:43 +01:00
Fabien Potencier
c848f88c72 minor #18584 [Serializer] Remove dead code (theofidry)
This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] Remove dead code

| Q             | A
| ------------- | ---
| Branch?       | 2.7+
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

The deleted lines are the exact equivalent of L249-251. It looks like this is due from a bad merged when the (de)normalization cache has been removed.

Commits
-------

31c530a Remove dead code
2016-04-19 10:49:24 +02:00
Kévin Dunglas
9093bd5d83 [PropertyInfo] Remove useless return statement 2016-04-18 22:49:43 +02:00
Théo FIDRY
31c530ae4a
Remove dead code 2016-04-18 20:15:00 +01:00
Romain Neutron
1a5d4adadd [WebProfilerBunde] Give an absolute url in case the request occured from another domain 2016-04-16 12:12:40 +02:00
Fabien Potencier
2528ec48cc bug #18280 [Routing] add query param if value is different from default (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[Routing] add query param if value is different from default

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | most likely not
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #10940, #18111, #18035
| License       | MIT
| Doc PR        | -

Commits
-------

1ef2edf [Routing] add query param if value is different from default
2016-04-15 11:53:50 +02:00
Fabien Potencier
5356dbb7ee bug #18540 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

Replace iconv_*() uses by mb_*(), add mbstring polyfill when required

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18539
| License       | MIT
| Doc PR        | -

Looks like `iconv_*()` functions can be really slow (see #18539).

Commits
-------

27f5f81 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required
2016-04-15 11:20:55 +02:00
jhonnyL
9f2f858f55 [FrameworkBundle] Remove misleading comment 2016-04-14 20:06:25 +00:00
Fabien Potencier
db31b5699d Merge branch '2.7' into 2.8
* 2.7:
  [Console] use ANSI escape sequences in ProgressBar overwrite method
  [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
  [DependencyInjection] Remove YAML check in CrossCheckTest
  [Process] Consistently use getProcess() in tests
  [DependencyInjection] fix phpDoc
2016-04-14 17:22:22 +02:00
Fabien Potencier
44efeaaa27 Merge branch '2.3' into 2.7
* 2.3:
  [DependencyInjection] Remove YAML check in CrossCheckTest
  [DependencyInjection] fix phpDoc
2016-04-14 17:17:41 +02:00
Fabien Potencier
6400b703d4 bug #18496 [Console] use ANSI escape sequences in ProgressBar overwrite method (alekitto)
This PR was squashed before being merged into the 2.7 branch (closes #18496).

Discussion
----------

[Console] use ANSI escape sequences in ProgressBar overwrite method

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | maybe
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16957
| License       | MIT
| Doc PR        |

Rewritten `overwrite` method in ProgressBar class to use ANSI escape sequences to erase lines.
This removes the need to store the last message length as it is not needed to fill the buffer with spaces anymore. As a plus it correctly resets the cursor position while clearing the output

If the output is not decorated the behavior has not been changed.
Could possibly cause a BC break if testing against the decorated emitted output as binary string

Commits
-------

b6cca4c [Console] use ANSI escape sequences in ProgressBar overwrite method
2016-04-14 13:51:22 +02:00
Alessandro Chitolina
b6cca4c020 [Console] use ANSI escape sequences in ProgressBar overwrite method 2016-04-14 13:51:20 +02:00
Christophe Coevoet
6467b24014 minor #18534 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException() (chalasr)
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #18534).

Discussion
----------

[HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18527
| License       | MIT
| Doc PR        | n/a

The `$original` argument has been removed from the method signature in [22f4807](22f4807522).

Commits
-------

00ae320 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
2016-04-14 11:51:33 +02:00
Robin Chalas
00ae320f83 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
Remove unexpected argument from ExceptionListener::logException() method call because the signature has changed in 22f4807
2016-04-14 11:51:32 +02:00
Nicolas Grekas
27f5f81eb3 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required 2016-04-14 10:48:44 +02:00
Fabien Potencier
b803680efe bug #18490 [LDAP] Free the search result after a search to free memory (hiddewie)
This PR was merged into the 2.8 branch.

Discussion
----------

[LDAP] Free the search result after a search to free memory

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7da4453 [LDAP] Free the search result after a search to free memory
2016-04-13 07:10:49 -07:00
Fabien Potencier
8c89a3a0a3 minor #18532 [DependencyInjection] Remove check for YAML class in CrossCheckTest (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Remove check for YAML class in CrossCheckTest

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    |  no
| Deprecations? |  no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I suppose it's a leftover from when YAML component only was added in suggest.

Commits
-------

af92275 [DependencyInjection] Remove YAML check in CrossCheckTest
2016-04-13 07:04:16 -07:00
jhonnyL
af922758f4 [DependencyInjection] Remove YAML check in CrossCheckTest 2016-04-13 10:32:03 +00:00
Nicolas Grekas
03aa64ad25 minor #18505 [DependencyInjection] fix phpDoc (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] fix phpDoc

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

* Use inheritdoc where possible
* Remove useless Constructor/__toString

Commits
-------

46ea9cc [DependencyInjection] fix phpDoc
2016-04-12 20:59:35 +02:00
Nicolas Grekas
da357d8424 minor #18519 [Process] Consistently use getProcess() in tests (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Consistently use getProcess() in tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ce13fe7 [Process] Consistently use getProcess() in tests
2016-04-12 20:54:02 +02:00
Christian Flothmann
ed9c94c719 Merge branch '2.7' into 2.8
* 2.7:
  [Filesystem] Better error handling in remove()
  [DependencyInjection] Add coverage for invalid Expression in exportParameters
  [DependencyInjection] Add coverage for all invalid arguments in exportParameters
  anonymous services are always private
  [Console] Correct time formatting.
  [DependencyInjection] Resolve aliases before removing abstract services + add tests
  Fix Dom Crawler select option with empty value
  Remove unnecessary option assignment
  remove unused variable
  mock the proper method
  [PropertyAccess] Fix regression
2016-04-12 20:01:21 +02:00
Nicolas Grekas
689f27b397 bug #18491 [DependencyInjection] anonymous services are always private (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[DependencyInjection] anonymous services are always private

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

0a469a4 anonymous services are always private
2016-04-12 17:22:47 +02:00
Nicolas Grekas
fd693e6997 Merge branch '2.3' into 2.7
* 2.3:
  [Filesystem] Better error handling in remove()
2016-04-12 17:21:00 +02:00
Nicolas Grekas
6401371c7e bug #18515 [Filesystem] Better error handling in remove() (nicolas-grekas)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18515).

Discussion
----------

[Filesystem] Better error handling in remove()

| Q             | A
| ------------- | ---
| Branch?       | master (to be moved on 2.3 when merging)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18512
| License       | MIT
| Doc PR        | -

Commits
-------

b848ddb [Filesystem] Better error handling in remove()
2016-04-12 17:20:10 +02:00
Nicolas Grekas
b848ddb7f0 [Filesystem] Better error handling in remove() 2016-04-12 17:20:10 +02:00
Nicolas Grekas
ce13fe7454 [Process] Consistently use getProcess() in tests 2016-04-12 13:52:58 +02:00
Hidde Wieringa
7da445307c
[LDAP] Free the search result after a search to free memory
Fixed error handling in ldap_search and ldap_free

Added spaces around if

Fixed trailing spaces

Added functional tests for Ldap component

Fixed style errors

Fixed style errors 2

Added slapd to Travis requirements

Added mkdir /tmp/travis to Travis build config

Revert "Added mkdir /tmp/travis to Travis build config"

This reverts commit d7f1884e6dc53602ad8dca6caeabb423445166cc.

Revert "Added slapd to Travis requirements"

This reverts commit 9b212ff5eb9fc2f4d6d54b787e4d307b0e164e21.

Revert "Fixed style errors 2"

This reverts commit cbe0c168d6c9a50dac1ba6593113573f53768be3.

Revert "Fixed style errors"

This reverts commit a2dc110f3df1b9e803447b94d2794eb1a3e8c300.

Revert "Added functional tests for Ldap component"

This reverts commit 33a67230dd25dabdb454381a3cdee95bdaac7f30.
2016-04-12 11:43:13 +02:00
JhonnyL
46ea9cc453 [DependencyInjection] fix phpDoc 2016-04-11 16:45:49 +02:00
Fabien Potencier
8bf49692b6 minor #18499 [DependencyInjection] Add coverage for invalid Expression in exportParameters (JhonnyL)
This PR was merged into the 2.7 branch.

Discussion
----------

[DependencyInjection] Add coverage for invalid Expression in exportParameters

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

1931b14 [DependencyInjection] Add coverage for invalid Expression in exportParameters
2016-04-11 05:50:45 -07:00
Fabien Potencier
3cd380da42 Merge branch '2.3' into 2.7
* 2.3:
  [DependencyInjection] Add coverage for all invalid arguments in exportParameters
2016-04-11 05:48:18 -07:00
Fabien Potencier
302e1928b8 minor #18500 [DependencyInjection] Add coverage for all invalid arguments in exportParameters (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Add coverage for all invalid arguments in exportParameters

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

87c4f23 [DependencyInjection] Add coverage for all invalid arguments in exportParameters
2016-04-11 05:47:06 -07:00
JhonnyL
1931b14a60 [DependencyInjection] Add coverage for invalid Expression in exportParameters 2016-04-11 10:53:08 +02:00
JhonnyL
87c4f23764 [DependencyInjection] Add coverage for all invalid arguments in exportParameters 2016-04-10 20:31:05 +02:00
Christian Flothmann
0a469a418f anonymous services are always private 2016-04-09 16:46:37 +02:00
Jules Pietri
ea5375c7b7 [Form] refactor CheckboxListMapper and RadioListMapper
fixes #14712 and #17789.

`ChoiceType` now always use `ChoiceToValueTransformer` or
`ChoicesToValuesTransformer` depending on `multiple` option.
Hence `CheckboxListMapper` and `RadioListMapper` don’t handle
the transformation anymore.
Fixes pre selection of choice with model values such as `null`,
`false` or empty string.
2016-04-09 15:28:45 +02:00
Jules Pietri
71841c737c Revert "[Form] refactor RadioListMapper::mapDataToForm()"
closes #18173.

This reverts commit 8f918e5f84.
2016-04-09 15:28:10 +02:00
Christian Flothmann
064aedf9e3 Merge branch '2.3' into 2.7
* 2.3:
  [DependencyInjection] Resolve aliases before removing abstract services + add tests
  Fix Dom Crawler select option with empty value
  Remove unnecessary option assignment
  remove unused variable
  [PropertyAccess] Fix regression
2016-04-09 12:56:56 +02:00
Fabien Potencier
cd8679754d bug #18360 [PropertyInfo] Extract nullable and collection key type for Doctrine associations (teohhanhui)
This PR was merged into the 2.8 branch.

Discussion
----------

[PropertyInfo] Extract nullable and collection key type for Doctrine associations

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

3008228 [PropertyInfo] Extract nullable and collection key type for Doctrine associations
2016-04-07 17:25:20 +02:00
Fabien Potencier
416f7d751f bug #18449 [PropertyAccess] Fix regression (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[PropertyAccess] Fix regression

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |
| Tests pass?   | yes
| Fixed tickets | #18437
| License       | MIT
| Doc PR        | -

All credits go to @MisatoTremor

I don't measure any perf impact.

Commits
-------

2b30d48 [PropertyAccess] Fix regression
2016-04-07 17:14:27 +02:00