Commit Graph

18262 Commits

Author SHA1 Message Date
Fabien Potencier
a80348b228 feature #22838 Make the simple exception pages match the new style (javiereguiluz)
This PR was squashed before being merged into the 3.3 branch (closes #22838).

Discussion
----------

Make the simple exception pages match the new style

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22631
| License       | MIT
| Doc PR        | -

If you create an application with Symfony Flex and don't install the TwigBundle explicitly, you see the exception pages like this:

![before](https://cloud.githubusercontent.com/assets/73419/26286531/3737f41c-3e68-11e7-8f1f-d9454bbc81f2.png)

This PR updates that page to match the style of the rest of exceptions:

![after](https://cloud.githubusercontent.com/assets/73419/26286534/488a2e4c-3e68-11e7-9d9e-8af8a478ff44.png)

For comparison, this is how the full exception page looks:

![full-exception](https://cloud.githubusercontent.com/assets/73419/26286535/56d69f26-3e68-11e7-8068-8334f045a63d.png)

---

Should I add the small black top header with the Symfony logo too?

Commits
-------

bab4b9c23c Make the simple exception pages match the new style
2017-05-27 09:02:28 -07:00
Javier Eguiluz
bab4b9c23c Make the simple exception pages match the new style 2017-05-27 09:02:27 -07:00
Fabien Potencier
1d1d997b5b bug #22718 [Console] Fixed different behaviour of key and value user inputs in multiple choice question (borNfreee)
This PR was squashed before being merged into the 2.7 branch (closes #22718).

Discussion
----------

[Console] Fixed different behaviour of key and value user inputs in multiple choice question

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22706
| License       | MIT
| Doc PR        | -

Fixed a bug when value from multiple choice list could not be selected by user's input
while it could be selected by typing its index in the list.

Commits
-------

2861bd7b01 [Console] Fixed different behaviour of key and value user inputs in multiple choice question
2017-05-27 07:10:28 -07:00
borNfreee
2861bd7b01 [Console] Fixed different behaviour of key and value user inputs in multiple choice question 2017-05-27 07:10:26 -07:00
Fabien Potencier
7a279c65c2 feature #22907 [Serializer] remove remaining deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Serializer] remove remaining deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

8425f1b748 [Serializer] remove remaining deprecated features
2017-05-27 07:08:31 -07:00
Nicolas Grekas
2c4bb0f19c Merge branch '3.4'
* 3.4:
  fixed CS
  Only override getProjectDir if it exists in the kernel
  [FrameworkBundle][Validator] Move the PSR-11 factory to the component
2017-05-27 12:24:10 +02:00
Nicolas Grekas
dd617b3204 Merge branch '3.3' into 3.4
* 3.3:
  fixed CS
  Only override getProjectDir if it exists in the kernel
  [FrameworkBundle][Validator] Move the PSR-11 factory to the component
2017-05-27 12:21:10 +02:00
Nicolas Grekas
eb93ac904c [Cache] Dont use pipelining with RedisCluster 2017-05-27 12:12:52 +02:00
Nicolas Grekas
1ecfa82ff0 Merge branch '3.4'
* 3.4:
  [DI] Deprecate XML services without ID
  [3.4] Allow 4.* deps
  Fix kernel.project_dir extensibility
2017-05-27 12:06:16 +02:00
Nicolas Grekas
e9f0e84c0e Merge branch '3.3' into 3.4
* 3.3:
  Fix kernel.project_dir extensibility
2017-05-27 12:02:34 +02:00
Fabien Potencier
da376d9811 feature #22886 [HttpKernel] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[HttpKernel] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | /no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

4d522d338a [HttpKernel] remove deprecated features
2017-05-26 07:16:09 -07:00
Christophe Coevoet
cf60f6d744 feature #22905 [FrameworkBundle][Validator] Move the PSR-11 factory to the component (ogizanagi)
This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle][Validator] Move the PSR-11 factory to the component

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/22887#issuecomment-303765795 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Instead of the 3 following deprecations:
 * The `ConstraintValidatorFactory::$validators` and `$container` properties
   have been deprecated and will be removed in 4.0.
 * Extending `ConstraintValidatorFactory` is deprecated and won't be supported in 4.0.
* Passing an array of validators or validator aliases as the second argument of
   `ConstraintValidatorFactory::__construct()` is deprecated since 3.3 and will
   be removed in 4.0. Use the service locator instead.

I'd suggest simply deprecating the FrameworkBundle's class in favor of using a new `ContainerConstraintValidatorFactory`. To me, there is no reason anyone using the validator component without the framework bundle cannot use this PSR-11 compliant implementation, nor I see a reason to make it final.

Commits
-------

68c1917af9 [FrameworkBundle][Validator] Move the PSR-11 factory to the component
2017-05-26 12:01:03 +02:00
Maxime Steinhausser
68c1917af9 [FrameworkBundle][Validator] Move the PSR-11 factory to the component 2017-05-26 10:48:50 +02:00
Christian Flothmann
25381a2809 [Filesystem] improve error handling in lock() 2017-05-26 09:33:33 +02:00
Fabien Potencier
7263d7700b feature #22906 [Console] remove remaining deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Console] remove remaining deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

4bae9aa3da [Console] remove remaining deprecated features
2017-05-25 16:52:05 -07:00
Fabien Potencier
d741908f0f feature #22879 [Translation] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Translation] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

3a03de0787 [Translation] remove deprecated features
2017-05-25 16:50:05 -07:00
Fabien Potencier
ad2c9f06d3 feature #22880 [Routing] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Routing] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

9560031345 [Routing] remove deprecated features
2017-05-25 16:48:39 -07:00
Fabien Potencier
26afd2c1bf bug #22728 [HttpKernel] Fix kernel.project_dir extensibility (chalasr)
This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel] Fix kernel.project_dir extensibility

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/22727
| License       | MIT
| Doc PR        | n/a

Alternative to #22727 that makes use of the existing public api.

Commits
-------

3230fc7e70 Fix kernel.project_dir extensibility
2017-05-25 16:46:48 -07:00
Fabien Potencier
ec4689122c bug #22829 [Yaml] fix colon without space deprecation (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] fix colon without space deprecation

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

A colon after a mapping key that is not followed by a space is valid if the mapping key is quoted.

Commits
-------

57f6941e25 [Yaml] fix colon without space deprecation
2017-05-25 16:42:36 -07:00
Fabien Potencier
683b236625 minor #22885 [3.4] Allow 4.* deps (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[3.4] Allow 4.* deps

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22756
| License       | MIT
| Doc PR        | -

This is implementing option 3 as described in #22756.
See #22769 for corresponding PR on 2.8: everything goes well and this allows catching a few more potential mistakes.

Commits
-------

c3e1646af8 [3.4] Allow 4.* deps
2017-05-25 16:27:00 -07:00
Fabien Potencier
3c9a591c06 feature #22903 [DI] Deprecate XML services without ID (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Deprecate XML services without ID

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no, confusing though
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

On slack someone had a issue with class named services;

> So, probably should have done this sooner, I stepped through with a debugger and it looks like \Symfony\Component\DependencyInjection\Loader\XmlFileLoader::processAnonymousServices assigns a sha256 to services that don't have any IDs
> When my manually wired service is registered, it has an ID that looks like 1_344b468f6069ffe8c32092409d99c59abc218f41071ce4c4230c198876129bc0, so it doesn't override the auto-loaded one
> I swear I read that IDs default to the class name now...

The fix was easy; doing `<service id="ClassName"/>` instead of `<service class="ClassName"/>`. However the thing is... i made the exact same mistake trying to reproduce 😅

I think given the recent developments (dropping type based autowiring and class named services) it makes sense to force XML service to specify an ID attribute (the top level ones). This would be consistent with YAML and PHP as well.

Fixing deprecations is also easy, just change `class` attribute to `id` like i've done for the frameworkbundle in this PR.

Any thoughts?

Commits
-------

b8c68da010 [DI] Deprecate XML services without ID
2017-05-25 16:22:40 -07:00
Fabien Potencier
4c7da9fc56 Merge branch '3.4'
* 3.4:
  [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const
  [DI] Avoid private call to Container::has()
  Fixing missing abstract attribute in XmlDumper
  [Form] Remove DateTimeToStringTransformer $parseUsingPipe option
  [Yaml] parse PHP constants in mapping keys
  don't call getTrustedHeaderName() if possible
  Fix file perms
  Fixed filename in help text for update-data.php
2017-05-25 16:11:32 -07:00
Fabien Potencier
f34a2556af Merge branch '3.3' into 3.4
* 3.3:
  [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const
  [DI] Avoid private call to Container::has()
  Fixing missing abstract attribute in XmlDumper
  [Form] Remove DateTimeToStringTransformer $parseUsingPipe option
  [Yaml] parse PHP constants in mapping keys
  don't call getTrustedHeaderName() if possible
  Fix file perms
  Fixed filename in help text for update-data.php
2017-05-25 16:10:58 -07:00
Fabien Potencier
bf85c7d4e2 Merge branch '3.2' into 3.3
* 3.2:
  [DI] Avoid private call to Container::has()
  Fixing missing abstract attribute in XmlDumper
  [Form] Remove DateTimeToStringTransformer $parseUsingPipe option
  Fix file perms
  Fixed filename in help text for update-data.php
2017-05-25 16:10:31 -07:00
Fabien Potencier
810623df5e Merge branch '2.8' into 3.2
* 2.8:
  Fixing missing abstract attribute in XmlDumper
  [Form] Remove DateTimeToStringTransformer $parseUsingPipe option
  Fix file perms
  Fixed filename in help text for update-data.php
2017-05-25 15:59:05 -07:00
Fabien Potencier
321e41cb6b Merge branch '2.7' into 2.8
* 2.7:
  Fixing missing abstract attribute in XmlDumper
  [Form] Remove DateTimeToStringTransformer $parseUsingPipe option
  Fix file perms
  Fixed filename in help text for update-data.php
2017-05-25 15:57:22 -07:00
Fabien Potencier
966f3877e7 bug #22901 Fix missing abstract key in XmlDumper (weaverryan)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix missing abstract key in XmlDumper

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Unless I'm missing something, the abstract key was missing in the XmlDumper. I noticed it when using `debug:container some_abstract_service` and was seeing "no" for abstract.

When this merges to 3.3, the `services-abstract.xml` will need to change to this:

```xml
<?xml version="1.0" encoding="utf-8"?>
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
  <services>
    <service id="service_container" class="Symfony\Component\DependencyInjection\ContainerInterface" synthetic="true"/>
    <service id="foo" class="Foo" abstract="true"/>
    <service id="Psr\Container\ContainerInterface" alias="service_container" public="false"/>
    <service id="Symfony\Component\DependencyInjection\ContainerInterface" alias="service_container" public="false"/>
  </services>
</container>
```

Commits
-------

40f60ec60d Fixing missing abstract attribute in XmlDumper
2017-05-25 15:55:11 -07:00
Fabien Potencier
fa93ff1389 feature #22904 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes (a missing part of a 3.3 feat.)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony-docs/issues/7045

Commits
-------

9ba12b0d2a [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const
2017-05-25 15:25:56 -07:00
Nicolas Grekas
9ba12b0d2a [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const 2017-05-25 15:39:26 +02:00
Nicolas Grekas
1eac1506df bug #22878 [Yaml] parse PHP constants in mapping keys (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] parse PHP constants in mapping keys

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22854
| License       | MIT
| Doc PR        |

Commits
-------

ae52fe6 [Yaml] parse PHP constants in mapping keys
2017-05-25 15:35:55 +02:00
Nicolas Grekas
4e95aacc17 bug #22873 [HttpKernel] don't call getTrustedHeaderName() if possible (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel] don't call getTrustedHeaderName() if possible

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/235008102 (failing tests of #22863)
| License       | MIT
| Doc PR        |

Commits
-------

6350dab don't call getTrustedHeaderName() if possible
2017-05-25 15:34:36 +02:00
Roland Franssen
56892819e3 [DI] Avoid private call to Container::has() 2017-05-25 14:59:08 +02:00
Ryan Weaver
40f60ec60d Fixing missing abstract attribute in XmlDumper
Caused mis-reporting of abstract key (always no) in debug:container
2017-05-25 08:56:45 -04:00
Maxime Steinhausser
ff77cde0fd Remove some more PHP < 7.1.3 code 2017-05-25 12:50:57 +02:00
Maxime Steinhausser
a841496238 [Form] Remove DateTimeToStringTransformer $parseUsingPipe option 2017-05-25 12:07:32 +02:00
Christian Flothmann
8425f1b748 [Serializer] remove remaining deprecated features 2017-05-25 11:28:34 +02:00
Roland Franssen
b8c68da010 [DI] Deprecate XML services without ID 2017-05-25 11:24:58 +02:00
Christian Flothmann
4bae9aa3da [Console] remove remaining deprecated features 2017-05-25 10:45:41 +02:00
Nicolas Grekas
8e0d41a87b minor #22894 Remove PHP<7 leftovers (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

Remove PHP<7 leftovers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Forgot while cleaning up

Commits
-------

f0147da Remove PHP < 7.1 leftovers
2017-05-25 08:54:37 +02:00
Nicolas Grekas
314fd0b753 minor #22895 Make internal constants private (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

Make internal constants private

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Changing some internal constants to private as suggested in https://github.com/symfony/symfony/pull/22862 (these are the only ones I found in the codebase)

Commits
-------

367b055 Make internal constants private
2017-05-25 08:43:50 +02:00
Nicolas Grekas
ff54ce529b Merge branch '3.4'
* 3.4:
  [CACHE] fix README
  [Cache] Fix phpunit.xml.dist
  [travis] Fix 3/4 cross tests
  [ProxyManager] Add FC layer
2017-05-25 07:56:23 +02:00
Nicolas Grekas
e5a0062a18 Merge branch '3.3' into 3.4
* 3.3:
  [CACHE] fix README
  [Cache] Fix phpunit.xml.dist
  [ProxyManager] Add FC layer
2017-05-25 07:53:40 +02:00
Nicolas Grekas
2642e725da Merge branch '3.2' into 3.3
* 3.2:
  [CACHE] fix README
2017-05-25 07:53:23 +02:00
Nicolas Grekas
20f52f4f56 feature #22892 [ProxyManager] Add FC layer (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[ProxyManager] Add FC layer

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes - minor
| Deprecations? | yes - made a class final
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This makes PRoxyDumper compatible with DumperInterface v4.0.
Technically, this is a BC break, but since I really don't expect anyone to extend ProxyDumper, I think we should do it - on 3.3 to close the gap as early as possible.

Commits
-------

4aeb6d8 [ProxyManager] Add FC layer
2017-05-25 07:52:28 +02:00
Christian Flothmann
ae52fe6dab [Yaml] parse PHP constants in mapping keys 2017-05-24 21:40:35 +02:00
Nicolas Grekas
b0b7a36354 minor #22897 [CACHE] fix README (IndraGunawan)
This PR was merged into the 3.2 branch.

Discussion
----------

[CACHE] fix README

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Add Resources section to Cache component readme

Commits
-------

c224ad7 [CACHE] fix README
2017-05-24 20:50:14 +02:00
Robin Chalas
367b055816 Make internal constants private 2017-05-24 19:37:23 +02:00
Indra Gunawan
c224ad7770 [CACHE] fix README 2017-05-25 00:25:35 +07:00
Robin Chalas
f0147dac80 Remove PHP < 7.1 leftovers 2017-05-24 19:22:17 +02:00
Nicolas Grekas
c9da3d9233 Merge branch '3.2' into 3.3
* 3.2:
  [Cache] Fix phpunit.xml.dist
2017-05-24 18:53:35 +02:00
Nicolas Grekas
38a768e3cc [Cache] Fix phpunit.xml.dist 2017-05-24 18:45:53 +02:00
Nicolas Grekas
4aeb6d8749 [ProxyManager] Add FC layer 2017-05-24 18:13:59 +02:00
Nicolas Grekas
6da68536f0 Merge branch '3.4'
* 3.4:
  [DI] Check privates before aliases consistently
  [Yaml] Add missing deprecation annotation
  [DI] Check for privates before shared services
2017-05-24 16:45:46 +02:00
Nicolas Grekas
9a081d83c4 Merge branch '3.3' into 3.4
* 3.3:
  [DI] Check privates before aliases consistently
  [Yaml] Add missing deprecation annotation
  [DI] Check for privates before shared services
2017-05-24 16:44:14 +02:00
Nicolas Grekas
b494106e2f Merge branch '3.2' into 3.3
* 3.2:
  [DI] Check privates before aliases consistently
2017-05-24 16:39:04 +02:00
Nicolas Grekas
1d9b1af4a3 [DI] Check privates before aliases consistently 2017-05-24 16:36:51 +02:00
Fabien Potencier
c7edc872d7 feature #22770 [Yaml] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Yaml] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

efe23371dc [Yaml] remove deprecated features
2017-05-24 16:33:08 +02:00
Nicolas Grekas
d7981e5838 Merge branch '3.2' into 3.3
* 3.2:
  [Yaml] Add missing deprecation annotation
  [DI] Check for privates before shared services
2017-05-24 16:31:45 +02:00
Fabien Potencier
69583b2403 bug #22866 [DI] Check for privates before shared services (ro0NL)
This PR was merged into the 3.2 branch.

Discussion
----------

[DI] Check for privates before shared services

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/22801#discussion_r117732213, https://github.com/symfony/symfony/pull/22801#discussion_r117732599
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

cc @stof

Commits
-------

4f683a9a5b [DI] Check for privates before shared services
2017-05-24 16:25:02 +02:00
Christian Flothmann
3a129494b1 [ProxyManagerBridge] remove deprecated features 2017-05-24 14:25:37 +02:00
Christian Flothmann
efe23371dc [Yaml] remove deprecated features 2017-05-24 13:52:49 +02:00
Nicolas Grekas
3574455c59 Merge branch '3.4'
* 3.4:
  [DI] prepare for signature change in 4.0
  [DI] Add missing deprecation on Extension::getClassesToCompile
  [Lock] Re-add the Lock component in 3.4
  [Routing] remove an unused routing fixture
  [Yaml] fix multiline block handling
  [WebProfilerBundle] Fix sub-requests display in time profiler panel
  [FrameworkBundle] Handle project dir in cache:clear command
  [WebServerBundle] Mark ServerCommand as internal
  [DI] Fix autowire error for inlined services
  Close PHP code in phpt file
  [Profiler][VarDumper] Fix searchbar css when in toolbar
  Prevent auto-registration of UserPasswordEncoderCommand
  [Process] Fixed incorrectly escaping arguments on Windows when inheritEnvironmentVariables is set to false
  avoid double blanks while rendering form attributes
  use getProjectDir() when possible
  [PhpUnitBridge] add a changelog file
  [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
2017-05-24 13:42:26 +02:00
Nicolas Grekas
e2689d42fc Merge branch '3.3' into 3.4
* 3.3:
  [DI] prepare for signature change in 4.0
  [DI] Add missing deprecation on Extension::getClassesToCompile
  [Routing] remove an unused routing fixture
  [Yaml] fix multiline block handling
  [WebProfilerBundle] Fix sub-requests display in time profiler panel
  [FrameworkBundle] Handle project dir in cache:clear command
  [WebServerBundle] Mark ServerCommand as internal
  [DI] Fix autowire error for inlined services
  Close PHP code in phpt file
  [Profiler][VarDumper] Fix searchbar css when in toolbar
  Prevent auto-registration of UserPasswordEncoderCommand
  [Process] Fixed incorrectly escaping arguments on Windows when inheritEnvironmentVariables is set to false
  avoid double blanks while rendering form attributes
  use getProjectDir() when possible
  [PhpUnitBridge] add a changelog file
  [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
2017-05-24 13:37:21 +02:00
Nicolas Grekas
feaf5c987e Merge branch '3.2' into 3.3
* 3.2:
  [Routing] remove an unused routing fixture
  [WebProfilerBundle] Fix sub-requests display in time profiler panel
  [PhpUnitBridge] add a changelog file
2017-05-24 13:35:23 +02:00
Nicolas Grekas
667efd251e minor #22818 [DependencyInjection] prepare for signature change in 4.0 (xabbuh)
This PR was submitted for the 3.4 branch but it was merged into the 3.3 branch instead (closes #22818).

Discussion
----------

[DependencyInjection] prepare for signature change in 4.0

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

see failing tests in #22785

Commits
-------

c4b6e20 [DI] prepare for signature change in 4.0
2017-05-24 13:33:24 +02:00
Christian Flothmann
c4b6e2014c [DI] prepare for signature change in 4.0 2017-05-24 13:31:33 +02:00
Nicolas Grekas
879c9129b7 feature #22884 [DI] Add missing deprecation on Extension::getClassesToCompile (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Add missing deprecation on Extension::getClassesToCompile

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Already dropped on master

Commits
-------

95fb929 [DI] Add missing deprecation on Extension::getClassesToCompile
2017-05-24 12:51:20 +02:00
Christian Flothmann
4d522d338a [HttpKernel] remove deprecated features 2017-05-24 12:23:11 +02:00
Christian Flothmann
cf458fa871 minor #22883 [Yaml] Add missing deprecation annotation (nicolas-grekas)
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] Add missing deprecation annotation

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

c67dd38 [Yaml] Add missing deprecation annotation
2017-05-24 11:51:02 +02:00
Nicolas Grekas
c3e1646af8 [3.4] Allow 4.* deps 2017-05-24 11:02:43 +02:00
Nicolas Grekas
95fb929c58 [DI] Add missing deprecation on Extension::getClassesToCompile 2017-05-24 10:46:17 +02:00
Christian Flothmann
9560031345 [Routing] remove deprecated features 2017-05-24 10:45:47 +02:00
Nicolas Grekas
c67dd3805b [Yaml] Add missing deprecation annotation 2017-05-24 10:41:50 +02:00
Fabien Potencier
a3078804ef feature #22597 [Lock] Re-add the Lock component in 3.4 (jderusse)
This PR was squashed before being merged into the 3.4 branch (closes #22597).

Discussion
----------

[Lock] Re-add the Lock component in 3.4

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #22580
| License       | MIT
| Doc PR        |

This PR reverts #22590 as decided in  #22580.

Commits
-------

3b6c495c89 [Lock] Re-add the Lock component in 3.4
2017-05-24 08:31:10 +02:00
Jérémy Derussé
3b6c495c89 [Lock] Re-add the Lock component in 3.4 2017-05-24 08:31:08 +02:00
Fabien Potencier
047a06e235 bug #22853 [Yaml] fix multiline block handling (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] fix multiline block handling

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21114, https://github.com/symfony/symfony/pull/22105#issuecomment-288386147
| License       | MIT
| Doc PR        |

Commits
-------

a2079d6e2e [Yaml] fix multiline block handling
2017-05-24 07:58:03 +02:00
Christian Flothmann
6f67221129 [Routing] remove an unused routing fixture
This was initially removed in #13361 and accidentally added again
in #11394.
2017-05-24 00:01:29 +02:00
Christian Flothmann
3a03de0787 [Translation] remove deprecated features 2017-05-23 23:28:30 +02:00
Christian Flothmann
a2079d6e2e [Yaml] fix multiline block handling 2017-05-23 20:34:36 +02:00
Christian Flothmann
6350dab5bf don't call getTrustedHeaderName() if possible 2017-05-23 20:22:28 +02:00
Roland Franssen
4f683a9a5b [DI] Check for privates before shared services 2017-05-23 19:58:02 +02:00
Nicolas Grekas
2f4dea56b4 bug #22857 [DI] Fix autowire error for inlined services (weaverryan)
This PR was squashed before being merged into the 3.3 branch (closes #22857).

Discussion
----------

[DI] Fix autowire error for inlined services

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22848
| License       | MIT
| Doc PR        | n/a

The `AutowirePass` defers autowiring exceptions until later so that we don't throw autowiring exceptions for services that are ultimately removed. But, if a service is *inlined*, then it appears to be removed, and so we don't throw the exception. This fixes that.

It's an easy fix - but it's a bit ugly. We're adding a bit more "state" to the passes... simply because there is some information that needs to be shared through the compiler process. There might be a better way of doing this in the future (e.g. storing some metadata on the `Compiler`), but this *does* work well.

Commits
-------

4bcef3d [DI] Fix autowire error for inlined services
2017-05-23 10:56:47 +02:00
Ryan Weaver
4bcef3d67c [DI] Fix autowire error for inlined services 2017-05-23 10:56:44 +02:00
Christian Flothmann
928da1ab57 [Form] remove deprecated features 2017-05-22 23:51:32 +02:00
Maxime Steinhausser
98b3002caf [Profiler][VarDumper] Fix searchbar css when in toolbar 2017-05-22 19:32:12 +02:00
Nicolas Grekas
82ec56b40c bug #22614 [Process] Fixed escaping arguments on Windows when inheritEnvironmentVariables is set to false (maryo)
This PR was merged into the 3.3 branch.

Discussion
----------

[Process]  Fixed escaping arguments on Windows when inheritEnvironmentVariables is set to false

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets |
| License       | MIT
| Doc PR        |

I've added a FAILING testcase on Windows. It incorrectly substitutes an argument containing a quotation mark probably assuming it's an env var needed to backup when inheritEnvironmentVariables is set to false.

Commits
-------

26032ef [Process] Fixed incorrectly escaping arguments on Windows when inheritEnvironmentVariables is set to false
2017-05-22 14:37:50 +02:00
maryo
26032ef055 [Process] Fixed incorrectly escaping arguments on Windows when inheritEnvironmentVariables is set to false 2017-05-22 14:32:03 +02:00
Nicolas Grekas
d6bdd23e3d Merge branch '3.4'
* 3.4:
  [DI] Deprecate Container::initialized() for privates
2017-05-22 13:40:59 +02:00
Nicolas Grekas
49d6604ee4 Fix file perms 2017-05-22 13:36:46 +02:00
Roland Franssen
e0eb247229 [DI] Deprecate Container::initialized() for privates 2017-05-22 13:20:30 +02:00
Nicolas Grekas
fe6cf73aa8 Merge branch '3.4'
* 3.4:
  [Serializer] Remove a useless legacy annotation
  Fixed extra semi-colon
  fix docblock position
  [DependencyInjection] remove unused variable
  [PhpUnitBridge] add changelog entries for #21140
  [DI] Remove dead service_container checks
2017-05-22 11:57:18 +02:00
Nicolas Grekas
98a2d3c429 Merge branch '3.3' into 3.4
* 3.3:
  [Serializer] Remove a useless legacy annotation
  Fixed extra semi-colon
  fix docblock position
  [DependencyInjection] remove unused variable
  [PhpUnitBridge] add changelog entries for #21140
  [DI] Remove dead service_container checks
2017-05-22 11:56:34 +02:00
Nicolas Grekas
88cddb8a31 feature #22773 [DependencyInjection] remove deprecated autowiring_types feature (hhamon)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DependencyInjection] remove deprecated autowiring_types feature

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

6fdcb84 [DependencyInjection] remove deprecated autowiring_types feature
2017-05-22 11:50:05 +02:00
Nicolas Grekas
5370a02034 feature #22809 [DI] Remove deprecated generating a dumped container without populating the method map (ro0NL)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DI] Remove deprecated generating a dumped container without populating the method map

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

See #20113

Commits
-------

fdb8c58 [DI] Remove deprecated generating a dumped container without populating the method map
2017-05-22 11:44:15 +02:00
Kévin Dunglas
987749bb99
[Serializer] Remove a useless legacy annotation 2017-05-22 11:36:51 +02:00
Hugo Hamon
6fdcb8496b [DependencyInjection] remove deprecated autowiring_types feature 2017-05-22 11:28:45 +02:00
Nicolas Grekas
063da35207 minor #22844 CS Fixes (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

CS Fixes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

21114f8 CS Fixes
2017-05-22 11:27:58 +02:00
Nicolas Grekas
e014b8a7a3 minor #22850 [VarDumper] CS Fix extra semi-colon (chalasr)
This PR was merged into the 3.3 branch.

Discussion
----------

[VarDumper] CS Fix extra semi-colon

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | 21114f84e6
| License       | MIT
| Doc PR        | n/a

Commits
-------

c252c08 Fixed extra semi-colon
2017-05-22 11:26:56 +02:00
Robin Chalas
c252c08d44 Fixed extra semi-colon 2017-05-22 11:10:57 +02:00
Robin Chalas
21114f84e6 CS Fixes 2017-05-22 11:03:40 +02:00
Roland Franssen
fdb8c58e15 [DI] Remove deprecated generating a dumped container without populating the method map 2017-05-22 09:52:16 +02:00
Nicolas Grekas
d33b6c5306 minor #22846 [FrameworkBundle][Translation] fix docblock position (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle][Translation] fix docblock position

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22822
| License       | MIT
| Doc PR        |

The `$defaultLocale` argument is present in the `Translator` class of
the FrameworkBundle, but is not part of the Translation component.

Commits
-------

0829964 fix docblock position
2017-05-22 09:49:45 +02:00
Nicolas Grekas
40b17336fc minor #22825 [DI] Remove dead service_container checks (ro0NL)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Remove dead service_container checks

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Since #21627

Commits
-------

9a8ea93 [DI] Remove dead service_container checks
2017-05-22 09:45:40 +02:00
Christian Flothmann
082996417d fix docblock position
The `$defaultLocale` argument is present in the `Translator` class of
the FrameworkBundle, but is not part of the Translation component.
2017-05-22 09:42:36 +02:00
Nicolas Grekas
3892a950c8 feature #22764 [DI] Remove deprecated dumping an uncompiled container (ro0NL)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DI] Remove deprecated dumping an uncompiled container

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | should be
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

See #20634

Commits
-------

c1c525c [DI] Remove deprecated dumping an uncompiled container
2017-05-22 09:37:12 +02:00
Roland Franssen
c1c525cdfe [DI] Remove deprecated dumping an uncompiled container 2017-05-22 09:11:02 +02:00
Nicolas Grekas
898516a87d minor #22745 [PropertyInfo] Remove dead code with PHP 7+ (dunglas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[PropertyInfo] Remove dead code with PHP 7+

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

b346e48 [PropertyInfo] Remove dead code with PHP 7+
2017-05-22 09:03:56 +02:00
Maxime Steinhausser
7091fb4df5 Remove PHP < 7.1.3 code 2017-05-22 08:50:05 +02:00
Hugo Hamon
1c2383f1a5 [DependencyInjection] remove unused variable 2017-05-21 23:03:33 +02:00
Nicolas Grekas
619f01c193 feature #22763 [DI] Remove deprecated isFrozen() (ro0NL)
This PR was squashed before being merged into the 4.0-dev branch (closes #22763).

Discussion
----------

[DI] Remove deprecated isFrozen()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | should be
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

See #19673

Test failure seems unrelated.

Commits
-------

04b39a3 [DI] Remove deprecated isFrozen()
2017-05-21 21:26:24 +02:00
Roland Franssen
04b39a3a20 [DI] Remove deprecated isFrozen() 2017-05-21 21:26:22 +02:00
Nicolas Grekas
b88be387c1 feature #22837 [VarDumper] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[VarDumper] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

b70471a [VarDumper] remove deprecated features
2017-05-21 21:15:14 +02:00
Fabien Potencier
1999dfab20 feature #22777 [Console] Remove deprecated console.exception event (mbabker)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Console] Remove deprecated console.exception event

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

80f329c330 Remove deprecated console.exception event
2017-05-21 20:42:15 +02:00
Christian Flothmann
b70471a94e [VarDumper] remove deprecated features 2017-05-21 20:41:14 +02:00
Fabien Potencier
a94e29f1eb feature #22821 [Security] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Security] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

23975048f8 [Security] remove deprecated features
2017-05-21 20:31:08 +02:00
Fabien Potencier
250481d452 feature #22750 [DependencyInjection] remove deprecated code in YamlFileLoader class (hhamon)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DependencyInjection] remove deprecated code in YamlFileLoader class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

854efce7ca [DependencyInjection] remove deprecated YAML configuration features and syntax
2017-05-21 20:03:12 +02:00
Christian Flothmann
23975048f8 [Security] remove deprecated features 2017-05-21 20:02:37 +02:00
Fabien Potencier
ce519b6e44 fixed typo 2017-05-21 20:01:31 +02:00
Nicolas Grekas
4d3c74bbe7 Merge branch '3.4'
* 3.4:
  [Finder] Deprecate FilterIterator
  forward compatibility with Symfony 4
2017-05-21 19:39:15 +02:00
Brandon Kelly
50fdcd6c4f Fixed filename in help text for update-data.php 2017-05-21 19:28:42 +02:00
Maxime Steinhausser
946066cc29 [Finder] Deprecate FilterIterator 2017-05-21 19:11:47 +02:00
Michael Babker
80f329c330 Remove deprecated console.exception event 2017-05-21 09:38:50 -05:00
Nicolas Grekas
1a7dde4116 Merge branch '3.4'
* 3.4:
  improve strict option value deprecation
  document deprecation of the StringUtil class
  Add missing doc param & deprecation changelog entries
2017-05-21 15:57:14 +02:00
Nicolas Grekas
8308b32b9f Merge branch '3.3' into 3.4
* 3.3:
  document deprecation of the StringUtil class
  Add missing doc param & deprecation changelog entries
2017-05-21 15:55:35 +02:00
Nicolas Grekas
b1349a7889 Merge branch '3.2' into 3.3
* 3.2:
  document deprecation of the StringUtil class
2017-05-21 15:55:13 +02:00
Nicolas Grekas
68cc2077f6 feature #22740 [SecurityBundle][Security][Finder] Remove deprecated code paths (ogizanagi)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[SecurityBundle][Security][Finder] Remove deprecated code paths

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | 1b600b0c94, 366aefd75f, 5b7fe852aa
| License       | MIT
| Doc PR        | N/A

Removing my own deprecated stuff from 4.0 :)

Commits
-------

da202fe [SecurityBundle][Security][Finder] Remove deprecated code paths
2017-05-21 15:02:46 +02:00
Nicolas Grekas
aba38efc52 feature #22823 [PropertyAccess] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[PropertyAccess] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

55fe07b [PropertyAccess] remove deprecated features
2017-05-21 14:59:09 +02:00
Nicolas Grekas
c3be3ea898 feature #22826 [Validator] improve strict option value deprecation (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] improve strict option value deprecation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

a820b42 improve strict option value deprecation
2017-05-21 14:54:27 +02:00
Nicolas Grekas
79e880cba5 feature #22799 [Console] Remove deprecated features (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Console] Remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~~#18999 #19012~~
| License       | MIT
| Doc PR        | n/a

Commits
-------

4cde3b9 [Console] Remove deprecated features
2017-05-21 14:49:03 +02:00
Christian Flothmann
57f6941e25 [Yaml] fix colon without space deprecation
A colon after a mapping key that is not followed by a space is valid if
the mapping key is quoted.
2017-05-21 14:39:29 +02:00
Nicolas Grekas
4d9d8cbbef feature #22786 [ClassLoader][HttpKernel] Remove ClassLoader component & Kernel::loadClassCache (ogizanagi, xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[ClassLoader][HttpKernel] Remove ClassLoader component & Kernel::loadClassCache

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  |no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20735
| License       | MIT
| Doc PR        | N/A

As deprecated in https://github.com/symfony/symfony/pull/20735

Commits
-------

551aaef [ClassLoader] remove the component
4f8916c [ClassLoader][HttpKernel] Remove ClassCollectionLoader & Kernel::loadClassCache BC layer
2017-05-21 12:31:05 +02:00
Christian Flothmann
a820b42a2d improve strict option value deprecation 2017-05-21 12:30:01 +02:00
Nicolas Grekas
2c3679abe9 feature #22795 [Validator] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Validator] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

bbd656b [Validator] remove deprecated features
2017-05-21 12:29:00 +02:00
Robin Chalas
4cde3b9fcb [Console] Remove deprecated features 2017-05-21 12:24:34 +02:00
Nicolas Grekas
54c31e433c feature #22784 [DoctrineBridge] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DoctrineBridge] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

ba78b7b [DoctrineBridge] remove deprecated features
2017-05-21 12:24:15 +02:00
Roland Franssen
9a8ea93139 [DI] Remove dead service_container checks 2017-05-21 12:19:15 +02:00
Christian Flothmann
bbd656b458 [Validator] remove deprecated features 2017-05-21 12:14:51 +02:00
Maxime Steinhausser
da202feb71 [SecurityBundle][Security][Finder] Remove deprecated code paths
- [Finder] Removed `ExceptionInterface`
- [SecurityBundle] remove `UserPasswordEncoderCommand` BC layer
- [Security] remove `LogoutUrlGenerator::registerListener` BC layer
2017-05-21 12:08:11 +02:00
Christian Flothmann
f00c47ac9c document deprecation of the StringUtil class 2017-05-21 12:07:34 +02:00
Christian Flothmann
551aaefcae [ClassLoader] remove the component
(cherry picked from commit c365ae2)
2017-05-21 12:04:58 +02:00
Maxime Steinhausser
4f8916cb59 [ClassLoader][HttpKernel] Remove ClassCollectionLoader & Kernel::loadClassCache BC layer 2017-05-21 12:04:55 +02:00
Christian Flothmann
55fe07b7a9 [PropertyAccess] remove deprecated features 2017-05-21 12:04:50 +02:00
Robin Chalas
7b14d4f4ec Add missing doc param & deprecation changelog entries 2017-05-21 12:00:14 +02:00
Nicolas Grekas
7047b41449 feature #22749 Remove deprecated container injections and compiler passes (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

Remove deprecated container injections and compiler passes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~~#21451 #21625 #21284 #22010~~ #22805
| License       | MIT
| Doc PR        | n/a

Commits
-------

16a2fcf Remove deprecated container injections and compiler passes
2017-05-21 11:57:37 +02:00
Nicolas Grekas
c0a2d02ad4 feature #22796 [EventDispatcher] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[EventDispatcher] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

598bec4 [EventDispatcher] remove deprecated features
2017-05-21 11:52:07 +02:00
Nicolas Grekas
3359a46f7c Merge branch '3.4'
* 3.4:
  update phpunit-bridge cache-id
  respect optional error handler arguments
  [Intl] Fix bin/common.php PHP7 compatibility
2017-05-21 11:49:56 +02:00
Nicolas Grekas
aeec858c00 Merge branch '3.3' into 3.4
* 3.3:
  update phpunit-bridge cache-id
  respect optional error handler arguments
  [Intl] Fix bin/common.php PHP7 compatibility
2017-05-21 11:48:53 +02:00
Nicolas Grekas
cd217fd121 Merge branch '3.2' into 3.3
* 3.2:
  update phpunit-bridge cache-id
  respect optional error handler arguments
  [Intl] Fix bin/common.php PHP7 compatibility
2017-05-21 11:48:35 +02:00
Nicolas Grekas
39b0515abf Merge branch '2.8' into 3.2
* 2.8:
  update phpunit-bridge cache-id
  respect optional error handler arguments
  [Intl] Fix bin/common.php PHP7 compatibility
2017-05-21 11:47:49 +02:00
Nicolas Grekas
7a792eb896 Merge branch '2.7' into 2.8
* 2.7:
  update phpunit-bridge cache-id
  respect optional error handler arguments
  [Intl] Fix bin/common.php PHP7 compatibility
2017-05-21 11:46:38 +02:00
Robin Chalas
16a2fcf978 Remove deprecated container injections and compiler passes 2017-05-21 11:42:36 +02:00
Christian Flothmann
598bec44a2 [EventDispatcher] remove deprecated features 2017-05-21 11:09:03 +02:00
Christian Flothmann
0813e14289 [Ldap] remove deprecated features 2017-05-21 11:06:29 +02:00
Nicolas Grekas
d3449e6a24 Merge branch '3.4'
* 3.4:
  bug #22814 [FrameworkBundle] FC with EventDispatcher 4.0 (xabbuh)
  [PhpUnitBridge] remove unused use statement
  do not used deprecated validator test case class
  do not mock a deprecated interface
  [DI] Added missing deprecation in changelog
  [Ldap] add a changelog file
  [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0
  [MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows
  [DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument
  [DI][Serializer] Fix missing de(normalizer|coder) autoconfig
  Use 0.0.0.0 as the server log host default.
2017-05-21 10:58:35 +02:00
Nicolas Grekas
b6fced6261 Merge branch '3.3' into 3.4
* 3.3:
  [PhpUnitBridge] remove unused use statement
  do not mock a deprecated interface
  [DI] Added missing deprecation in changelog
  [Ldap] add a changelog file
  [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0
  [MonologBridge] Fix the Monlog ServerLogHandler from Hanging on Windows
  [DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument
  [DI][Serializer] Fix missing de(normalizer|coder) autoconfig
  Use 0.0.0.0 as the server log host default.
2017-05-21 10:57:11 +02:00
Nicolas Grekas
023cf9e014 Merge branch '3.2' into 3.3
* 3.2:
  do not mock a deprecated interface
  [DI] Added missing deprecation in changelog
  [Ldap] add a changelog file
2017-05-21 10:56:50 +02:00
Nicolas Grekas
455b09bd3d minor #22802 [Ldap] add a changelog file (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[Ldap] add a changelog file

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

5bdda6c [Ldap] add a changelog file
2017-05-21 10:51:01 +02:00
Nicolas Grekas
a0364bc3eb minor #22757 [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0 (ogizanagi)
This PR was merged into the 3.3 branch.

Discussion
----------

[Security][Serializer][DI] Add new arguments typehints in preparation for 4.0

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/22743#pullrequestreview-38950305
| License       | MIT
| Doc PR        | N/A

See https://github.com/symfony/symfony/pull/22743#pullrequestreview-38950305 discussion for the motivations.

Commits
-------

b973b30 [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0
2017-05-21 10:47:05 +02:00
Nicolas Grekas
8529e02879 minor #22810 [DI] Added missing deprecation in changelog (ro0NL)
This PR was merged into the 3.2 branch.

Discussion
----------

[DI] Added missing deprecation in changelog

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

See #20113

Commits
-------

b3d58c5 [DI] Added missing deprecation in changelog
2017-05-21 10:40:13 +02:00
Christian Flothmann
f20885eefe do not used deprecated validator test case class 2017-05-21 09:57:21 +02:00
Christian Flothmann
a920274709 do not mock a deprecated interface 2017-05-21 09:39:50 +02:00
Roland Franssen
b3d58c54a4 [DI] Added missing deprecation in changelog 2017-05-20 22:16:10 +02:00
Nicolas Grekas
da61abdf20 feature #22794 [ExpressionLanguage] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[ExpressionLanguage] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

37ac945 [ExpressionLanguage] remove deprecated features
2017-05-20 16:09:16 +02:00
Christian Flothmann
37ac9457c9 [ExpressionLanguage] remove deprecated features 2017-05-20 16:03:23 +02:00
Christian Flothmann
5bdda6ce74 [Ldap] add a changelog file 2017-05-20 15:43:53 +02:00
Maxime Steinhausser
b973b3072a [Security][Serializer][DI] Add new arguments typehints in preparation for 4.0 2017-05-20 12:13:18 +02:00
Nicolas Grekas
5ed9cb316e feature #22779 [4.0][BC Break] Removed BC layers for ControllerResolver::getArguments() (iltar)
This PR was squashed before being merged into the 4.0-dev branch (closes #22779).

Discussion
----------

[4.0][BC Break] Removed BC layers for ControllerResolver::getArguments()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Removes the Backwards Compatibility layer for the `ControllerResolver` that depends on the `ArgumentValueResolver`. ~~There's still 1 bit left in the `HttpKernel`, but I don't quite know how this is solved in the best way:~~

```php
    public function __construct(EventDispatcherInterface $dispatcher, ControllerResolverInterface $resolver, RequestStack $requestStack = null, ArgumentResolverInterface $argumentResolver = null)
    {
        $this->dispatcher = $dispatcher;
        $this->resolver = $resolver;
        $this->requestStack = $requestStack ?: new RequestStack();
        $this->argumentResolver = $argumentResolver;

        if (null === $this->argumentResolver) {
            @trigger_error(sprintf('As of 3.1 an %s is used to resolve arguments. In 4.0 the $argumentResolver becomes the %s if no other is provided instead of using the $resolver argument.', ArgumentResolverInterface::class, ArgumentResolver::class), E_USER_DEPRECATED);
            // fallback in case of deprecations
            $this->argumentResolver = $resolver;
        }
    }
```

~~The 4th argument is now mandatory, but I can't make it mandatory without switching it with the request stack.~~
 - ~~I can make both mandatory~~
 - ~~I can make it `?RequestStack`~~
 - ~~I can switch the arguments~~

~~Each of those area a BC break but for the request stack or the switch, there is no BC layer yet (could be done in 3.4).~~

Commits
-------

64ac6e5 [4.0][BC Break] Removed BC layers for ControllerResolver::getArguments()
2017-05-20 12:00:07 +02:00
Iltar van der Berg
64ac6e5d1f [4.0][BC Break] Removed BC layers for ControllerResolver::getArguments() 2017-05-20 12:00:05 +02:00
Nicolas Grekas
d1aede93aa minor #22744 [Serializer] Remove a now useless call to method_exists (dunglas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Serializer] Remove a now useless call to method_exists

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a
<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

6425f85 [Serializer] Remove a now useless call to method_exists
2017-05-20 11:49:19 +02:00
Nicolas Grekas
d25d340e36 minor #22747 [DependencyInjection] Remove dead code with PHP 7+ (dunglas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DependencyInjection] Remove dead code with PHP 7+

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

372e96e [DependencyInjection] Remove dead code with PHP 7+
2017-05-20 11:47:39 +02:00
Nicolas Grekas
628ec8118e minor #22748 [Intl] Fix bin/common.php PHP7 compatibility (ondrejfuhrer)
This PR was squashed before being merged into the 2.7 branch (closes #22748).

Discussion
----------

[Intl] Fix bin/common.php PHP7 compatibility

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22735
| License       | MIT

Created for Symfony 2.7 version which is the oldest maintained impacted branch.

Commits
-------

c2ccf36 [Intl] Fix bin/common.php PHP7 compatibility
2017-05-20 11:41:39 +02:00
Ondřej Führer
c2ccf36040 [Intl] Fix bin/common.php PHP7 compatibility 2017-05-20 11:41:38 +02:00
meyerbaptiste
c2db0c14e1 [DependencyInjection] Fix dumping of RewindableGenerator with empty IteratorArgument 2017-05-19 23:56:58 +02:00
Fabien Potencier
79bc3275db feature #22782 [Debug][VarDumper] Remove the symfony_debug C extension (nicolas-grekas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Debug][VarDumper] Remove the symfony_debug C extension

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

f9c51a6098 [Debug][VarDumper] Remove the symfony_debug C extension
2017-05-19 22:56:51 +02:00
Nicolas Grekas
f9c51a6098 [Debug][VarDumper] Remove the symfony_debug C extension 2017-05-19 19:05:40 +02:00
Grégoire Pineau
1ccbe0bae2 [Workflow] Removed class name support in WorkflowRegistry::add() as second parameter 2017-05-19 17:59:15 +02:00
Nicolas Grekas
31f74cad43 Merge branch '3.4'
* 3.4:
  typo
  CI fixes
  Improved how profiler errors are dispalyed on small screens
  bumped Symfony version to 3.3.0
  updated VERSION for 3.3.0-RC1
  updated CHANGELOG for 3.3.0-RC1
2017-05-19 14:18:36 +02:00
Nicolas Grekas
e9e19e7f4d Merge branch '3.3' into 3.4
* 3.3:
  typo
  CI fixes
  Improved how profiler errors are dispalyed on small screens
  bumped Symfony version to 3.3.0
  updated VERSION for 3.3.0-RC1
  updated CHANGELOG for 3.3.0-RC1
2017-05-19 14:13:29 +02:00
Nicolas Grekas
7938fdeceb Merge branch '3.2' into 3.3
* 3.2:
  typo
  CI fixes
  Improved how profiler errors are dispalyed on small screens
2017-05-19 14:13:17 +02:00
Nicolas Grekas
f154e67000 Merge branch '2.8' into 3.2
* 2.8:
  CI fixes
  Improved how profiler errors are dispalyed on small screens
2017-05-19 14:10:04 +02:00
Nicolas Grekas
f7b3252cc1 Merge branch '2.7' into 2.8
* 2.7:
  CI fixes
2017-05-19 13:49:58 +02:00
Hugo Hamon
854efce7ca [DependencyInjection] remove deprecated YAML configuration features and syntax 2017-05-19 10:55:44 +02:00
Maxime Steinhausser
fab0629206 [Intl] Fix intl tests for PHP < 5.5.10 2017-05-19 08:06:36 +02:00
Nicolas Grekas
a34b8ce2df CI fixes 2017-05-18 17:56:45 +02:00
Robin Chalas
3230fc7e70 Fix kernel.project_dir extensibility 2017-05-18 16:23:46 +02:00
Kévin Dunglas
372e96e157
[DependencyInjection] Remove dead code with PHP 7+ 2017-05-18 16:14:41 +02:00
Kévin Dunglas
b346e48adf
[PropertyInfo] Remove dead code with PHP 7+ 2017-05-18 16:14:10 +02:00
Kévin Dunglas
6425f8551a
[Serializer] Remove a now useless call to method_exists 2017-05-18 16:12:58 +02:00
Kévin Dunglas
be951b7096
[Serializer] Remove deprecated DoctrineCache support 2017-05-18 16:12:18 +02:00
Nicolas Grekas
4758c2c7b5 Tweak travis and appveyor for Symfony 4 2017-05-18 15:50:33 +02:00
Fabien Potencier
c850733703 bumped minimum version to PHP 7.1 2017-05-18 14:57:29 +02:00
Nicolas Grekas
cd69fc185e Merge branch '3.4'
* 3.4:
  Allow individual bridges, bundles and components to be used with 4.0
2017-05-18 14:56:38 +02:00
Kévin Dunglas
bcc408cfad Allow individual bridges, bundles and components to be used with 4.0 2017-05-18 14:56:12 +02:00
Jérémy Marodon
aa223f5c6c Fix the kernel version of 4.0 2017-05-18 10:33:55 +02:00
Fabien Potencier
98021ae918 bumped Symfony version to 3.3.0 2017-05-17 20:35:24 +02:00
Fabien Potencier
297a65dbe8 updated VERSION for 3.3.0-RC1 2017-05-17 20:09:50 +02:00
Fabien Potencier
d8594de9c6 updated version to 4.0 2017-05-17 18:33:00 +02:00
Fabien Potencier
7b59412301 updated version to 3.4 2017-05-17 18:21:40 +02:00
Fabien Potencier
1bbc35a34a Merge branch '3.2'
* 3.2:
  removed unneeded annotation in tests
  [Intl][Form] Update tests, TimeZoneTransformer, and DateTimeToLocalizedStringTransformer for the GMT and UTC split in ICU
  remove Security deps from the require section
  [Intl] Update ICU data to 59.1
2017-05-15 08:17:59 -07:00
Fabien Potencier
94871fac80 removed unneeded annotation in tests 2017-05-15 08:15:28 -07:00