Commit Graph

31882 Commits

Author SHA1 Message Date
Nicolas Grekas
05e3332fe2 bug #23459 [TwigBundle] allow to configure custom formats in XML configs (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] allow to configure custom formats in XML configs

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13554
| License       | MIT
| Doc PR        |

Commits
-------

5a3a24b allow to configure custom formats in XML configs
2017-07-11 08:56:31 +02:00
Nicolas Grekas
26ad2ad400 bug #23460 Don't display the Symfony debug toolbar when printing the page (javiereguiluz)
This PR was squashed before being merged into the 2.8 branch (closes #23460).

Discussion
----------

Don't display the Symfony debug toolbar when printing the page

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23303
| License       | MIT
| Doc PR        | -

Commits
-------

ca3ff88 Don't display the Symfony debug toolbar when printing the page
2017-07-11 08:54:59 +02:00
Javier Eguiluz
ca3ff88361 Don't display the Symfony debug toolbar when printing the page 2017-07-11 08:54:57 +02:00
Nicolas Grekas
7fd523678a bug #23469 [FrameworkBundle] do not wire namespaces for the ArrayAdapter (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] do not wire namespaces for the ArrayAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23214
| License       | MIT
| Doc PR        |

Commits
-------

9380614 do not wire namespaces for the ArrayAdapter
2017-07-11 08:48:27 +02:00
Nicolas Grekas
2fc9bd2f99 minor #23446 [Cache] Added test for ApcuAdapter when using in CLI (lyrixx)
This PR was merged into the 3.2 branch.

Discussion
----------

[Cache] Added test for ApcuAdapter when using in CLI

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23344
| License       | MIT
| Doc PR        | -

---

I also hit #23344 and I did not notice it was already fixed (#23390) and released (2 days ago, I updated the vendors 4 days ago :trollface: ). But as I have written test for it ... Let's contribute anyway

Commits
-------

64d196a [Cache] Added test for ApcuAdapter when using in CLI
2017-07-11 08:33:12 +02:00
Christian Flothmann
9380614de9 do not wire namespaces for the ArrayAdapter 2017-07-10 19:31:39 +02:00
Alessandro Chitolina
0b349aee18
check _controller attribute is a string before parsing it 2017-07-10 18:12:17 +02:00
Grégoire Pineau
64d196adae [Cache] Added test for ApcuAdapter when using in CLI 2017-07-10 18:11:13 +02:00
Nicolas Grekas
754d3a7568 [HttpKernel][VarDumper] Truncate profiler data & optim perf 2017-07-10 16:18:27 +02:00
Nicolas Grekas
195d949e6b minor #23458 [HttpKernel] fix DumpDataCollector tests (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[HttpKernel] fix DumpDataCollector tests

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

to reflect the changes from #23413

Commits
-------

5dbee5b [HttpKernel] fix DumpDataCollector tests
2017-07-10 11:30:54 +02:00
Christian Flothmann
5a3a24b0ac allow to configure custom formats in XML configs 2017-07-09 16:08:05 +02:00
Christian Flothmann
5dbee5b5bd [HttpKernel] fix DumpDataCollector tests 2017-07-09 14:41:10 +02:00
Christian Flothmann
b033e79211 [FrameworkBundle] fix changelog
The `framework.serializer.cache` option was also deprecated in Symfony
3.1. This was documented in the upgrade file, but was not reflected in
the bundle's changelog.
2017-07-09 12:28:17 +02:00
Roland Franssen
8a197958cb [WebProfilerBundle] Cleanup profiler leftover 2017-07-08 21:14:51 +02:00
Roland Franssen
595a225a0f [DI] Remove irrelevant comment from container 2017-07-08 10:35:50 +02:00
Fabien Potencier
c3ec5c5361 bug #23434 [DotEnv] Fix variable substitution (brieucthomas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DotEnv] Fix variable substitution

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23423
| License       | MIT
| Doc PR        | no

Commits
-------

1dfcdc7000 [DotEnv] Fix variable substitution
2017-07-06 15:57:36 +03:00
Tobias Schultze
c7c5ba8946 [TwigBridge] cleaner implementation of the TwigRenderer 2017-07-06 14:34:37 +02:00
Brieuc Thomas
1dfcdc7000 [DotEnv] Fix variable substitution 2017-07-06 14:23:24 +02:00
Fabien Potencier
71c6f9962b bug #23426 Fixed HttpOnly flag when using Cookie::fromString() (Toflar)
This PR was merged into the 3.3 branch.

Discussion
----------

Fixed HttpOnly flag when using Cookie::fromString()

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23424
| License       | MIT
| Doc PR        | -

Using `Cookie::fromString()` should not set the `HttpOnly` flag to `true` by default. This is a factory method and it should create an instance of `Cookie` that represents exactly what the string contains.

Commits
-------

73187d0003 Preserve HttpOnly value when deserializing a header
2017-07-06 12:19:04 +03:00
Fabien Potencier
3c9958cbc3 minor #23421 require the XML PHP extension (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

require the XML PHP extension

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/22676#issuecomment-300434331, symfony/symfony-standard#1099
| License       | MIT
| Doc PR        |

I suggest to either revert #22676 or to be consistent and require the XML extension in all bundles as well as in the `symfony/symfony` package.

Commits
-------

032e654acb require the XML PHP extension
2017-07-06 12:12:33 +03:00
Yanick Witschi
73187d0003 Preserve HttpOnly value when deserializing a header
The specification states that the cookie should be considered http only if and
only if the flag is present.
See https://www.owasp.org/index.php/HttpOnly
2017-07-06 11:04:09 +02:00
Christian Flothmann
032e654acb require the XML PHP extension 2017-07-06 10:51:23 +02:00
Fabien Potencier
48bb1953b9 minor #23422 [Ldap] Fix deprecated message (maidmaid)
This PR was merged into the 3.3 branch.

Discussion
----------

[Ldap] Fix deprecated message

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20390 https://github.com/symfony/symfony/pull/23402
| License       | MIT
| Doc PR        | /

``RenameEntryInterface`` is **deprecated** in 3.3 and **removed/merged** in 4.0.

Commits
-------

bbd0c7f69f Fix deprecated message
2017-07-06 10:41:24 +03:00
Fabien Potencier
de820d189c minor #22231 [DX] Fix phpdoc for serializer normalizers exceptions (Nek-)
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #22231).

Discussion
----------

[DX] Fix phpdoc for serializer normalizers exceptions

The normalizers throw exceptions. They need to be documented for DX in the normalizer/denormalizer interfaces.

| Q             | A
| ------------- | ---
| Branch?       | master (rebase on 2.7 if you want?)
| Bug fix?      | no
| New feature?  | yes?
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22218
| License       | MIT
| Doc PR        | Not needed

Commits
-------

ec3cc84656 Fix phpdoc for serializer normalizers exceptions
2017-07-06 10:40:01 +03:00
Maxime Veber
ec3cc84656 Fix phpdoc for serializer normalizers exceptions
The normalizers throw exceptions. They need to be documented for DX
in the normalizer/denormalizer interfaces.

[Serializer] fit Symfony phpdoc standard

It also adds meaning of each exception throw.

Fix grammary in phpdoc
2017-07-06 10:39:51 +03:00
Fabien Potencier
626e9875a2 bug #22439 [DX] [TwigBundle] Enhance the new exception page design (sustmi)
This PR was squashed before being merged into the 3.3 branch (closes #22439).

Discussion
----------

[DX] [TwigBundle] Enhance the new exception page design

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

- [x] Fix the problem with wrapping wide lines (https://github.com/symfony/symfony/pull/20951#issuecomment-292201983)

I got motivated by recent PR https://github.com/symfony/symfony/pull/20951 and redesigned the exception page even more.

Compare before: ![before](https://cloud.githubusercontent.com/assets/885946/25052220/0756b74e-2151-11e7-98b6-c99fd9eaabec.png)
with after: ![after](https://cloud.githubusercontent.com/assets/885946/25052225/0c76581a-2151-11e7-96ff-eb502ee8e97b.png)
(Ignore the the "sf" toolbar icon in the middle of the page. This is how Firefox does full-page screenshots.)

The most noticeable changes:
- removed double line spacing (it just does not feel natural)
- file context increased from 3 to 10 lines (it helps me to better orientate in the code)
- added horizontal scrollbar for the cases when the code is wider
- the highlighted line color is more saturated in order to be noticed easily

Commits
-------

43212b9a90 [DX] [TwigBundle] Enhance the new exception page design
2017-07-06 10:10:35 +03:00
Miroslav Sustek
43212b9a90 [DX] [TwigBundle] Enhance the new exception page design 2017-07-06 10:10:33 +03:00
Dany Maillard
bbd0c7f69f Fix deprecated message 2017-07-06 09:08:20 +02:00
Fabien Potencier
7e93ccad3f Merge branch '3.2' into 3.3
* 3.2:
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
2017-07-06 09:25:00 +03:00
Fabien Potencier
15938b4ffd bug #23417 [DI][Security] Prevent unwanted deprecation notices when using Expression Languages (dunglas)
This PR was merged into the 3.2 branch.

Discussion
----------

[DI][Security] Prevent unwanted deprecation notices when using Expression Languages

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

052b8c3a04 [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
2017-07-06 09:23:57 +03:00
Fabien Potencier
4e2a404f03 bug #23261 Fixed absolute url generation for query strings and hash urls (alexander-schranz)
This PR was squashed before being merged into the 2.7 branch (closes #23261).

Discussion
----------

Fixed absolute url generation for query strings and hash urls

| Q             | A
| ------------- | ---
| Branch?       | 2.7, ...
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | yes? absolute_url will change its output but the old was incorrect
| Deprecations? |no
| Tests pass?   | yes?
| Fixed tickets | fixes #23260
| License       | MIT

Fixed absolute url generation for query strings

Commits
-------

89ad27d544 Fixed absolute url generation for query strings and hash urls
2017-07-06 09:01:21 +03:00
Alexander Schranz
89ad27d544 Fixed absolute url generation for query strings and hash urls 2017-07-06 09:01:12 +03:00
Kévin Dunglas
052b8c3a04
[DI][Security] Prevent unwanted deprecation notices when using Expression Languages 2017-07-05 22:19:23 +02:00
Fabien Potencier
311e627828 bug #23398 [Filesystem] Dont copy perms when origin is remote (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Filesystem] Dont copy perms when origin is remote

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23312
| License       | MIT
| Doc PR        | -

Commits
-------

7b442211dc [Filesystem] Dont copy perms when origin is remote
2017-07-05 17:24:07 +03:00
Fabien Potencier
94b6ec3092 bumped Symfony version to 3.3.5 2017-07-05 16:59:31 +03:00
Fabien Potencier
82f7cba3c2 Merge pull request #23414 from fabpot/release-3.3.4
released v3.3.4
2017-07-05 16:28:34 +03:00
Fabien Potencier
e81d5d17d6 updated VERSION for 3.3.4 2017-07-05 16:28:15 +03:00
Fabien Potencier
a7c9d1aca0 updated CHANGELOG for 3.3.4 2017-07-05 16:28:05 +03:00
Fabien Potencier
3e84f7d91d bug #23413 [VarDumper] Reduce size of serialized Data objects (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[VarDumper] Reduce size of serialized Data objects

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #23233
| License       | MIT
| Doc PR        | -

By using `Stub` objects a lot, especially for arrays, `Data` objects generate heavy serialized strings.
By implemeting `Serializable` on `Data`, this PR removes most of the boilerplate.

This PR also removes duplicate data in `LoggerDataCollector`, and reduces the backtrace of silenced errors to their 3 last items - which should be enough - and is otherwise responsible for a significant portion of the serialized payloads.

This is not the last possible step towards shrinking serialized profiles, but the next one is more complex -and maybe this one is good enough? Please give feedback if you can.

Commits
-------

70bd2bc41b [VarDumper] Reduce size of serialized Data objects
2017-07-05 16:24:26 +03:00
Nicolas Grekas
70bd2bc41b [VarDumper] Reduce size of serialized Data objects 2017-07-05 16:02:37 +03:00
Robin Chalas
64c2efd8cb [Security] Fix authentication.failure event not dispatched on AccountStatusException 2017-07-05 14:02:28 +02:00
Fabien Potencier
692acb4d64 bumped Symfony version to 3.2.12 2017-07-05 13:46:19 +03:00
Fabien Potencier
697ece8d9a Merge pull request #23408 from fabpot/release-3.2.11
released v3.2.11
2017-07-05 13:25:23 +03:00
Fabien Potencier
99e70b8cc0 updated VERSION for 3.2.11 2017-07-05 12:51:47 +03:00
Fabien Potencier
0cd605bdea updated CHANGELOG for 3.2.11 2017-07-05 12:51:40 +03:00
Fabien Potencier
15df829a83 bumped Symfony version to 2.8.25 2017-07-05 12:39:23 +03:00
Fabien Potencier
0ab3693b11 Merge pull request #23401 from fabpot/release-2.8.24
released v2.8.24
2017-07-05 11:53:15 +03:00
Fabien Potencier
bf1be0e08f updated VERSION for 2.8.24 2017-07-05 11:52:59 +03:00
Fabien Potencier
09797de757 updated CHANGELOG for 2.8.24 2017-07-05 11:52:53 +03:00
Fabien Potencier
39fc4ddec7 bumped Symfony version to 2.7.32 2017-07-05 11:52:01 +03:00