Commit Graph

25617 Commits

Author SHA1 Message Date
Alessandro Chitolina
0b349aee18
check _controller attribute is a string before parsing it 2017-07-10 18:12:17 +02:00
Fabien Potencier
c3ec5c5361 bug #23434 [DotEnv] Fix variable substitution (brieucthomas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DotEnv] Fix variable substitution

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23423
| License       | MIT
| Doc PR        | no

Commits
-------

1dfcdc7000 [DotEnv] Fix variable substitution
2017-07-06 15:57:36 +03:00
Brieuc Thomas
1dfcdc7000 [DotEnv] Fix variable substitution 2017-07-06 14:23:24 +02:00
Yanick Witschi
73187d0003 Preserve HttpOnly value when deserializing a header
The specification states that the cookie should be considered http only if and
only if the flag is present.
See https://www.owasp.org/index.php/HttpOnly
2017-07-06 11:04:09 +02:00
Fabien Potencier
48bb1953b9 minor #23422 [Ldap] Fix deprecated message (maidmaid)
This PR was merged into the 3.3 branch.

Discussion
----------

[Ldap] Fix deprecated message

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/20390 https://github.com/symfony/symfony/pull/23402
| License       | MIT
| Doc PR        | /

``RenameEntryInterface`` is **deprecated** in 3.3 and **removed/merged** in 4.0.

Commits
-------

bbd0c7f69f Fix deprecated message
2017-07-06 10:41:24 +03:00
Fabien Potencier
626e9875a2 bug #22439 [DX] [TwigBundle] Enhance the new exception page design (sustmi)
This PR was squashed before being merged into the 3.3 branch (closes #22439).

Discussion
----------

[DX] [TwigBundle] Enhance the new exception page design

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

- [x] Fix the problem with wrapping wide lines (https://github.com/symfony/symfony/pull/20951#issuecomment-292201983)

I got motivated by recent PR https://github.com/symfony/symfony/pull/20951 and redesigned the exception page even more.

Compare before: ![before](https://cloud.githubusercontent.com/assets/885946/25052220/0756b74e-2151-11e7-98b6-c99fd9eaabec.png)
with after: ![after](https://cloud.githubusercontent.com/assets/885946/25052225/0c76581a-2151-11e7-96ff-eb502ee8e97b.png)
(Ignore the the "sf" toolbar icon in the middle of the page. This is how Firefox does full-page screenshots.)

The most noticeable changes:
- removed double line spacing (it just does not feel natural)
- file context increased from 3 to 10 lines (it helps me to better orientate in the code)
- added horizontal scrollbar for the cases when the code is wider
- the highlighted line color is more saturated in order to be noticed easily

Commits
-------

43212b9a90 [DX] [TwigBundle] Enhance the new exception page design
2017-07-06 10:10:35 +03:00
Miroslav Sustek
43212b9a90 [DX] [TwigBundle] Enhance the new exception page design 2017-07-06 10:10:33 +03:00
Dany Maillard
bbd0c7f69f Fix deprecated message 2017-07-06 09:08:20 +02:00
Fabien Potencier
7e93ccad3f Merge branch '3.2' into 3.3
* 3.2:
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
2017-07-06 09:25:00 +03:00
Kévin Dunglas
052b8c3a04
[DI][Security] Prevent unwanted deprecation notices when using Expression Languages 2017-07-05 22:19:23 +02:00
Fabien Potencier
94b6ec3092 bumped Symfony version to 3.3.5 2017-07-05 16:59:31 +03:00
Fabien Potencier
e81d5d17d6 updated VERSION for 3.3.4 2017-07-05 16:28:15 +03:00
Nicolas Grekas
70bd2bc41b [VarDumper] Reduce size of serialized Data objects 2017-07-05 16:02:37 +03:00
Fabien Potencier
692acb4d64 bumped Symfony version to 3.2.12 2017-07-05 13:46:19 +03:00
Fabien Potencier
99e70b8cc0 updated VERSION for 3.2.11 2017-07-05 12:51:47 +03:00
Fabien Potencier
bef2142071 bug #23385 [DoctrineBridge] Fix resetting entity managers with case sensitive id (chalasr)
This PR was merged into the 3.3 branch.

Discussion
----------

[DoctrineBridge] Fix resetting entity managers with case sensitive id

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

9737bcc024 [DoctrineBridge] Use normalizedIds for resetting entity manager services
2017-07-05 09:55:44 +03:00
Fabien Potencier
57684240c4 Merge branch '3.2' into 3.3
* 3.2:
  Fix indent of methods
2017-07-05 09:51:27 +03:00
Fabien Potencier
f3cba17b29 Merge branch '2.8' into 3.2
* 2.8:
  Fix indent of methods
2017-07-05 09:50:55 +03:00
Fabien Potencier
442058dc61 Merge branch '2.7' into 2.8
* 2.7:
  Fix indent of methods
2017-07-05 09:50:35 +03:00
Nicolas Grekas
56f72d7f8f Merge branch '3.2' into 3.3
* 3.2:
  fixed bad merge
  [Cache] Handle APCu failures gracefully
  [FrameworkBundle] Do not remove files from assets dir
  bumped Symfony version to 3.2.11
  updated VERSION for 3.2.10
  updated CHANGELOG for 3.2.10
  bumped Symfony version to 2.8.24
  updated VERSION for 2.8.23
  updated CHANGELOG for 2.8.23
  bumped Symfony version to 2.7.31
  updated VERSION for 2.7.30
  update CONTRIBUTORS for 2.7.30
  updated CHANGELOG for 2.7.30
2017-07-05 09:39:29 +03:00
Fabien Potencier
d879eed12a fixed bad merge 2017-07-05 09:33:38 +03:00
Fabien Potencier
285a6ac36d Merge branch '2.8' into 3.2
* 2.8:
  [FrameworkBundle] Do not remove files from assets dir
  bumped Symfony version to 2.8.24
  updated VERSION for 2.8.23
  updated CHANGELOG for 2.8.23
  bumped Symfony version to 2.7.31
  updated VERSION for 2.7.30
  update CONTRIBUTORS for 2.7.30
  updated CHANGELOG for 2.7.30
2017-07-05 09:33:08 +03:00
Fabien Potencier
ecaae2368d Merge branch '2.7' into 2.8
* 2.7:
  [FrameworkBundle] Do not remove files from assets dir
  bumped Symfony version to 2.7.31
  updated VERSION for 2.7.30
  update CONTRIBUTORS for 2.7.30
  updated CHANGELOG for 2.7.30
2017-07-05 09:32:23 +03:00
Dariusz
58ba4818a6 Fix indent of methods 2017-07-04 23:00:55 +02:00
Nicolas Grekas
47020c4904 [Cache] Handle APCu failures gracefully 2017-07-04 18:20:09 +03:00
Robin Chalas
9737bcc024 [DoctrineBridge] Use normalizedIds for resetting entity manager services 2017-07-04 14:04:47 +02:00
Gábor Egyed
6ed9c8d8c5 [FrameworkBundle] Do not remove files from assets dir 2017-07-04 11:39:25 +02:00
Maxime Steinhausser
c75e486413 [FrameworkBundle] 3.3: Don't get() private services from debug:router 2017-07-04 09:43:54 +02:00
Fabien Potencier
5de56eba9a bumped Symfony version to 3.3.4 2017-07-04 09:15:40 +03:00
Fabien Potencier
5d8d746a10 updated VERSION for 3.3.3 2017-07-04 09:02:59 +03:00
Fabien Potencier
ddc9d2e313 bumped Symfony version to 3.2.11 2017-07-04 09:01:46 +03:00
Fabien Potencier
af3fcc11ed updated VERSION for 3.2.10 2017-07-04 08:45:03 +03:00
Fabien Potencier
d011d57f81 bumped Symfony version to 2.8.24 2017-07-04 08:43:52 +03:00
Fabien Potencier
f9b4223990 updated VERSION for 2.8.23 2017-07-04 08:31:02 +03:00
Fabien Potencier
8b1f4127c3 Merge branch '3.2' into 3.3
* 3.2:
  Don't access private services from container aware commands (deprecated)
  Improve CircularReferenceException message
2017-07-04 08:29:22 +03:00
Fabien Potencier
04baf86525 Merge branch '2.8' into 3.2
* 2.8:
  Improve CircularReferenceException message
2017-07-04 08:27:49 +03:00
Robin Chalas
08a6178e77 Don't access private services from container aware commands (deprecated) 2017-07-04 01:09:03 +02:00
Fabien Potencier
fa6b45bc58 bumped Symfony version to 2.7.31 2017-07-03 18:37:36 +03:00
Nicolas Grekas
966662dc4d bug #23239 [FrameworkBundle] call setContainer() for autowired controllers (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] call setContainer() for autowired controllers

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23200, FriendsOfSymfony/FOSRestBundle#1719
| License       | MIT
| Doc PR        |

Previously, you either did not use controllers as services or you explicitly wired everything yourself. In case of a non-service controller the FrameworkBundle took care of calling `setContainer()` inside the `instantiateController()` method:

```php
protected function instantiateController($class)
{
    $controller = parent::instantiateController($class);

    if ($controller instanceof ContainerAwareInterface) {
        $controller->setContainer($this->container);
    }
    if ($controller instanceof AbstractController && null !== $previousContainer = $controller->setContainer($this->container)) {
        $controller->setContainer($previousContainer);
    }

    return $controller;
}
```

With the new autowired controllers as services this is no longer happening as controllers do not need to be instantiated anymore (the container already returns fully built objects).

Commits
-------

1d07a28 call setContainer() for autowired controllers
2017-07-03 17:51:37 +03:00
Fabien Potencier
75443d232b updated VERSION for 2.7.30 2017-07-03 17:22:50 +03:00
Christian Flothmann
1d07a28bed call setContainer() for autowired controllers 2017-07-03 16:15:38 +02:00
Fabien Potencier
a40b29b05e Merge branch '3.2' into 3.3
* 3.2:
  gracefully handle missing hinclude renderer
2017-07-03 17:10:11 +03:00
Fabien Potencier
26c5fc0732 Merge branch '2.7' into 2.8
* 2.7:
  Improve CircularReferenceException message
2017-07-03 17:09:54 +03:00
Robin Chalas
3ddb6e6aad [Console] Fix descriptor tests 2017-07-03 15:19:36 +02:00
Thomas Perez
3a529e3391 Improve CircularReferenceException message 2017-07-03 15:09:40 +02:00
Christian Flothmann
ebdbecfb8b gracefully handle missing hinclude renderer 2017-07-03 11:37:02 +02:00
Fabien Potencier
3169e12bbf bug #23351 [Dotenv] parse concatenated variable values (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Dotenv] parse concatenated variable values

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23306
| License       | MIT
| Doc PR        |

Commits
-------

aaaf64ddde [Dotenv] parse concatenated variable values
2017-07-03 12:28:08 +03:00
Fabien Potencier
9260a7ba03 Merge branch '3.2' into 3.3
* 3.2:
  Misspelled word
  Display a better error design when the toolbar cannot be displayed
  do not validate empty values
  [Cache] fix cleanup of expired items for PdoAdapter
  [Console] fix description of INF default values
  [PropertyAccess] Fix TypeError discard
  [Validator] Throw exception on Comparison constraints null options
  Identify tty tests in Component/Process
  [Workflow] Added more events to the announce function
  [Validator] Remove property path suggestion for using the Expression validator
  [WebProfilerBundle] Fix css trick used for offsetting html anchor from fixed header
  [Security] Fix annotation
2017-07-03 11:12:02 +03:00
Fabien Potencier
d051ef42b3 Merge branch '2.8' into 3.2
* 2.8:
  Misspelled word
  Display a better error design when the toolbar cannot be displayed
  do not validate empty values
  [Console] fix description of INF default values
  [PropertyAccess] Fix TypeError discard
  [Validator] Throw exception on Comparison constraints null options
  Identify tty tests in Component/Process
  [Security] Fix annotation
2017-07-03 11:06:20 +03:00
Fabien Potencier
2f8eeed5df Merge branch '2.7' into 2.8
* 2.7:
  Misspelled word
  Display a better error design when the toolbar cannot be displayed
  do not validate empty values
  [Console] fix description of INF default values
  [PropertyAccess] Fix TypeError discard
  [Validator] Throw exception on Comparison constraints null options
  Identify tty tests in Component/Process
  [Security] Fix annotation
2017-07-03 11:04:30 +03:00