This PR was merged into the 5.3-dev branch.
Discussion
----------
[Mailer] Move CHANGELOG entry
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
This entry belongs to the bridge, not the component
Commits
-------
4c0f078c91 [Mailer] Move CHANGELOG entry
Bootstraps allows to translate the label of the button of a custom-file
input with SCSS variables depending on the lang attribute of the
*input*.
This attribute was set on the label instead and thus had no effect.
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Config] Remove unused sprintf + coding standards
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
A few things I noticed, redundant `sprintf` and variable and coding standards.
Commits
-------
17479e2bb5 Minor code cleanup
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Translation] [Loco] Remove SCHEME const
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
For consistency, we do it this way in mailer and notifier
cc `@welcoMattic`
Commits
-------
34be4a5120 [Translation] [Loco] Remove SCHEME const
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Config] [ConfigBuilder] Set FQCN as properties type instead of class name
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40921
| License | MIT
| Doc PR | N/A
Commits
-------
e9aa1c5771 [Config] [ConfigBuilder] Set FQCN as properties type instead of class name
This PR was merged into the 5.2 branch.
Discussion
----------
[DoctrineBridge] run tests against doctrine/persistence 2.1
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
c8916f20b3 run tests against doctrine/persistence 2.1
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] DataPart: remove confusing fix-me comment
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I don't think this comment is correct? There is an exception thrown [below](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mime/Part/DataPart.php#L60).
Commits
-------
72493c6acf [Mime] DataPart: remove confusing fix-me comment
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Translation] [Loco] Simplify namespace
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | ---
Based on https://github.com/symfony/symfony/pull/40945#discussion_r620058173 (`@nicolas`-grekas )
Commits
-------
e6af3c2572 [Translation] [Loco] Simplify namespace
This PR was merged into the 5.3-dev branch.
Discussion
----------
[CI] Sort packages by length to match modified package better
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Given the build error in #40927, I saw that we match "modified packages" wrong. The script things we modified `symfony/translation` rather than the new bridge. This is because we are using a simple [string matchning](18658a29a3/.github/get-modified-packages.php (L24)). If we sort the packages by length, we make sure we match the most detailed (longest) string first.
Commits
-------
f7a0bd1047 [CI] Sort packages by length to match modified package better
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Translation] Use proven DSN class from Notifier and rename package
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | ---
This class is already in use, no need to introduce it as experimental
cc `@welcoMattic`
Commits
-------
a7979c44de [Translation] Use proven DSN class from Notifier
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Config] Builder: Remove typehints and allow for EnvConfigurator
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes -- maybe
| New feature? | no -- maybe =)
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
When [writing documentation](https://github.com/symfony/symfony-docs/pull/15269#discussion_r617887301) we found that we don't really support environment variables in the leaves. Ie, we expect a boolean but you provide `"%env(ENABLE_FOO)%"`
This PR will also introduce `ParamConfigurator` to allow parameters to be passed as config.
The changes to the generated code:
```diff
/**
+ * `@param` bool|ParamConfigurator $value
* `@default` false
* `@return` $this
*/
- public function enabled(bool $value): self
+ public function enabled($value): self
{
$this->enabled = $value;
return $this;
}
```
Commits
-------
59b79d35a7 [Config] Builder: Remove typehints and allow for EnvConfigurator
This PR was merged into the 5.3-dev branch.
Discussion
----------
[PasswordHasher] fix copy paste typos from UserPasswordEncoderInterface
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
Fix typos introduced when extracting the PasswordHasher component from `UserPasswordEncoderInterface` abeb8e4ca9/src/Symfony/Component/Security/Core/Encoder/UserPasswordEncoderInterface.php (L36)
Discovered in 5.3.0BETA1.
Commits
-------
dfc3584fb7 [PasswordHasher] fix copy paste typos from UserPasswordEncoderInterface
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Translation] [CI] Specify terminal width
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
This is an alternative to #40933. It will force to use 121 (120 max) characters as width.
Commits
-------
d51f7f6a75 [Translation] [CI] Specify terminal width
This PR was submitted for the 5.x branch but it was merged into the 5.2 branch instead.
Discussion
----------
[DependencyInjection] Add missing bool type in procesValue()
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
This method is the only one missing `bool` type. Inside the method is used parent call, that has `bool` type already, so nothing else can be used in it.
Commits
-------
e0f8fe837d [DependencyInjection] Add missing bool type in procesValue()
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[CI] Make sure to restore default locale
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | F
| License | MIT
| Doc PR |
Whenever we have a test that do `\Locale::setDefault()` we must make sure to restore it to the original value.
Commits
-------
a5afe47ccf [CI] Make sure to restore default locale
* 5.2:
make fabbot happy
use correct spelling when accessing the SMTP php.ini value
Fix issue 40507: Tabs as separators between tokens
[Cache] phpredis: Added full TLS support for RedisCluster
[DependencyInjection][AliasDeprecatedPublicServicesPass] Noop when the service is private
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] make fabbot happy
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
9826c05928 make fabbot happy
This PR was merged into the 5.2 branch.
Discussion
----------
[Mailer] use correct spelling when accessing the SMTP php.ini value
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40899
| License | MIT
| Doc PR |
Commits
-------
b6f8ed69ec use correct spelling when accessing the SMTP php.ini value
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] Allow tabs as separators between tokens
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40507
| License | MIT
| Doc PR | None
As described in #40507, the Yaml spec allows tabs as whitespace characters between tokens. However, the Yaml parser crashes on this as it only expects spaces after the colon. https://yaml.org/spec/1.2/spec.html#id2778241
While I'm not a huge fan of it personally, it's an issue when a different linter tells us that a given YAML file with content that we have little control over has valid syntax in an unrelated check, and then our app crashes because it cannot be parsed after all.
Commits
-------
9a130ae93e Fix issue 40507: Tabs as separators between tokens
