* 4.4:
Fix tests
Fix minor typos
[WebProfilerBundle] Fix the values of some CSS properties
[Yaml] Fixed an exception message
Fix ctype_digit deprecation
Add a Special Case for Translating Choices in en_US_POSIX
This PR was merged into the 4.4 branch.
Discussion
----------
Add a Special Case for Translating Choices in en_US_POSIX
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix https://github.com/symfony/symfony/issues/42036 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | n/a <!-- required for new features -->
This adds a special case similar to `pt_BR` for handling `en_US_POSIX`
which is set as the default locale on some operating systems.
~Two tests here might be over the top, not sure.~
Not over the top! One of them caught the same issue in the translation component itself 🎉
Commits
-------
f0bb7a36c5 Add a Special Case for Translating Choices in en_US_POSIX
This PR was merged into the 4.4 branch.
Discussion
----------
Fix ctype_digit deprecation
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Running the Yaml unit tests on PHP 8.1 built: Jul 12 2021 00:22:13 results in the following PHP Notices:
```
Testing /Users/alex/dev/symfony/src/Symfony/Component/Yaml/Tests
............................................................... 63 / 689 ( 9%)
............................................................... 126 / 689 ( 18%)
............................................................... 189 / 689 ( 27%)
............................................................... 252 / 689 ( 36%)
............................................................... 315 / 689 ( 45%)
............................................................... 378 / 689 ( 54%)
............................................................... 441 / 689 ( 64%)
............................................................... 504 / 689 ( 73%)
............................................................... 567 / 689 ( 82%)
............................................................... 630 / 689 ( 91%)
........................................................... 689 / 689 (100%)
Time: 00:00.336, Memory: 20.00 MB
OK (689 tests, 984 assertions)
Unsilenced deprecation notices (131)
109x: ctype_digit(): Argument of type int will be interpreted as string in the future
53x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
21x in DumperTest::testInlineLevel from Symfony\Component\Yaml\Tests
16x in InlineTest::testDump from Symfony\Component\Yaml\Tests
7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysInlined from Symfony\Component\Yaml\Tests
7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysRespectsInlineLevel from Symfony\Component\Yaml\Tests
3x in DumperTest::testIndentationInConstructor from Symfony\Component\Yaml\Tests
1x in DumperTest::testObjectSupportEnabled from Symfony\Component\Yaml\Tests
1x in DumperTest::testObjectSupportDisabledButNoExceptions from Symfony\Component\Yaml\Tests
22x: ctype_digit(): Argument of type float will be interpreted as string in the future
15x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
6x in InlineTest::testDump from Symfony\Component\Yaml\Tests
1x in InlineTest::testDumpNumericValueWithLocale from Symfony\Component\Yaml\Tests
```
Commits
-------
5c57324117 Fix ctype_digit deprecation
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] Fixed an exception message
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I'd prefer to group tiny fixes like this in a single PR, but they are for different branches.
Commits
-------
7036f2f561 [Yaml] Fixed an exception message
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] Fix the values of some CSS properties
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
You can check the valid values of these properties at:
* https://developer.mozilla.org/en-US/docs/Web/CSS/max-width
* https://developer.mozilla.org/en-US/docs/Web/CSS/min-height
Commits
-------
e335c28d44 [WebProfilerBundle] Fix the values of some CSS properties
See https://github.com/symfony/symfony/issues/42036
This adds a special case similar to `pt_BR` for handling `en_US_POSIX`
which is set as the default locale on some operating systems (Alpine
Linux, for instance).
This PR was merged into the 5.2 branch.
Discussion
----------
[FrameworkBundle] Make AbstractDataCollector extend DataCollector to reduce boilerplate
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Partially fixes#41577 (part 1)
| License | MIT
This PR makes `AbstractDataCollector` extend the base `DataCollector` in order to make it even easier to create the data collectors. Currently, developers must implement `__sleep()`, `__wakeup()`, `cloneVar()` etc on their own if they want to use `AbstractDataCollector` instead of the good old `DataCollector` which makes the "boilerplate" even bigger than just adding the `getName()`, `reset()` and `getTemplate()`, making this class less useful than the old one.
Commits
-------
c8ec05d424 make AbstractDataCollector extend DataCollector to reduce boilerplate
* 4.4:
[DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
do not render the same label id attribute twice
This PR was merged into the 4.4 branch.
Discussion
----------
[DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This PR fixes a DX issue with the default recipe: right now, the mapping type has to be explicitly defined. This forces [the default recipe](https://github.com/symfony/recipes/blob/master/doctrine/doctrine-bundle/2.4/config/packages/doctrine.yaml#L15) to stick to "annotation", while the world is moving to "attribute".
Commits
-------
f06f85fbd8 [DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
* 4.4:
do not mock the Request class
do not mock event classes
recover from failed deserializations
[ErrorHandle] Remove a link from the exception page
[Validator] Added Ukrainian translations
[GHA] Clarify some bits in the deps=high script
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[ErrorHandle] Remove a link from the exception page
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This link is causing lots of confusion to some people, who think that we provide free support for open source Symfony projects. That's why we've decided to remove this link. Thanks!
Commits
-------
387254ff5a [ErrorHandle] Remove a link from the exception page
