This PR was merged into the 4.0 branch.
Discussion
----------
Make KernelInterface docblock more fit for bundle-less environment
| Q | A
| ------------- | ---
| Branch? | 4.0
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #26457
| License | MIT
| Doc PR | -
Commits
-------
e8df759f21 Make KernelInterface docblock more fit for bundle-less environment
* 2.7:
Php Inspections (EA Ultimate): address some of one-time used local variables
[Intl] Load locale aliases to support alias fallbacks
[CssSelector] Fix CSS identifiers parsing - they can start with dash
This PR was merged into the 2.7 branch.
Discussion
----------
[minor] SCA with Php Inspections (EA Ultimate)
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n.a
Addressed some cases with one-time used local variables and repetitive calls.
Commits
-------
f16d99ecfa Php Inspections (EA Ultimate): address some of one-time used local variables
This PR was squashed before being merged into the 2.7 branch (closes#26452).
Discussion
----------
[Intl] Load locale aliases to support alias fallbacks
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #21457
| License | MIT
| Doc PR | -
For example, `zh_TW` is an alias to `zh_Hant_TW`. Without aliases,` zh_TW` would fall back to `zh` (which is incorrect). With aliases loaded, `zh_TW` will fall back properly to `zh_Hant_TW`.
Judging by git history this has never worked.
```php
\Locale::setDefault('zh'); dump(Intl::getRegionBundle()->getCountryName('AD'));
\Locale::setDefault('zh_TW'); dump(Intl::getRegionBundle()->getCountryName('AD'));
\Locale::setDefault('zh_Hant_TW'); dump(Intl::getRegionBundle()->getCountryName('AD'));
```
Before:
```
"安道尔"
"安道尔"
"安道爾"
```
After:
```
"安道尔"
"安道爾"
"安道爾"
```
All tests are passing, including those from the `intl-data` group.
Commits
-------
1debf79430 [Intl] Load locale aliases to support alias fallbacks
This PR was merged into the 2.7 branch.
Discussion
----------
[CssSelector] Fix CSS identifiers parsing - they can start with dash
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Vendor prefixes use `-` (dash) at the start of CSS identifiers.
Commits
-------
16e86bc0c0 [CssSelector] Fix CSS identifiers parsing - they can start with dash
This PR was merged into the 3.4 branch.
Discussion
----------
[SecurityBundle] Make extra character non mandatory in regex
The extra character was introduced in 5f9471e, and breaks the testsuite
in native php 7.2.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
44b4fc8 [SecurityBundle] Make extra character non mandatory in regex
This PR was submitted for the master branch but it was squashed and merged into the 4.0 branch instead (closes#26403).
Discussion
----------
fix the handling of timestamp in the MongoDBSessionHandler
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
in the process of upgrading from 3.4 to 4.0 we stumbled upon a issue with mongo session handler.
```
[05-Mar-2018 11:12:57 Europe/Vienna] PHP Fatal error: Uncaught Error: Call to undefined method Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler::createDateTime() in /opt/APP/vendor/symfony/http-foundation/Session/Storage/Handler/MongoDbSessionHandler.php:144
Stack trace:
#0 [internal function]: Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler->updateTimestamp('96d983b59f8aef8...', 'user_obj|O:9:"k...')
#1 [internal function]: session_write_close()
#2 {main}
thrown in /opt/APP/vendor/symfony/http-foundation/Session/Storage/Handler/MongoDbSessionHandler.php on line 144
```
this PR re-add's the method, that somehow got removed in 4.0 branch, whereas the interface forces to have the implemantation.
Commits
-------
97d9ea8269 fix the handling of timestamp in the MongoDBSessionHandler
This PR was merged into the 2.7 branch.
Discussion
----------
Improve the documentation of `Finder::exclude()`
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | no
| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License | MIT
| Doc PR |
Tried to do this and this didn't work:
```php
$iterator->in($sourcePath)
->exclude($sourcePath.'/foo');
```
I read on http://symfony.com/doc/current/components/finder.html that excluded directories need to be relative:
Commits
-------
cc3084ed65 Improve the documentation of `Finder::exclude()`
* 3.4:
[DI] Fix missing "id" normalization when dumping the container
Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md`
