This PR was merged into the 2.2 branch.
Discussion
----------
removed dead code and fixed CS
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
7d58147 removed dead code and fixed CS
This PR was merged into the 2.2 branch.
Discussion
----------
[Validator] Fixed StaticMethodLoader does not try to invoke methods of abstract classes anymore
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8589
| License | MIT
| Doc PR | n/a
Commits
-------
b41cf82 [Validator] fixed StaticMethodLoader trying to invoke methods of abstract classes (closes#8589)
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8581).
Discussion
----------
TimeCollector, Notice, if no events
https://github.com/symfony/symfony/issues/8574
Commits
-------
e9da1c0 return 0 if there is no valid data
This PR was merged into the 2.2 branch.
Discussion
----------
[Tests] Tests on php 5.5 should pass
Because php 5.5 is stable now
Commits
-------
0086ee3 [Tests] Tests on php 5.5 should pass
This PR was merged into the 2.2 branch.
Discussion
----------
[Twig] fixed TwigEngine::exists() method when a template contains a syntax error (closes#8546)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8546
| License | MIT
| Doc PR | n/a
Commits
-------
ae7fa11 [Twig] fixed TwigEngine::exists() method when a template contains a syntax error (closes#88546)
This PR was squashed before being merged into the 2.2 branch (closes#8421).
Discussion
----------
[Validator] fixed ConstraintViolation::$propertyPath incorrect when nested
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8351
| License | MIT
In nested constraints, the property path will be overwritten in the context (as there would be a recursive call to CollectionValidotor when nested). Reason is, in ConstraintValidatorFactory object is loaded from memory if exists and context is initialized with the new context. So, other constraints after the nested constraints PropertyPath would be wrong.
So I think better create a new object for CollectionValidator always.
see this https://gist.github.com/alexkappa/5851274
It shows [name][email] even though the email is not under the name node.
Commits
-------
28e0709 [Validator] fixed ConstraintViolation:: incorrect when nested
This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes#7930).
Discussion
----------
handle Optional and Required constraints from XML or YAML sources correc...
...tly
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7575
| License | MIT
| Doc PR | symfony/symfony-docs#2432
Commits
-------
a93a23a handle Optional and Required constraints from XML or YAML sources correctly
This PR was merged into the 2.2 branch.
Discussion
----------
[Validator] Fixed groups argument misplace for validateValue method from validator class
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Signature of validateValue method in ExecutionContext Class is this.
```
public function validateValue($value, $constraints, $subPath = '', $groups = null)
```
But this was called wrongly in Validator Class.
Commits
-------
d3eb9b7 [Validator] Fixed groups argument misplace for validateValue method from validator class
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8453).
Discussion
----------
added missing comments to WebTestCase
Added comments that are required for autocompletion when extending WebTestCase.
Commits
-------
d056e6b added missing comments to WebTestCase
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8456).
Discussion
----------
[Process] Fixed#8455: PhpExecutableFinder::find() does not always return the correct binary
Since `PHP_BINARY` is the very first approach considered, there is no way to use a workaround like setting the `PHP_PATH`.
Checking `PHP_PATH` could potentially be put before checking `PHP_BINARY`: that would avoid an extra function call (and system call), at the price of a small BC_BREAK, but I think it's better in this case to have a solution that doesn't force people to set the `PHP_PATH` environment variable.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8455
| License | MIT
| Doc PR | none
Commits
-------
35a2fe4 [Process] Fixed#8455: PhpExecutableFinder::find() does not always return the correct binary
This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Fix Container::camelize to convert beginning and ending . and _
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7431
| License | MIT
| Doc PR | n/a
I'm using strtr to make the conversion in order to ensure that the behavior is the same as `Container::get`.
From the test cases I've added, the following were not passing:
Commits
-------
485d53a [DependencyInjection] Fix Container::camelize to convert beginning and ending chars
This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Add exception for service name not dumpable in PHP
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8485#8030
| License | MIT
| Doc PR | n/a
Throws an exception when the DIC is dumped to PHP, before generating invalid PHP.
The regex comes from the PHP doc: http://www.php.net/manual/en/language.oop5.basic.php
Commits
-------
242b318 [DependencyInjection] Add exception for service name not dumpable in PHP
This PR was merged into the 2.2 branch.
Discussion
----------
[Security] fixed issue where x509 authentication clears unrelated tokens
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8226
| License | MIT
| Doc PR | symfony/symfony-docs#2825
| Notes | Replaces PR #8283
TODO:
- [x] Feedback on change to make sure security is not affected
- [x] Fix other authentication listeners (they suffer the same problem)
- [x] Write unit tests for bug and maybe a few listener classes as well
This pull request is the summary of the problem mentioned in the ticket above.
It only fixes the "disappearing token" problem for one authentication provider, not all. If acceptable, the change needs to be applied to all authentication listeners since they always clear all tokens from the security context.
Commits
-------
2317443 [Security] fixed issue where authentication listeners clear unrelated tokens
This commit fixes an issue where authentication listeners clear all security tokens in case of authentication failure.
This behavior makes it impossible to combine certain authentication mechanisms, notably x509 with form-based login.
This PR was merged into the 2.2 branch.
Discussion
----------
[bridge] [propel1] [ModelChoiceList] fix issue #8499 call getPrimaryKey on a non object
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8499
| License | MIT
| Doc PR | no
This fix an issue #8499 introduced by the PR #8223
CC @willdurand @havvg
Commits
-------
2ebb783 fix issue #8499 modelChoiceList call getPrimaryKey on a non object
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8479).
Discussion
----------
[HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8460
| License | MIT
| Doc PR | -
**warning** I did not try to reproduce this bug, so I am not sure it fixes the issue. I just open a PR with the suggested patch. Tests for http foundation are OK. I am not sur it's the best way to fix this issue as I do not understand why symfony reach this code if $_SESSION is not set.
Commits
-------
f5d59fb [HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8477).
Discussion
----------
Reverts recent change that added type coercion for JSON responses
We shouldn't be coercing primitive in the array provided to setData.
Commits
-------
02e6aef Reverts JSON_NUMERIC_CHECK
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8476).
Discussion
----------
Just a typo
Just a typo in the doc
Commits
-------
fdaf59f Just a Typo
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8465).
Discussion
----------
[Config] Fixed error messages of min/max validation methods
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This PR fixes the error messages of the configuration validation methods `min` and `max`. The error message was "Should be greater/less than: <value>" but should be "Should be greater/less than or equal to <value>".
Commits
-------
3395837 Fixing configuration validation error messages.