Fabien Potencier
0a6a1c44c0
bug #10591 [Form] Buttons are now disabled if their containing form is disabled (webmozart)
...
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Buttons are now disabled if their containing form is disabled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10109
| License | MIT
| Doc PR | -
Commits
-------
ebfee72
[Form] Added test for disabling buttons
6bb355e
[Form] Added check for parent disabled status in Button form elements
2014-03-31 12:57:57 +02:00
Romain Neutron
c2ffefd0ef
Use Filesystem::chmod
instead of chmod
when dumping file
...
This adds consistency as discussed in ca5eea5c19 (commitcomment-5804089)
2014-03-31 12:15:50 +02:00
Fabien Potencier
bafced661f
bug #10567 [Form] Disabled validation/violation mapping of unsubmitted forms (webmozart)
...
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Form] Disabled validation/violation mapping of unsubmitted forms
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9998
| License | MIT
| Doc PR | -
This PR fixes submissions of PATCH form in the case that any of the non-submitted forms causes an error (such as not-null).
Commits
-------
9dfebd5
[Form] Disabled violation mapping of unsubmitted forms
2014-03-31 12:13:10 +02:00
Fabien Potencier
2cbbdbd75b
bug #10587 [2.4][Process] Fix Process test suite (romainneutron)
...
This PR was merged into the 2.4 branch.
Discussion
----------
[2.4][Process] Fix Process test suite
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
a42fbd7
[Process] Fix Process test suite
2014-03-31 12:08:09 +02:00
Bernhard Schussek
ebfee723c9
[Form] Added test for disabling buttons
2014-03-31 11:59:54 +02:00
Adrià López Lozano
6bb355e2fd
[Form] Added check for parent disabled status in Button form elements
...
The Button form element did not check for the parent disabled configuration status,
making them behave differently to all other form widgets.
2014-03-31 11:59:54 +02:00
Bernhard Schussek
f7fb855f46
[PropertyAccess] Added missing exceptions to phpdoc
2014-03-31 10:36:17 +02:00
Bernhard Schussek
9dfebd529e
[Form] Disabled violation mapping of unsubmitted forms
2014-03-31 10:27:06 +02:00
Romain Neutron
a42fbd7ade
[Process] Fix Process test suite
2014-03-31 10:11:45 +02:00
Tim Nagel
91e226e06e
Fixes URL validator to accept single part urls
2014-03-31 10:23:29 +11:00
Bernhard Schussek
ca6a722a45
[Validator] Converted @deprecate
doc comment into regular doc comment
2014-03-30 20:08:02 +02:00
Bernhard Schussek
68d80187ed
[Validator] Documented changes in the UPGRADE files
2014-03-30 20:03:32 +02:00
Bernhard Schussek
b1badeaa1f
[Validator] Fixed failing CsrfFormLoginTest
2014-03-30 18:56:20 +02:00
Bernhard Schussek
0bfde4a44b
[Validator] Fixed misnamed method calls in FrameworkExtension
2014-03-30 18:31:31 +02:00
Bernhard Schussek
3dc2b4d861
[Validator] Made "symfony/property-access" an optional dependency
2014-03-30 18:31:31 +02:00
Bernhard Schussek
c5629bb7ee
[Validator] Added getObject() to ExecutionContextInterface
2014-03-30 18:31:00 +02:00
Bernhard Schussek
9b204c9354
[FrameworkBundle] Implemented configuration to select the desired Validator API
2014-03-30 18:31:00 +02:00
Bernhard Schussek
0946dbe7a0
[Validator] Adapted CHANGELOG
2014-03-30 18:30:09 +02:00
Bernhard Schussek
1b111d0e83
[Validator] Fixed typos pointed out by @cordoval
2014-03-30 18:30:09 +02:00
Bernhard Schussek
7bc952de55
[Validator] Improved inline documentation of RecursiveContextualValidator
2014-03-30 18:30:09 +02:00
Bernhard Schussek
166d71a7de
[Validator] Removed unused property
2014-03-30 18:30:09 +02:00
Bernhard Schussek
90c27bb1e7
[Validator] Removed traverser implementation
...
The traverser is too slow compared to the current, recursive approach.
Testing showed a performance decrease of about 70% without a lot of
optimization potential.
2014-03-30 18:30:09 +02:00
Bernhard Schussek
3183aed7cd
[Validator] Improved performance of cache key generation
2014-03-30 18:30:09 +02:00
Bernhard Schussek
029a71638e
[Validator] Moved logic of replaceDefaultGroup() to validateNode()
2014-03-30 18:30:09 +02:00
Bernhard Schussek
2f23d9725b
[Validator] Reduced number of method calls on the execution context
2014-03-30 18:30:09 +02:00
Bernhard Schussek
73c9cc5806
[Validator] Optimized performance by calling spl_object_hash() only once per object
2014-03-30 18:30:09 +02:00
Bernhard Schussek
94ef21e495
[Validator] Optimized use statements
2014-03-30 18:30:09 +02:00
Bernhard Schussek
1622eb3a98
[Validator] Fixed reference to removed class in ValidatorBuilder
2014-03-30 18:28:59 +02:00
Bernhard Schussek
be508e01dd
[Validator] Merged DefaultGroupReplacingVisitor and ContextUpdateVisitor into NodeValidationVisitor
2014-03-30 18:28:59 +02:00
Bernhard Schussek
50bb84d06b
[Validator] Optimized RecursiveContextualValidator
2014-03-30 18:28:59 +02:00
Bernhard Schussek
eed29d8ad3
[Validator] Improved performance of *ContextualValidator::validate()
2014-03-30 18:28:59 +02:00
Bernhard Schussek
5c479d803c
[Validator] Simplified validateNodeForGroup
2014-03-30 18:28:59 +02:00
Bernhard Schussek
eeed509dfc
[Validator] Improved phpdoc of RecursiveValidator
2014-03-30 18:28:59 +02:00
Bernhard Schussek
274d4e6195
[Validator] Changed ValidatorBuilder to always use LegacyExecutionContext
...
This is necessary because, until Symfony 3.0, constraint validators will continue
to rely on the old context methods in order to be backwards compatible.
2014-03-30 18:28:59 +02:00
Bernhard Schussek
38e26fbcaf
[Validator] Decoupled RecursiveContextualValidator from Node
2014-03-30 18:28:59 +02:00
Bernhard Schussek
23534ca6ab
[Validator] Added a recursive clone of the new implementation for speed comparison
2014-03-30 18:28:59 +02:00
Bernhard Schussek
f61d31e5fa
[Validator] Fixed grammar
2014-03-30 18:28:58 +02:00
Bernhard Schussek
886e05e7ed
[Validator] Removed unused use statement
2014-03-30 18:28:58 +02:00
Bernhard Schussek
93fdff764a
[Validator] The supported API versions can now be passed to the ValidatorBuilder
2014-03-30 18:28:58 +02:00
Bernhard Schussek
987313d315
[Validator] Improved inline documentation of the violation builder
2014-03-30 18:28:58 +02:00
Bernhard Schussek
79387a7d5e
[Validator] Improved inline documentation of the metadata classes
2014-03-30 18:28:58 +02:00
Bernhard Schussek
01ceeda376
[Validator] Improved test coverage of the Traverse constraint
2014-03-30 18:28:58 +02:00
Bernhard Schussek
9ca61df923
[Validator] Improved inline documentation of CascadingStrategy and TraversalStrategy
2014-03-30 18:28:58 +02:00
Bernhard Schussek
524a9538bc
[Validator] Improved inline documentation of the validators
2014-03-30 18:28:58 +02:00
Bernhard Schussek
9986f03ce2
[Validator] Added inline documentation for the PropertyPath utility class
2014-03-30 18:28:58 +02:00
Bernhard Schussek
be7f055237
[Validator] Visitors may now abort the traversal by returning false from beforeTraversal()
2014-03-30 18:28:58 +02:00
Bernhard Schussek
299c2dca10
[Validator] Improved test coverage and prevented duplicate validation of constraints
2014-03-30 18:28:58 +02:00
Bernhard Schussek
186c115894
[Validator] Improved test coverage of NonRecursiveNodeTraverser
2014-03-30 18:28:58 +02:00
Bernhard Schussek
822fe4712f
[Validator] Completed inline documentation of the Node classes and the NodeTraverser
2014-03-30 18:28:58 +02:00
Bernhard Schussek
dbce5a2f6a
[Validator] Updated outdated doc blocks
2014-03-30 18:28:58 +02:00