This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] Flatten "exception" controller argument if not typed
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Fixes a BC break and makes it easier for libs to support both debug & error-handler e.g. https://github.com/api-platform/core/pull/3246#discussion_r346912822
Commits
-------
585216a8e8 [HttpKernel] Flatten "exception" controller argument if not typed
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.
Discussion
----------
[HttpFoundation] Fix MySQL column type definition.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? |no
| Deprecations? | no
| Tickets | Fix#34409
| License | MIT
| Doc PR | symfony/symfony-docs#12641
Fix wrong MySQL column type definition causing Numeric value out of range exception.
Commits
-------
51c5f69274 Fix MySQL column type definition.
* 3.4:
Link the right file depending on the new version
[Finder] Allow ssh2 stream wrapper for sftp
[WebProfilerBundle] Require symfony/twig-bundle
bumped Symfony version to 3.4.36
updated VERSION for 3.4.35
updated CHANGELOG for 3.4.35
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.
Discussion
----------
Link the right file depending on the new version
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix url doc upgrading to 4.x
| License | MIT
Link the right file depending on the new version
Commits
-------
7e38d83ad0 Link the right file depending on the new version
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Cache] Redis Tag Aware warn on wrong eviction policy
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| Deprecations? | no
| Tickets | n.a.
| License | MIT
| Doc PR | n.a.
Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.
This PR replaces #34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.
TODO:
- [x] ~Adapt test setups for this to set correct eviction policy~ _It already uses default noeviction_
Commits
-------
e77f6de1e8 [Cache] Redis Tag Aware warn on wrong eviction policy
This PR was merged into the 4.3 branch.
Discussion
----------
[Config] fix id-generation for GlobResource
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I never encountered any issues related to this but still, it's a fix.
Commits
-------
6adbfa2ae7 [Config] fix id-generation for GlobResource
This PR was merged into the 3.4 branch.
Discussion
----------
[Finder] Allow ssh2 stream wrapper for sftp
Same fix as #28604 but for the ssh2.sftp wrapper.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#28604 maybe
| License | MIT
| Doc PR |
Without this patch, we can't use the finder with ssh2.sftp connections.
```php
$connection = \ssh2_connect('host', 22);
\ssh2_auth_password($connection, 'user', 'pass');
$sftp = \ssh2_sftp($connection);
$path = "ssh2.sftp://".intval($sftp)."/";
$finder = new Finder();
foreach ($finder->in($path)->files() as $directory) {
dump(file_get_contents($directory));
}
```
Without the patch:
> RecursiveDirectoryIterator::__construct(ssh2.sftp://838): failed to open dir: operation failed
Commits
-------
e6c9d77b63 [Finder] Allow ssh2 stream wrapper for sftp
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] dont check cache freshness more than once per process
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
While running some functional tests in a loop, I noticed that half the time is spent computing cache freshness. This makes no sense - this mechanism is supposed to run once per process.
Here is the Blackfire comparison:
https://blackfire.io/profiles/compare/a4f2eb44-ae85-440b-ae87-edf43c2b2ef7/graph
Commits
-------
7f9556ce19 [HttpKernel] dont check cache freshness more than once per process
This PR was merged into the 4.3 branch.
Discussion
----------
[DI] Use reproducible entropy to generate env placeholders
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Bound arguments typically reference env vars, which are turned into random placeholders right now.
When this randomness is used in a hash to generate the internal name of a service locator, the hash is totally random.
This breaks reproducible builds.
This PR replaces true randomness with reproducible entropy.
Commits
-------
600ae33262 [DI] Use reproducible entropy to generate env placeholders
This PR was merged into the 3.4 branch.
Discussion
----------
[WebProfilerBundle] Require symfony/twig-bundle
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Starting from a fresh 3.4 I did `composer require symfony/web-profiler-bundle --dev` but it fails on post install cache clear because 8a68d2d358/src/Symfony/Bundle/WebProfilerBundle/Resources/config/profiler.xml (L13) needs the `twig` service that is declared in the `TwigBundle`.
`symfony/twig-bundle` is already a hard depency of the `WebProfilerBundle` on 4.3+ (cf cac37caa7d).
Commits
-------
78dad79fec [WebProfilerBundle] Require symfony/twig-bundle
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Add UPGRADE entry about the null transport DSN
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | N/A
| License | MIT
| Doc PR | already up-to-date
Commits
-------
abcf63aaa8 [Mailer] Add UPGRADE entry about the null transport DSN
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] Allow symfony/service-contracts v2
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
In Symfony 4.4 applications, the Form component currently prevents the installation of `symfony/service-contracts` 2.0.0. That should not be the case.
Commits
-------
4755e160be [Form] Allow symfony/service-contracts v2.
Nicolas Grekas
Robin Chalas
Jérémie Broutier
Antoine Makdessi
André R
Fabien Potencier
Damien Alexandre
Christian Flothmann
Grégoire Pineau
Thomas Calvet
Maxime Steinhausser
Alexander M. Turek
