Many tests being skipped based on the ICU data version don't actually
need it. They might be testing code paths not relying on Intl, or not
performing assertions on the values depending on the ICU data and so not
dependant on the exact ICU version being used.
This PR was merged into the 2.3 branch.
Discussion
----------
Fix the return value on error for intl methods returning arrays
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
When the resource is missing, an empty array should be returned rather than null to respect the interface saying an array is always returned.
Commits
-------
801e5e2 Fix the return value on error for intl methods returning arrays
The Intl extension accepts null as locale in formatters and the
collator and will use the default locale in such case. Given that the
stub implementation considers that the default locale is always 'en', it
should be supported here too instead of forcing libraries to pass the
default locale explicitly.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#15392).
Discussion
----------
Fix missing _route parameter notice in RouterListener logging case
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | na
| License | MIT
| Doc PR | na
`\Symfony\Component\HttpKernel\EventListener\RouterListener::onKernelRequest` missed test cases in logging condition. So if we provide routing matches without a `_route` parameter `notice` messages are thrown. In this case i added a check and use `n/a` for empty route names as this is also shown in profiler if it not exists.
Commits
-------
0ce91a6 Fix missing _route parameter notice in RouterListener logging case
* 2.7:
[php7] Fix for substr() always returning a string
[Security] Do not save the target path in the session for a stateless firewall
Fix calls to HttpCache#getSurrogate triggering E_USER_DEPRECATED errors.
[DependencyInjection] fixed FrozenParameterBag and improved Parameter…
This PR was merged into the 2.8 branch.
Discussion
----------
[Security] Small optimization in AccessDecisionManager
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | na
| License | MIT
| Doc PR | na
- Remove unused variable `$abstain`
- Remove equals comparison: if not `$grant > $deny` and not `$deny > $grant` then `$grant` equals `$deny`
Commits
-------
0e93463 Small optimization in AccessDecisionManager
This PR was merged into the 2.7 branch.
Discussion
----------
[php7] Fix for substr() always returning a string
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14086
| License | MIT
| Doc PR | -
The remaining failures will stop once https://bugs.php.net/bug.php?id=70159 is fixed ([patch pending](a28115ccdb)).
Commits
-------
d6dfe98 [php7] Fix for substr() always returning a string