This PR was merged into the 2.3 branch.
Discussion
----------
Fixed the symfony/config version constraint
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
##### This pull request fixes the `symfony/config` version constraint in the proxy manager bridge.
Before this pull, composer was only allowing `v2.3.0` to be downloaded. This surely was not the intention. I've updated the version constraint from `"2.3"` to `"~2.3"` thus allowing all 2.x versions that are equal to or greater than `v2.3.0`.
Commits
-------
ec14f0f Fixed the symfony/config version constraint
This PR was merged into the 2.3 branch.
Discussion
----------
Docblock Fixes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
##### This pull request fixes the docblock alignment as requested in #12760.
It was also necessary for me to ensure the `@return` annotations were correctly separated in order to accurately align the `@param` annotations.
Commits
-------
443307e Docblock fixes
This PR was merged into the 2.3 branch.
Discussion
----------
Tweaked the password-compat version constraint
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
##### This pull request tweaks the `"ircmaxell/password-compat` version constraint in the 2.3 branch.
I've updated the version constraint to `"~1.0"` match the way we require all "stable" releases. Note that this version constraint is technically different, but I consider it safe still.
Commits
-------
f703e56 Tweaked the password-compat version constraint
This PR was merged into the 2.3 branch.
Discussion
----------
Fixed the syntax of a composer.json file
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
##### This pull request fixes the syntax of a composer.json file.
There should not be a space before a colon following a double quote. This is not bad syntax, but it just an inconsistency.
Commits
-------
0f8547a Fixed the syntax of a composer.json file
This PR was merged into the 2.3 branch.
Discussion
----------
[ClassLoader] define constant only if it wasn't defined before
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
388229b define constant only if it wasn't defined before
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#12644).
Discussion
----------
Fix incorrect spanish translation
SymfonyCon Madrid 2014 Hackday
Commits
-------
28b07ba Fix incorrect spanish translation
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#12553).
Discussion
----------
[Debug] fix error message on double exception
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
1ed7606 [Debug] fix error message on double exception
This PR was merged into the 2.3 branch.
Discussion
----------
Rename Symfony2 to Symfony
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Replaces #12563
Commits
-------
0a76b7e Rename Symfony2 to Symfony
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12570).
Discussion
----------
Fix initialized() with aliased services
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12569
| License | MIT
| Doc PR |
Commits
-------
a18b6d1 Fix initialized() with aliased services
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12537).
Discussion
----------
[HttpFoundation] Make Request::get() more performant
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This finishes the work started by @KorvinSzanto in #12369.
Commits
-------
3039935 reformat code as suggested by @fabpot
ad64223 Fix typo
4162713 Make `\Request::get` more performant.
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#12137).
Discussion
----------
[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12110
| License | MIT
Test and fix of ticket #12110
Commits
-------
76273bf [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
This PR was merged into the 2.3 branch.
Discussion
----------
[Bundle][FrameworkBundle] be smarter when guessing the document root
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12524
| License | MIT
| Doc PR |
Commits
-------
e28f5b8 be smarter when guessing the document root
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12296).
Discussion
----------
[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | when relying on this configuration behaviour
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12261
| License | MIT
| Doc PR | —
See symfony/symfony#12261.
I configured a different firewall entry point for one firewall. However, when authentication had to be performed, it still called BasicAuthenticationEntryPoint::start() instead of my service's start(). My service was instantiated, yet never used.
The issue appears to be that the entry point is registered with the firewall's exception listener, but not with the BasicAuthenticationListener. This means that when the BasicAuthenticationListener determines the user has provided wrong credentials, BasicAuthenticationEntryPoint is still used. Only in case of an exception would my entry point service be used.
In my opinion, this is not correct behaviour. Can someone confirm this? Are there currently tests that pertain to the `entry_point` configuration on which I can base a test?
---
Test setup:
```yaml
# security.yml
security:
firewalls:
api:
pattern: ^/api/
http_basic: ~
entry_point: my.service
default:
anonymous: ~
```
Commits
-------
92c8dfb [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12502).
Discussion
----------
Azerbaijani locale
[Form] [Validator] [Security] Azerbaijani translation added
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Commits
-------
7f7b700 Azerbaijani locale
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12510).
Discussion
----------
Fixed grammar error in docblock
Commits
-------
ba8d937 Fixed grammar error in docblock
This PR was merged into the 2.3 branch.
Discussion
----------
compare version using PHP_VERSION_ID
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.
Commits
-------
367ed3c compare version using PHP_VERSION_ID
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12433).
Discussion
----------
[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
Commits
-------
0bd19aa [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.
