Commit Graph

20077 Commits

Author SHA1 Message Date
Nicolas Grekas
915fcd8dec [Validator] drop grapheme_strlen in LengthValidator 2015-01-26 18:35:52 +01:00
Fabien Potencier
eadc8c7de5 bug #12649 [Hackday] [Toolbar] Fix info position and icons on small screens (stefanosala)
This PR was merged into the 2.6 branch.

Discussion
----------

[Hackday] [Toolbar] Fix info position and icons on small screens

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12582
| License       | MIT
| Doc PR        | -

I changed a bit the order of profiles, IMO the dump goes closer to request data. Then I tweaked a bit the toolbar to show more icons even on smaller screen. I tested everything with Chrome and IE9 and it seems to work smoothly.

Here are some explanatory screenshots:

![](http://cl.ly/image/3E2e360Y0a15/Screen%20Shot%202014-11-29%20at%2011.56.17.png)
![](http://cl.ly/image/1d073v2v2U2J/Screen%20Shot%202014-11-29%20at%2011.56.42.png)

Commits
-------

838857c [Toolbar] Reset right and left .sf-toolbar-info values needed for window resize
23c0ddc [Toolbar] Handle info position via javascript Place info div to not float out of the window
7a8582e [Toolbar] Display all icons, even on two lines for small screens
2015-01-26 17:00:24 +01:00
Fabien Potencier
1901c84749 minor #13331 [OptionsResolver] added test for allowed values and types that default to null (Tobion)
This PR was merged into the 2.6 branch.

Discussion
----------

[OptionsResolver] added test for allowed values and types that default to null

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Added test to keep logic as experienced in #12809

Commits
-------

0b42cad [OptionsResolver] added test for allowed values and types that default to null
2015-01-26 16:57:35 +01:00
Fabien Potencier
cca8905518 [Validator] simplified some code 2015-01-26 16:52:15 +01:00
Dawid Sajdak
58bf5822b2 Unique Entity Validator Invalid Value 2015-01-26 14:32:32 +01:00
Kévin Dunglas
e14854fe22 [Serializer] Name converter support 2015-01-25 20:53:10 +01:00
Fabien Potencier
6cd28737f6 minor #13520 [twig] Fix getComputedData in new twig profiler (jeremy-derusse)
This PR was merged into the 2.7 branch.

Discussion
----------

[twig] Fix getComputedData in new twig profiler

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | should be
| Fixed tickets | NA
| License       | MIT
| Doc PR        | NA

Add a small fix to #13428

Commits
-------

e8ca06a Fix getComputedData
2015-01-25 19:46:23 +01:00
Jérémy Derussé
e8ca06aaa0 Fix getComputedData 2015-01-25 19:37:18 +01:00
Fabien Potencier
9e8cb01fde feature #13428 Added a Twig profiler (fabpot)
This PR was merged into the 2.7 branch.

Discussion
----------

Added a Twig profiler

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #6914
| License       | MIT
| Doc PR        | n/a

This PR integrates the new Twig 1.18 Profiler (see twigphp/Twig#1597) into Symfony (replace the current TimedTwigEngine) and adds  a new Twig panel.

The timers are now available for all rendered templates (TimedTwigEngine was only able to get information from a few of them -- mainly the first template only).

The Twig panel gives you a lot of information about the execution of the templates, including a call graph.

![image](https://cloud.githubusercontent.com/assets/47313/5773885/fdf6756e-9d67-11e4-8dce-5ec20b07eca9.png)

![image](https://cloud.githubusercontent.com/assets/47313/5773892/0ae24d5c-9d68-11e4-9cbe-767bc31c9152.png)

![image](https://cloud.githubusercontent.com/assets/47313/5773897/13c0b6b6-9d68-11e4-95a1-b9188aca9651.png)

![image](https://cloud.githubusercontent.com/assets/47313/5773902/1c5498d8-9d68-11e4-975e-9822385fb836.png)

![image](https://cloud.githubusercontent.com/assets/47313/5773917/4eba00ba-9d68-11e4-8114-0a2d05eae5ea.png)

Commits
-------

daad64f added a Twig panel to the WebProfiler
ef0c967 integrated the Twig profiler
2015-01-25 19:20:11 +01:00
Fabien Potencier
daad64fa54 added a Twig panel to the WebProfiler 2015-01-25 19:12:34 +01:00
Fabien Potencier
ef0c9679cb integrated the Twig profiler 2015-01-25 19:10:07 +01:00
Fabien Potencier
975b8a8f7d bug #13376 [FrameworkBundle][config] allow multiple fallback locales. (aitboudad)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle][config] allow multiple fallback locales.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #13373
| Doc PR        | symfony/symfony-docs#4834
| Tests pass?   | yes
| License       | MIT

Commits
-------

1251f0e [FrameworkBundle][config] allow multiple fallback locales.
2015-01-25 15:17:32 +01:00
Abdellatif Ait boudad
1251f0e0b2 [FrameworkBundle][config] allow multiple fallback locales. 2015-01-25 14:06:13 +00:00
Fabien Potencier
cf440f260f fixed condition 2015-01-25 12:00:33 +01:00
Fabien Potencier
3015f12b20 minor #13518 [SecurityBundle] fixed tests where cleanup was not done properly (fabpot)
This PR was merged into the 2.6 branch.

Discussion
----------

[SecurityBundle] fixed tests where cleanup was not done properly

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

f853cf2 [SecurityBundle] fixed tests where cleanup was not done properly
2015-01-25 10:03:10 +01:00
Fabien Potencier
155a8def14 Merge branch '2.5' into 2.6
* 2.5:
  [HttpKernel] fixed tests
2015-01-25 09:45:24 +01:00
Fabien Potencier
82130a0e55 Merge branch '2.3' into 2.5
* 2.3:
  [HttpKernel] fixed tests
2015-01-25 09:45:13 +01:00
Fabien Potencier
f853cf2dd9 [SecurityBundle] fixed tests where cleanup was not done properly 2015-01-25 07:09:57 +01:00
Fabien Potencier
0fa19bde9f fixed tests 2015-01-25 06:59:26 +01:00
Fabien Potencier
92da9964ad fixed PHP 5.3 compat 2015-01-25 06:50:37 +01:00
Fabien Potencier
51983d0583 minor #13516 [HttpKernel] fixed tests (fabpot)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpKernel] fixed tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

a3f0299 [HttpKernel] fixed tests
2015-01-25 06:24:12 +01:00
Fabien Potencier
a3f0299d5a [HttpKernel] fixed tests 2015-01-25 06:22:15 +01:00
Fabien Potencier
2570042937 Merge branch '2.6' into 2.7
* 2.6:
  [2.3] [HttpFoundation] [MimeTypeGuesser]
  Removed dead code and various cleaning
  Removed dead code and various cleaning
  [FrameworkBundle][xsd] added missing logging attribute.
  [Console] Make it clear that the second argument is not about command options.
  Added the '-' character for spaceless on tag start and end to be consistent for block, if, set and for nodes
  [Yaml] fixed parse shortcut Key after unindented collection.
  [Console] fixed #10531
  Make the container considered non-fresh if the environment parameters are changed
2015-01-25 05:39:35 +01:00
Fabien Potencier
29e2c0d355 Merge branch '2.5' into 2.6
* 2.5:
  [2.3] [HttpFoundation] [MimeTypeGuesser]
  Removed dead code and various cleaning
  [Console] Make it clear that the second argument is not about command options.
  Added the '-' character for spaceless on tag start and end to be consistent for block, if, set and for nodes
  [Yaml] fixed parse shortcut Key after unindented collection.
  [Console] fixed #10531
  Make the container considered non-fresh if the environment parameters are changed

Conflicts:
	src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
2015-01-25 05:39:26 +01:00
Fabien Potencier
8f9af3a23a Merge branch '2.3' into 2.5
* 2.3:
  [2.3] [HttpFoundation] [MimeTypeGuesser]
  Removed dead code and various cleaning
  [Console] Make it clear that the second argument is not about command options.
  Added the '-' character for spaceless on tag start and end to be consistent for block, if, set and for nodes
  [Yaml] fixed parse shortcut Key after unindented collection.
  [Console] fixed #10531
  Make the container considered non-fresh if the environment parameters are changed

Conflicts:
	src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
	src/Symfony/Bridge/Twig/Resources/views/Form/form_table_layout.html.twig
	src/Symfony/Component/Console/Tests/ApplicationTest.php
	src/Symfony/Component/Security/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
2015-01-25 05:37:39 +01:00
Fabien Potencier
92c7635161 bug #13473 [FrameworkBundle][xsd] added missing logging attribute. (aitboudad)
This PR was merged into the 2.6 branch.

Discussion
----------

[FrameworkBundle][xsd] added missing logging attribute.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | ~
| Tests pass?   | yes
| License       | MIT

Commits
-------

7e19fab [FrameworkBundle][xsd] added missing logging attribute.
2015-01-25 05:25:56 +01:00
Fabien Potencier
3ccb0fcfd9 minor #13470 [2.7] Removed dead code and various cleaning (saro0h)
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: https://github.com/symfony/symfony/pull/13488 & https://github.com/symfony/symfony/pull/13481

Commits
-------

9272f86 Removed dead code and various cleaning
2015-01-25 05:21:35 +01:00
Fabien Potencier
3ee74e54a4 minor #13481 [2.6] Removed dead code and various cleaning (saro0h)
This PR was merged into the 2.6 branch.

Discussion
----------

[2.6] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of this one: https://github.com/symfony/symfony/pull/13488/

Commits
-------

dbbe170 Removed dead code and various cleaning
2015-01-25 05:20:58 +01:00
Fabien Potencier
8892cf06c1 minor #13488 [2.3] Removed dead code and various cleaning (saro0h)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

50973ba Removed dead code and various cleaning
2015-01-25 05:18:27 +01:00
Fabien Potencier
48265c9ab2 fixed tests 2015-01-25 05:13:33 +01:00
Fabien Potencier
3be180dbb2 minor #12546 [OptionsResolver] replaced some exception messages (issei-m)
This PR was submitted for the 2.6 branch but it was merged into the 2.7 branch instead (closes #12546).

Discussion
----------

[OptionsResolver] replaced some exception messages

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

In accordance with renaming of methods.

Commits
-------

5e5ba39 [OptionsResolver] replaced some exception messages
2015-01-25 05:11:59 +01:00
Issei.M
5e5ba393f1 [OptionsResolver] replaced some exception messages 2015-01-25 05:11:58 +01:00
Fabien Potencier
db4eb0f509 feature #11129 Added i18n support to ConfirmationQuestion (WouterJ)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #11129).

Discussion
----------

Added i18n support to ConfirmationQuestion

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/4879

For instance, when creating a dutch cli app, you want this to be `j` (from "Ja") instead of the english `y`.

Commits
-------

c2f3f89 Added i18n support to ConfirmationQuestion
2015-01-25 05:09:28 +01:00
WouterJ
c2f3f897d6 Added i18n support to ConfirmationQuestion 2015-01-25 05:09:28 +01:00
Fabien Potencier
aa0bf6c396 bug #12972 Make the container considered non-fresh if the environment parameters are changed (thewilkybarkid)
This PR was merged into the 2.3 branch.

Discussion
----------

Make the container considered non-fresh if the environment parameters are changed

| Q             | A
| ------------- | ---
| Bug fix?      | not really
| New feature?  | kind of
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11365
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/4645

Fixes #11365 by making the container non-fresh if any of the prefixed environment parameters are added/removed/changed. Not a bug as it was documented as behaving as such, but I think it's worth applying to 2.3 rather than considering it a new feature.

Commits
-------

b49fa12 Make the container considered non-fresh if the environment parameters are changed
2015-01-25 05:04:46 +01:00
Fabien Potencier
5dd44b6f37 bug #13309 [Console] fixed 10531 (nacmartin)
This PR was merged into the 2.3 branch.

Discussion
----------

[Console] fixed 10531

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10531
| License       | MIT
| Doc PR        | -

This is a fix for #10531. It works by extracting all the parent namespaces of a command.

Commits
-------

e6afff4 [Console] fixed #10531
2015-01-25 05:00:20 +01:00
Fabien Potencier
a96291449d feature #13034 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result (xelaris)
This PR was squashed before being merged into the 2.7 branch (closes #13034).

Discussion
----------

[HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12944
| License       | MIT
| Doc PR        |

With this PR HTTP status codes are provided in the search results to simplify identification of particular requests.
For the schema-less storage implementations (memcache(d), redis, mongodb) and the default file storage, it should work without purging existing profiles. But the code could be simplified, if it is an option to expect old profiles to be purged. For database driven storages (mysql, sqlite), the `sf_profiler_data` table must be dropped anyway (if the table isn't altered manually by adding the `status_code` column). Thus the changes are not fully BC.

![profiler-search-results](https://cloud.githubusercontent.com/assets/2466932/5499453/3cc6ad70-8730-11e4-81e5-13bfd1140d00.png)

Commits
-------

34ecda5 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result
2015-01-25 04:57:36 +01:00
Alexander Schwenn
34ecda5026 [HttpKernel] [WebProfilerBundle] added HTTP status to profiler search result 2015-01-25 04:57:33 +01:00
Fabien Potencier
4b368937a8 bug #13352 [Yaml] fixed parse shortcut Key after unindented collection. (aitboudad)
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] fixed parse shortcut Key after unindented collection.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Fixed tickets  | #13345, #8093, #11019 and #10885
| Tests pass?   | yes
| License       | MIT

Commits
-------

58a7426 [Yaml] fixed parse shortcut Key after unindented collection.
2015-01-25 04:54:01 +01:00
Fabien Potencier
3ed00a870a Merge branch '2.6' into 2.7
* 2.6:
  [Form] fixed form tests when using 2.7 deps
  [TwigBridge] Fix bootstrap rendering when user explicitly use form_label
  Fixed HtmlDumper with long string

Conflicts:
	src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php
2015-01-25 04:36:33 +01:00
Fabien Potencier
b36900ed33 minor #13515 [Form] fixed form tests when using 2.7 deps (fabpot)
This PR was merged into the 2.6 branch.

Discussion
----------

[Form] fixed form tests when using 2.7 deps

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This PR allows tests to pass for the Form subtree-split when using any version of the Validator component. The build was broken because the 2.4 API works in the same way as the 2.5 one in Symfony 2.7, so the cause is set. Testing the implementation of the context allows to know whether to expect the cause more reliably.

Commits
-------

a55f5c8 [Form] fixed form tests when using 2.7 deps
2015-01-25 04:35:46 +01:00
Fabien Potencier
9c6339ecea bug #13503 [Routing] merge instead of replace class and method scheme/method annotations (Tobion)
This PR was merged into the 2.7 branch.

Discussion
----------

[Routing] merge instead of replace class and method scheme/method annotations

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | slightly (but since it only widens the scheme/method requirements, it should not really affect anyone)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7132
| License       | MIT
| Doc PR        |

Using replace for schemes/methods makes no sense, since it's not associative. So it can produce unexpected outcomes as demonstrated in the referenced ticket.

I chose 2.7 as  target branch because it's a bug fix but also a minor change in behavior. I also added more and better tests.

Commits
-------

e2505b5 [Routing] merge instead of replace class and method scheme/method annotations
2015-01-25 04:34:48 +01:00
Fabien Potencier
17184f3d4f minor #13509 [2.3] [HttpFoundation] [MimeTypeGuesser] Updated exception in MimeTypeGuesser (phansys)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [HttpFoundation] [MimeTypeGuesser] Updated exception in MimeTypeGuesser

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12857
| License       | MIT
| Doc PR        | none

Updated exception message in MimeTypeGuesser when no guessers available
(issue #12857).

Commits
-------

1e4a8d5 [2.3] [HttpFoundation] [MimeTypeGuesser]
2015-01-25 04:31:43 +01:00
Fabien Potencier
a55f5c8dda [Form] fixed form tests when using 2.7 deps 2015-01-25 04:25:09 +01:00
Fabien Potencier
c5407f1cde minor #13513 [TwigBundle] made AppVariable compatible with 3.0 (fabpot)
This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] made AppVariable compatible with 3.0

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

bf066da [TwigBundle] made AppVariable compatible with 3.0
2015-01-25 03:39:31 +01:00
Fabien Potencier
bf066dace2 [TwigBundle] made AppVariable compatible with 3.0 2015-01-25 03:38:09 +01:00
Fabien Potencier
89e57ec523 fixed error message 2015-01-25 03:16:21 +01:00
Fabien Potencier
62decf0bf7 minor #13512 [TwigBridge] fixed AppVariable compat with older Symfony versions (fabpot)
This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBridge] fixed AppVariable compat with older Symfony versions

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

b0d041f [TwigBridge] fixed AppVariable compat with older Symfony versions
2015-01-25 03:00:56 +01:00
Fabien Potencier
b0d041fd60 [TwigBridge] fixed AppVariable compat with older Symfony versions 2015-01-25 02:59:50 +01:00
Fabien Potencier
24d0748cc4 minor #13511 [Validator] re-added support for 2.4 API version in tests (fabpot)
This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] re-added support for 2.4 API version in tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Alternative to #13414

Commits
-------

b72ef6b [Validator] re-added support for 2.4 API version in tests
2015-01-25 02:23:21 +01:00