This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.
Discussion
----------
Fix typo in comment
| Q | A
| ------------- | ---
| Branch? | 5.x <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
-->
fixed spelling below.
* possibe -> possible
Commits
-------
ca93ae5b1a Fix typo in comment
This PR was merged into the 5.2 branch.
Discussion
----------
[Security] Removing Unused AnonymousPassport
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | not needed
This is not used - it's leftover from the security component authenticator changes. I double-checked with @wouterj.
Cheers!
Commits
-------
79571e0e77 Removing AnonymousPassport
* 5.2:
Bump Symfony version to 5.2.0
Update VERSION for 5.2.0-RC2
Update CHANGELOG for 5.2.0-RC2
Display debug info
[HttpFoundation] Typo on deprecation package name
[DoctrineBridge] drop binary variants of UID types
[HttpClient] don't fallback to HTTP/1.1 when HTTP/2 streams break
Default to user provider, if available, in password upgrader
fix lexing nested sequences/mappings
This PR was merged into the 5.1 branch.
Discussion
----------
[Cache] Fix CI because of Couchbase version
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
It looks likes the version 3.0 of the couchbase extension does not exposes the `\CouchbaseCluster` class anymore.
I didn't find documentaiton about the BC break, but their documentation changes
version 2.6 => https://docs.couchbase.com/php-sdk/2.6/managing-connections.html
version 3.0 => https://docs.couchbase.com/php-sdk/current/howtos/managing-connections.html
It wasn't reported before, because `shivammathur/setup-php` added the extension 3days ago https://github.com/shivammathur/setup-php/pull/337
Sounds like the adapter were never tested, because the extension where missing and phpunit skipped the tests.
Commits
-------
fcbf0bf76e Display debug info
This PR was merged into the 5.2 branch.
Discussion
----------
[HttpFoundation] Typo on deprecation package name
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
4c6f4c7b9c [HttpFoundation] Typo on deprecation package name
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Messenger] Allow InMemoryTransport to serialize message
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | Fix#38893
| License | MIT
| Doc PR | wip
This introduce a query parameter in dsn to enable serialization as @Nyholm has suggested in #38893
`in-memory://?serialize=true`
Commits
-------
46a8007afc [Messenger] Allow InMemoryTransport to serialize message
This allows us to remove autoload calls that are necessary for the
persistence 1 backwards-compatibility layer to work.
The require-dev constraints on doctrine/orm are bumped to ^2.7.3 because
lower versions are not compatible with doctrine/persistence 2.
This PR was merged into the 5.2 branch.
Discussion
----------
[DoctrineBridge] drop binary variants of UID types
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | #39112
| License | MIT
| Doc PR | -
#39112 made me realize that when the DB engine doesn't have a native UUID/GUID type, there's no benefit to representing ULIDs as UUIDs.
This PR proposes to use the native GUID type for both UUIDs and ULIDs only when the DB engine provides such a type, and to use `BINARY(16)` when the DB engine doesn't have a native GUID type.
This leaves us in a situation where, whether the DB engine supports GUID natively or not, UUID and ULID are always stored in the most compact format.
This makes the "binary" variants useless.
MySQL 8 has [functions](https://mysqlserverteam.com/mysql-8-0-uuid-support/) to deal with binary GUID, and so does [SQLite](https://sqlite.org/src/file/ext/misc/uuid.c).
Commits
-------
bdfc20520e [DoctrineBridge] drop binary variants of UID types
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpClient] don't fallback to HTTP/1.1 when HTTP/2 streams break
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix https://github.com/composer/composer/issues/9481
| License | MIT
| Doc PR | -
With this change, I don't reproduce the failures that I describe in https://github.com/composer/composer/issues/9481 when running the script in #38690
Apparently curl has an issue when both h1.1 and h2 connections are open to the same host.
Instead of switching to HTTP/1.1 when retrying requests that failed because of an HTTP/2 stream error, I propose to close the http/2 connection when issuing a retry.
With this change, running the mirroring script of packagist works like a charm.
No need to investigate your mirrors @Seldaek, this was definitely a data corruption issue.
Commits
-------
0c92bc5a83 [HttpClient] don't fallback to HTTP/1.1 when HTTP/2 streams break
This PR was merged into the 5.2 branch.
Discussion
----------
[Security] Update password upgrader listener to work with the new UserBadge
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
While working on a new amazing `make:auth` maker, @jrushlow discovered that we forgot to update the `PasswordUpgradeBadge` with the 5.2 `UserBadge` changes (ref https://github.com/symfony/symfony/pull/37846).
This PR fixes it, by making the password upgrader optional and falling back to the user provider instead. Without these changes, each authenticator still needs to know the user repository/user provider in order to pass it to `PasswordUpgradeBadge`.
I'm sorry for catching this soo late in the release cycle. There is a BC break involved here, but it's (a) very unlikely to impact application code and (b) in an experimental class.
Commits
-------
e39e844606 Default to user provider, if available, in password upgrader
* 5.2:
do not depend on the actual time to fix a transient test
Run Redis Sentinel tests in GithubAction
Minor : Removed typo (extra "the" term)
Check if method inheritEnvironmentVariables exists
[PhpUnitBridge] Fix test fixture file name
* 5.1:
do not depend on the actual time to fix a transient test
Run Redis Sentinel tests in GithubAction
Minor : Removed typo (extra "the" term)
Check if method inheritEnvironmentVariables exists
[PhpUnitBridge] Fix test fixture file name
* 4.4:
do not depend on the actual time to fix a transient test
Run Redis Sentinel tests in GithubAction
Minor : Removed typo (extra "the" term)
Check if method inheritEnvironmentVariables exists
[PhpUnitBridge] Fix test fixture file name
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] do not depend on the actual time to fix a transient test
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
b7e5c7d67d do not depend on the actual time to fix a transient test
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] Run Redis Sentinel tests in GithubAction
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Add support for Sentinel tests in GHA
Commits
-------
bd84394dc5 Run Redis Sentinel tests in GithubAction
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpUnitBridge] Fix test fixture filename
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | no
| License | MIT
| Doc PR | -
Fixes PHPUnit warning `Test case class not matching filename is deprecated`. I checked that the filename being different than the class name is not "required" for the test.
Commits
-------
c5a107e4cc [PhpUnitBridge] Fix test fixture file name
* 5.2:
[Ldap] Fix undefined variable $con.
Use GithubAction to run ldap tests
Adds LDAP Adapter test in integration group
Fix critical extension when reseting paged control
Reinitialize globBrace after unserialization
* 5.1:
[Ldap] Fix undefined variable $con.
Use GithubAction to run ldap tests
Adds LDAP Adapter test in integration group
Fix critical extension when reseting paged control
Reinitialize globBrace after unserialization
This PR was merged into the 3.4 branch.
Discussion
----------
[Finder] Minor : Removed typo (extra "the" term) in hasResults() method documentation
| Q | A
| ------------- | ---
| Branch? | 3.4 (as recommended by https://symfony.com/doc/current/contributing/code/pull_requests.html#choose-the-right-branch)
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | no
| License | MIT
| Doc PR | no
Commits
-------
160cc6144c Minor : Removed typo (extra "the" term)
This PR was merged into the 4.4 branch.
Discussion
----------
[Ldap] Fix undefined variable $con
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | https://github.com/symfony/symfony/pull/39030#issuecomment-728156901
| License | MIT
| Doc PR | N/A
This PR extracts the connection resource into a variable. This will fix an undefined variable error on 5.1.
Commits
-------
15da31686a [Ldap] Fix undefined variable $con.
